usaxena95 added inline comments.

================
Comment at: lib/Basic/VirtualFileSystem.cpp:2097
 void YAMLVFSWriter::write(llvm::raw_ostream &OS) {
-  llvm::sort(Mappings, [](const YAMLVFSEntry &LHS, const YAMLVFSEntry &RHS) {
+  llvm::sort(Mappings.begin(), Mappings.end(),
+             [](const YAMLVFSEntry &LHS, const YAMLVFSEntry &RHS) {
----------------
kbobyrev wrote:
> This used `llvm::sort(Container &&C, Compare Comp)` before, I would think 
> that the range-based API is the preferred one. There's also a cleanup patch 
> migrating STL-like calls to idiomatic LLVM's STL Extension API: D52576.
I think these are some very recent changes and does not belong to my patch. 
Will sync these. Thanks for pointing out.


Repository:
  rC Clang

https://reviews.llvm.org/D52620



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to