xbolva00 added subscribers: hans, xbolva00.
xbolva00 added a comment.
is this fixed in 7.0 release branch too?
@hans
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
baloghadamsoftware updated this revision to Diff 164152.
baloghadamsoftware added a comment.
Modification of the checker not needed anymore. Only tests added.
https://reviews.llvm.org/D32906
Files:
test/Analysis/iterator-range.cpp
test/Analysis/mismatched-iterator.cpp
Index: test/Analysis
baloghadamsoftware added a comment.
Your are right, it is not necessary anymore. Should I keep this patch to add
the tests only or should I abandon it completely?
https://reviews.llvm.org/D32906
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
owenpan created this revision.
owenpan added a project: clang.
Herald added a subscriber: cfe-commits.
See https://bugs.llvm.org/show_bug.cgi?id=38854
Repository:
rC Clang
https://reviews.llvm.org/D51719
Files:
lib/Format/UnwrappedLineFormatter.cpp
unittests/Format/FormatTest.cpp
Index
sidorovd updated this revision to Diff 164157.
sidorovd added a comment.
I'm not sure if I put pragmas in an appropriate place (I mean in the very
beginning of the header).
https://reviews.llvm.org/D51402
Files:
lib/Headers/opencl-c.h
test/SemaOpenCL/extension-version.cl
Index: test/Sema
devnexen added a comment.
ping @george.karpenkov after that I won t bother you for a long time :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sidorovd created this revision.
sidorovd added reviewers: Anastasia, yaxunl.
Herald added a subscriber: cfe-commits.
sidorovd added a comment.
Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I
wasn't able to update it, so I created a new one with the comments applied.
sidorovd added a comment.
Previously this patch was reviewed here: https://reviews.llvm.org/D26794 . I
wasn't able to update it, so I created a new one with the comments applied.
Repository:
rC Clang
https://reviews.llvm.org/D51722
___
cfe-commi
AlistairD updated this revision to Diff 164162.
AlistairD added a comment.
Reworded warning message, switched warning off by default, and added it to a
group: generic-address-conversion.
https://reviews.llvm.org/D51411
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking
AlexeySachkov added inline comments.
Comment at: include/clang/Basic/OpenCLExtensionTypes.def:1
+//===-- OpenCLExtensionTypes.def - Metadata about BuiltinTypes --*- C++
-*-===//
+//
Anastasia wrote:
> I am confused about the purpose of this file. Is it suppo
ioeric created this revision.
ioeric added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Also set "deprecated" field in LSP CompletionItem.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51724
Files:
clangd/
sidorovd marked an inline comment as done.
sidorovd added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:6063
+ // OpenCL: A candidate function that uses extentions that are not enabled or
+ // supported is not viable.
+ if (getLangOpts().OpenCL) {
Ana
sidorovd updated this revision to Diff 164169.
sidorovd edited the summary of this revision.
https://reviews.llvm.org/D51341
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaOverload.cpp
test/SemaOpenCL/half-double-overload.cl
Index: test/SemaOpenCL/half-double-overload.cl
Author: hans
Date: Thu Sep 6 01:54:44 2018
New Revision: 341529
URL: http://llvm.org/viewvc/llvm-project?rev=341529&view=rev
Log:
Merging r340609:
r340609 | ldionne | 2018-08-24 16:10:28 +0200 (Fri, 24 Aug 2018) | 13 lines
Merged to 7.0 in r341529.
On Fri, Aug 24, 2018 at 4:10 PM, Louis Dionne via cfe-commits
wrote:
> Author: ldionne
> Date: Fri Aug 24 07:10:28 2018
> New Revision: 340609
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340609&view=rev
> Log:
> [libc++] Fix handling of negated character classes in
hans added a comment.
In https://reviews.llvm.org/D50534#1225591, @xbolva00 wrote:
> is this fixed in 7.0 release branch too?
>
> @hans
I've merged it in r341529 now. Thanks for letting me know.
Repository:
rCXX libc++
https://reviews.llvm.org/D50534
sammccall added a comment.
I think you also need to update SymbolsYAML and Serialization.
Comment at: clangd/Protocol.cpp:520
Result["additionalTextEdits"] = json::Array(CI.additionalTextEdits);
+ if (CI.deprecated)
+Result["deprecated"] = CI.deprecated;
-
kbobyrev updated this revision to Diff 164172.
kbobyrev marked 10 inline comments as done.
kbobyrev added a comment.
This should address the last round of comments.
There was still some hassle with the `SymbolSlab::Builder` in the unit tests
and I decided to leave it as it is due to some weird o
+1 for consistent style, but why not use enum class everywhere instead?
On Wed, Sep 5, 2018 at 12:41 PM Sam McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sammccall
> Date: Wed Sep 5 03:39:58 2018
> New Revision: 341459
>
> URL: http://llvm.org/viewvc/llvm-project?rev=3414
Any pointers to the GCC bug/breakage mentioned?
On Thu, Sep 6, 2018 at 11:44 AM Ilya Biryukov wrote:
> +1 for consistent style, but why not use enum class everywhere instead?
>
> On Wed, Sep 5, 2018 at 12:41 PM Sam McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: sammcc
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kbobyrev updated this revision to Diff 164176.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
Resolve the issue with `SymbolSlab::Builder` and make sure passed vector has
correct lifetime.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/FileDistance.h
ioeric updated this revision to Diff 164177.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- improve comment; remove dead code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51688
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CodeComplete.cpp
clangd/inde
Author: ioeric
Date: Thu Sep 6 02:59:37 2018
New Revision: 341534
URL: http://llvm.org/viewvc/llvm-project?rev=341534&view=rev
Log:
[clangd] Set SymbolID for sema macros so that they can be merged with index
macros.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, k
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341534: [clangd] Set SymbolID for sema macros so that they
can be merged with index… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.ll
dnsampaio added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
-
simark created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric,
ilya-biryukov.
It is currently possible to tell clangd where to find the
compile_commands.json file through the initializationOptions or the
didChangeConfiguration message. However, it is no
simark updated this revision to Diff 164183.
simark added a comment.
Fix formatting.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51725
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/GlobalCompilationDatabase.cpp
clangd/GlobalCompilationDatabase.h
ilya-biryukov added inline comments.
Comment at: test/Index/complete-block-property-assignment.m:71
+// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck
-check-prefix=CHECK-NO1 %s
+// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35)
---
Sorry, but my patch is not reverted, and as for now it only reads:
Failing Tests (2):
LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.ll
LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.mir
So I'm considering it was a side-effect of some other test.
On 09/05/2018 10:00 PM, Galina Kistanova
Author: ibiryukov
Date: Thu Sep 6 04:04:56 2018
New Revision: 341538
URL: http://llvm.org/viewvc/llvm-project?rev=341538&view=rev
Log:
[clangd] Fix data race in async fuzzyFind tests.
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tools-extra/trunk/
AlistairD created this revision.
AlistairD added reviewers: yaxunl, bader.
This change allows for zero assignment and comparison of queue_t type
variables, and extends null_queue.cl to test this.
https://reviews.llvm.org/D51727
Files:
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/null_queue.cl
I
JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
This makes sense to me, LGTM.
https://reviews.llvm.org/D42370
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341539: [OpenCL] Disallow negative attribute arguments
(authored by asavonic, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50259?vs=159022&id=164190#toc
Repository:
rC Clang
ht
It turned out to be a different bug: the problem was referring to
`Format::YAML` in the initializer for a variable also named `Format`.
This is legal but old versions of GCC get this wrong.
As usual with buildbot failures, I was throwing things at the wall to see
what sticks.
Regarding style - eit
Author: asavonic
Date: Thu Sep 6 04:54:09 2018
New Revision: 341539
URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev
Log:
[OpenCL] Disallow negative attribute arguments
Summary:
Negative arguments in kernel attributes are silently bitcast'ed to
unsigned, for example:
__attribute
On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits
wrote:
> Author: asavonic
> Date: Thu Sep 6 04:54:09 2018
> New Revision: 341539
>
> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev
> Log:
> [OpenCL] Disallow negative attribute arguments
>
> Summary:
> Negative argum
takuto.ikuta added a comment.
I found that current ToT with original Nico's patch does not allow to link
ui_base.dll
https://github.com/atetubou/llvm-project-20170507/tree/totwin_dbg_1236_nico
gives the following link error
https://pastebin.com/9LVRbRVn
I will do bisection to find when some inl
I would generally vouch for strongly typed enums, because there're nicer in
many aspects (no implicit integer conversions, no enumerators thrown into
the namespaces).
With regards to naming conventions, PCHStorage::Memory or
CompletionStyle::Bundled look pretty neat to me, the usual alternative for
sammccall updated this revision to Diff 164191.
sammccall added a comment.
[Tooling] JSONCompilationDatabasePlugin infers compile commands for missing
files
See the existing InterpolatingCompilationDatabase for details on how this works.
We've been using this in clangd for a while, the heuristic
sammccall added a comment.
Uh, please ignore the last comment, arc/I got confused.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
sammccall created this revision.
sammccall added a reviewer: bkramer.
Herald added subscribers: cfe-commits, kadircet, ioeric, ilya-biryukov.
See the existing InterpolatingCompilationDatabase for details on how this works.
We've been using this in clangd for a while, the heuristics seem to work we
takuto.ikuta added a comment.
In https://reviews.llvm.org/D51340#1225805, @takuto.ikuta wrote:
> I found that current ToT with original Nico's patch does not allow to link
> ui_base.dll
>
> https://github.com/atetubou/llvm-project-20170507/tree/totwin_dbg_1236_nico
> gives the following link er
On Thu, Sep 6, 2018 at 2:26 PM Ilya Biryukov wrote:
> I would generally vouch for strongly typed enums, because there're nicer
> in many aspects (no implicit integer conversions, no enumerators thrown
> into the namespaces).
>
I mostly (generally!) agree.
In particular they have strong advantages
Author: omtcyfz
Date: Thu Sep 6 05:54:43 2018
New Revision: 341542
URL: http://llvm.org/viewvc/llvm-project?rev=341542&view=rev
Log:
[clangd] Implement proximity path boosting for Dex
This patch introduces `PathURI` Search Token kind and utilizes it to
uprank symbols which are defined in files w
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341542: [clangd] Implement proximity path boosting for Dex
(authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51481?vs=164176&id=164195#toc
Repository:
rCTE Cl
dnsampaio updated this revision to Diff 164196.
dnsampaio added a comment.
Fix test march triple.
https://reviews.llvm.org/D51683
Files:
test/Headers/arm-fp16-header.c
test/Headers/arm-neon-header.c
Index: test/Headers/arm-neon-header.c
kbobyrev updated this revision to Diff 164197.
https://reviews.llvm.org/D51691
Files:
clang-tools-extra/clangd/FileDistance.h
Index: clang-tools-extra/clangd/FileDistance.h
===
--- clang-tools-extra/clangd/FileDistance.h
+++ clan
kbobyrev marked an inline comment as done.
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/FileDistance.h:89
public:
+ // Memorizes paths from \p Sources and builds efficient structure for URI
+ // distance computations. \p Sources must contain absolute pa
Author: omtcyfz
Date: Thu Sep 6 06:06:04 2018
New Revision: 341543
URL: http://llvm.org/viewvc/llvm-project?rev=341543&view=rev
Log:
[clangd] NFC: mark single-parameter constructors explicit
Code health: prevent implicit conversions to user-defined types.
Reviewed By: sammccall
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341543: [clangd] NFC: mark single-parameter constructors
explicit (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51690?
dnsampaio updated this revision to Diff 164199.
https://reviews.llvm.org/D51683
Files:
test/Headers/arm-fp16-header.c
test/Headers/arm-neon-header.c
Index: test/Headers/arm-neon-header.c
===
--- test/Headers/arm-neon-header.c
+
ilya-biryukov added inline comments.
Comment at: test/Index/complete-block-property-assignment.m:71
+// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck
-check-prefix=CHECK-NO1 %s
+// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35)
---
kbobyrev updated this revision to Diff 164200.
kbobyrev marked an inline comment as done.
https://reviews.llvm.org/D51676
Files:
clang-tools-extra/clangd/index/MemIndex.cpp
Index: clang-tools-extra/clangd/index/MemIndex.cpp
===
-
kbobyrev added a comment.
In https://reviews.llvm.org/D51676#1225215, @sammccall wrote:
> Thanks for cleaning this up!
>
> I believe this will result in the results from MemIndex being returned in
> best -> worst order, rather than worst -> best.
> The contract says callers shouldn't rely on th
Author: omtcyfz
Date: Thu Sep 6 06:15:03 2018
New Revision: 341544
URL: http://llvm.org/viewvc/llvm-project?rev=341544&view=rev
Log:
[clangd] NFC: Use TopN instead of std::priority_queue
Quality.cpp defines a structure for convenient storage of Top N items,
it should be used instead of the `std:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341544: [clangd] NFC: Use TopN instead of
std::priority_queue (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51676?vs=1
dmgreen added a comment.
These new changes look good to me.
If you are updating things like this, it's often better to create a new Phab
review so it's easier to see it's a new thing (or, in cases like this where the
changes are simple and just test updates, they often don't need review). Eithe
sammccall added a comment.
The latest reland of this patch triggers a segfault in clang (seemingly only on
k8 and ppc).
I've bisected it to r341519 but don't understand the cause.
The stacktrace is:
1. parser at end of file
2.Code generation
#0 0x5649754494d4 SignalHandler(int)
ioeric added inline comments.
Comment at: clangd/Protocol.cpp:520
Result["additionalTextEdits"] = json::Array(CI.additionalTextEdits);
+ if (CI.deprecated)
+Result["deprecated"] = CI.deprecated;
sammccall wrote:
> do we actually want this in JSON?
> (ge
ioeric updated this revision to Diff 164205.
ioeric marked an inline comment as done.
ioeric added a comment.
- Pack flags in Symbol.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51724
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Protocol.cpp
clangd/Pro
Hi Aaron,
> On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits
> wrote:
>> Author: asavonic
>> Date: Thu Sep 6 04:54:09 2018
>> New Revision: 341539
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev
>> Log:
>> [OpenCL] Disallow negative attribute arguments
>>
>> [
Author: chrib
Date: Thu Sep 6 07:03:44 2018
New Revision: 341547
URL: http://llvm.org/viewvc/llvm-project?rev=341547&view=rev
Log:
Fix the -print-multi-directory flag to print the selected multilib.
Summary: Fix -print-multi-directory to print the selected multilib
Reviewers: jroelofs
Reviewed
thakis added a comment.
What's the status here? Did this land?
https://reviews.llvm.org/D45179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chrib added a comment.
Re-commit patch at r341547 with modified test case to use an explicit root tree
for libraries
Repository:
rC Clang
https://reviews.llvm.org/D51354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
On Thu, Sep 6, 2018 at 10:00 AM, Andrew Savonichev
wrote:
> Hi Aaron,
>
>> On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits
>> wrote:
>>> Author: asavonic
>>> Date: Thu Sep 6 04:54:09 2018
>>> New Revision: 341539
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=
EricWF added a comment.
I don't think it ever landed. I'll try to get it in this week.
https://reviews.llvm.org/D45179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! There is a small comment that can be addressed before the final commit.
Thanks!
Comment at: lib/Sema/SemaExpr.cpp:14627
- // Blocks are not allowed to capture
Author: dnsampaio
Date: Thu Sep 6 07:13:10 2018
New Revision: 341548
URL: http://llvm.org/viewvc/llvm-project?rev=341548&view=rev
Log:
Fix march triple used test from rL341475
Change the march triple of test files, possible fixing
test failures due rL341475
Modified:
cfe/trunk/test/Headers
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:26
+#if __OPENCL_C_VERSION__ >= CL_VERSION_1_2
+#ifndef cl_intel_planar_yuv
+#define cl_intel_planar_yuv
@yaxunl, do you think we need to add some kind of architecture guard for such
things? Lik
Author: sammccall
Date: Thu Sep 6 07:27:40 2018
New Revision: 341549
URL: http://llvm.org/viewvc/llvm-project?rev=341549&view=rev
Log:
Revert "[DebugInfo] Generate debug information for labels. (Fix PR37395)"
This reverts commit r341519, which generates debug info that causes
backend crashes. (w
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27
+
+INTEL_SGAVC_TYPE(mce_payload_t, McePayload)
+INTEL_SGAVC_TYPE(ime_payload_t, ImePayload)
AlexeySachkov wrote:
> Anastasia wrote:
> > From the specification of this ext
sidorovd updated this revision to Diff 164214.
sidorovd added a comment.
Reference to the Spec was added
https://reviews.llvm.org/D51722
Files:
lib/Sema/SemaExpr.cpp
test/SemaOpenCL/block-array-capturing.cl
Index: test/SemaOpenCL/block-array-capturing.cl
==
rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.
Still needs a test.
https://reviews.llvm.org/D42370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: ldionne
Date: Thu Sep 6 07:46:22 2018
New Revision: 341550
URL: http://llvm.org/viewvc/llvm-project?rev=341550&view=rev
Log:
[libcxx] Add ReleaseNotes.rst file for release notes
Added:
libcxx/trunk/docs/ReleaseNotes.rst
Added: libcxx/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org
jgreenhalgh added inline comments.
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
- OS << "#define __ai static inline __attribute__((__always_inline__, "
+ OS << "#define __ai static __inline __attribute__((__always_inline__, "
"__nodebug__))\n\n";
---
Author: ldionne
Date: Thu Sep 6 08:05:43 2018
New Revision: 341551
URL: http://llvm.org/viewvc/llvm-project?rev=341551&view=rev
Log:
[libc++] Add a link to the Release notes from the main libc++ documentation
Modified:
libcxx/trunk/docs/index.rst
Modified: libcxx/trunk/docs/index.rst
URL:
whisperity added a comment.
In https://reviews.llvm.org/D50488#1225064, @george.karpenkov wrote:
> Why explicitly skip C projects? We would not be able to match `std::X`
> functions anyway.
Why spend time constructing matchers and running on the AST when we are sure
that generating any resul
Author: omtcyfz
Date: Thu Sep 6 08:10:10 2018
New Revision: 341552
URL: http://llvm.org/viewvc/llvm-project?rev=341552&view=rev
Log:
[clangd] Fix Dex initialization
This patch sets URI schemes of Dex to SymbolCollector's default schemes
in case callers tried to pass empty list of schemes. This w
Author: asavonic
Date: Thu Sep 6 08:10:26 2018
New Revision: 341553
URL: http://llvm.org/viewvc/llvm-project?rev=341553&view=rev
Log:
[OpenCL] Relax diagnostics on OpenCL access qualifiers
Summary:
Emit warning for multiple access qualifiers if they do not conflict.
Patch by Alexey Bader
Revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341553: [OpenCL] Relax diagnostics on OpenCL access
qualifiers (authored by asavonic, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51302
Files:
lib/Sema/SemaDeclAttr.cpp
lib/Sema
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341553: [OpenCL] Relax diagnostics on OpenCL access
qualifiers (authored by asavonic, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51302?vs
Author: rksimon
Date: Thu Sep 6 08:16:17 2018
New Revision: 341556
URL: http://llvm.org/viewvc/llvm-project?rev=341556&view=rev
Log:
Remove unnecessary semicolon to silence -Wpedantic warning. NFCI.
Modified:
cfe/trunk/lib/Sema/SemaExceptionSpec.cpp
Modified: cfe/trunk/lib/Sema/SemaExceptio
tstellar added a comment.
In https://reviews.llvm.org/D51714#1225545, @mgorny wrote:
> Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for
> everyone who has LLVM configured.
Yes, it is dropped from the cache, is it a problem to having the warning fire
for people who
Author: sudofortune
Date: Thu Sep 6 09:29:40 2018
New Revision: 341560
URL: http://llvm.org/viewvc/llvm-project?rev=341560&view=rev
Log:
Reverting r 341390 because it is causing test failures on GreenDragon.
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/52810/
Modified:
kadircet added inline comments.
Comment at: clangd/index/Index.h:171
+ /// See also isIndexedForCodeCompletion().
+ IsIndexedForCodeCompletion = 1 << 0,
+ /// Indicates if the symbol is deprecated.
nit: rename to IndexedForCodeCompletion, since it is more of a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D51697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Agree with Kadir's comments.
I'd just suggest reducing boilerplate a bit by taking some shortcuts.
Comment at: clangd/index/Index.h:167
+enum class SymbolFlag : uint8
craig.topper added a comment.
Do you have commit access, or do you need someone to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D51510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
mgorny added a comment.
I don't have a strong opinion here.
Repository:
rC Clang
https://reviews.llvm.org/D51714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: labath
Date: Thu Sep 6 10:01:45 2018
New Revision: 341564
URL: http://llvm.org/viewvc/llvm-project?rev=341564&view=rev
Log:
Re-commit "Enable DWARF accelerator tables by default when tuning for lldb
(-glldb => -gpubnames)""
This recommits r341472, which was reverted due to test failures
jfb updated this revision to Diff 164235.
jfb marked 4 inline comments as done.
jfb added a comment.
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D51084
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/atomic-implicit-seq_cst.c
jfb added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:10974
+ if (E->IgnoreParenImpCasts()->getType()->isAtomicType())
+return;
CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC);
rjmccall wrote:
> Can you explain this o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341566: [Sema] Clean up some __builtin_*_chk diagnostics
(authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51697?vs=164087&i
Author: epilk
Date: Thu Sep 6 10:19:33 2018
New Revision: 341566
URL: http://llvm.org/viewvc/llvm-project?rev=341566&view=rev
Log:
[Sema] Clean up some __builtin_*_chk diagnostics
Namely, print the likely macro name when it's used, and include the actual
computed sizes in the diagnostic message,
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Thank you for this! I have some cursory review comments, and possibly more
later.
Comment at: include/clang/Basic/AttrDocs.td:1600
+ let Content = [{
+Clang supports the GNU style ``__attribute__((target_c
Author: abataev
Date: Thu Sep 6 10:56:28 2018
New Revision: 341570
URL: http://llvm.org/viewvc/llvm-project?rev=341570&view=rev
Log:
[OPENMP] Fix PR38823: Do not emit vtable if it is not used in target
context.
If the explicit template instantiation definition defined outside of the
target conte
tks2103 created this revision.
tks2103 added reviewers: modocache, GorNishanov.
Herald added a subscriber: cfe-commits.
tks2103 edited the summary of this revision.
Addressing https://bugs.llvm.org/show_bug.cgi?id=37265.
Implements [class.copy]/33 of coroutines TS
When the criteria for elision o
erichkeane updated this revision to Diff 164251.
erichkeane marked 9 inline comments as done.
erichkeane added a comment.
fix aaron's comments.
https://reviews.llvm.org/D51650
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic
Author: rnk
Date: Thu Sep 6 11:25:39 2018
New Revision: 341572
URL: http://llvm.org/viewvc/llvm-project?rev=341572&view=rev
Log:
Re-land r334417 "[MS] Use mangled names and comdats for string merging with
ASan"
The issue with -fprofile-generate was fixed and the dependent CL
relanded in r340232
1 - 100 of 171 matches
Mail list logo
