ilya-biryukov added inline comments.

================
Comment at: test/Index/complete-block-property-assignment.m:71
 
+// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck 
-check-prefix=CHECK-NO1 %s
+// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35)
----------------
ilya-biryukov wrote:
> Any idea why behavior changed in that case?
Looked at it more thoroughly now...
So we're now showing both the signature help and the completion, right?
If that the case, LG, but can we include the rest of completion items from 
CHECK-N0? 

Maybe also add a comment that the last item is from overload set completion, 
rather than the ordinary code completion? (To avoid confusion and make it clear 
why we need an extra check there)


Repository:
  rC Clang

https://reviews.llvm.org/D51038



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to