kbobyrev marked an inline comment as done. kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/FileDistance.h:89 public: + // Memorizes paths from \p Sources and builds efficient structure for URI + // distance computations. \p Sources must contain absolute paths, not URIs. ---------------- sammccall wrote: > The constructor doesn't do any computation, thus there's nothing to memoize. > > I'd suggest dropping the second sentence here, that's the only noteworthy > thing specific to this constructor. Sorry, did you mean dropping the *first sentence* here? The second one seems to be the one you describe. https://reviews.llvm.org/D51691 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
