This revision was automatically updated to reflect the committed changes.
Closed by commit rC338108: [AST] Sink 'part of explicit cast' down
into ImplicitCastExpr (authored by lebedevri, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49838
Files:
include/clang/AST/Expr.h
i
Author: lebedevri
Date: Fri Jul 27 00:27:14 2018
New Revision: 338108
URL: http://llvm.org/viewvc/llvm-project?rev=338108&view=rev
Log:
[AST] Sink 'part of explicit cast' down into ImplicitCastExpr
Summary:
As discussed in IRC with @rsmith, it is slightly not good to keep that in the
`CastExpr`
On Thu, Jul 26, 2018 at 12:44 PM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> > Usually we use match(anyOf(node), hasDescendant(node)). Or did I
> misunderstand what you want?
>
> My understanding is that, the free function template `match` uses
>
rjmccall added a comment.
Okay, thank you, that's better, but I should've been clearer. What I was
really asking for was this: in *all* the code you're adding in this patch,
where you've currently written `IsChecked` or `isChecked` or
`NewPointerIsChecked`, please instead write `IsSanitizerChe
devnexen created this revision.
devnexen added a reviewer: eugenis.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- Adding new option detect_write_exec=1 available.
Repository:
rC Clang
https://reviews.llvm.org/D49906
Files:
docs/AddressS
martong added a comment.
> MatchFinder::match allows you to match a node. Wrapping your matcher code
> with:
> auto m = ;
> ast_matchers::match(anyOf(m, hashDescendant(m)), node, context);
Okay, I understand and accept that.
However, I consider that a different level of abstraction.
`ast_matc
On Fri, Jul 27, 2018 at 10:39 AM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> > MatchFinder::match allows you to match a node. Wrapping your matcher
> code with:
> > auto m = ;
> > ast_matchers::match(anyOf(m, hashDescendant(m)), node, context);
mprobst added inline comments.
Comment at: unittests/Format/FormatTestComments.cpp:3109
+TEST_F(FormatTestComments, IndentsLongJavadocAnnotatedLines) {
+ FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java);
+ Style.ColumnLimit = 60;
mprobst wrote:
> add a
Author: omtcyfz
Date: Fri Jul 27 02:54:27 2018
New Revision: 338116
URL: http://llvm.org/viewvc/llvm-project?rev=338116&view=rev
Log:
[clangd] Return Dex Iterators
The original Dex Iterators patch (https://reviews.llvm.org/rL338017)
caused problems for Clang 3.6 and Clang 3.7 due to the compiler
martong added a comment.
> Finder.match also has an overload that takes the node. Can you wrap "Pattern"
> above in the anyOf(hasDescendant(...), ...) and match on the node instead of
> the full AST?
Ok, I changed and wrapped the pattern:
template
NodeType *match(const Decl *D, const Matc
chill updated this revision to Diff 157662.
chill added a comment.
Fixed to properly examine the canonical type when getting it's unadjusted
alignment.
https://reviews.llvm.org/D46013
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecordLayout.h
lib/AST/ASTContext.cpp
lib/AST/
chill marked an inline comment as done.
chill added a comment.
Thanks for pointing this!
https://reviews.llvm.org/D46013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri updated this revision to Diff 157665.
lebedev.ri marked 9 inline comments as done and 2 inline comments as done.
lebedev.ri edited the summary of this revision.
lebedev.ri added a comment.
Hopefully address @rsmith review notes:
- s/cast/conversion/ where appropriate
- Some wording in
JonasToth added inline comments.
Comment at: ClangTidy.cpp:612
+
+ FileManager *Files = new FileManager(FileSystemOptions());
+ vfs::FileSystem &FileSystem = *Files->getVirtualFileSystem();
Eugene.Zelenko wrote:
> You could use auto here, because type is in new
TheAhmad updated this revision to Diff 157667.
TheAhmad marked an inline comment as done.
TheAhmad added a comment.
Added auto at line 612.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
Files:
ClangTidy.cpp
Index: ClangTidy.cpp
===
mboehme created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49910
Files:
clang-tidy/bugprone/UseAfterMoveCheck.cpp
docs/clang-tidy/checks/bugprone-use-after-move.rst
test/clang-tidy/bugprone-use-after-move.cpp
Inde
mboehme updated this revision to Diff 157669.
mboehme added a comment.
[clang-tidy] Recognize [[clang::reinitializes]] attribute in
bugprone-use-after-move.
This allows member functions to be marked as reinitializing the object. After a
moved-from object has been reinitialized, the check will n
mboehme created this revision.
Herald added a subscriber: cfe-commits.
This is for use by clang-tidy's bugprone-use-after-move check -- see
corresponding clang-tidy patch at https://reviews.llvm.org/D49910.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Att
ilya-biryukov added a comment.
In https://reviews.llvm.org/D49758#1177747, @arphaman wrote:
> In https://reviews.llvm.org/D49758#1174629, @ilya-biryukov wrote:
>
> > The mode of operation where compile commands come from the client seems
> > useful, but I wonder if there's any value in mixing it
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX338122: [libc++] Introduce _LIBCPP_HIDE_FROM_ABI to
replace _LIBCPP_INLINE_VISIBILITY (authored by ldionne, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://rev
Author: ldionne
Date: Fri Jul 27 05:46:03 2018
New Revision: 338122
URL: http://llvm.org/viewvc/llvm-project?rev=338122&view=rev
Log:
[libc++] Introduce _LIBCPP_HIDE_FROM_ABI to replace _LIBCPP_INLINE_VISIBILITY
Summary:
This commit introduces a new macro, _LIBCPP_HIDE_FROM_ABI, whose goal is to
ldionne added a comment.
Note: I resolved Eric's comments before pushing.
Repository:
rCXX libc++
https://reviews.llvm.org/D49240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
TheAhmad updated this revision to Diff 157676.
TheAhmad marked 4 inline comments as done.
TheAhmad added a comment.
Used make_pair instead of constructor call.
Used unique_ptr.
Used named cast.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
Files:
ClangTidy.cpp
Index:
sepavloff updated this revision to Diff 157677.
sepavloff added a comment.
Updated patch
Use `SanitizerCheck` instead of `Check` in method and enum names.
No functional changes.
Repository:
rC Clang
https://reviews.llvm.org/D49589
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExprCXX.cpp
lebedev.ri added a comment.
I'm not sure what this differential *actually* does.
That being said
https://clang.llvm.org/docs/JSONCompilationDatabase.html#format
> directory: The working directory of the compilation. All paths specified in
> the command or file fields must be either absolute or
lebedev.ri added a comment.
Also, please upload the patches with full context (`-U9`), and the patch is
misformed, the `ClangTidy.cpp` isn't in the root directory.
Also, tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
_
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D49725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Jul 27, 2018 at 12:43 PM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> > Finder.match also has an overload that takes the node. Can you wrap
> "Pattern" above in the anyOf(hasDescendant(...), ...) and match on the node
> instead of the full
ilya-biryukov added inline comments.
Comment at: clangd/Protocol.h:429
+ // The changes that happened to the compilation database.
+ llvm::Optional>>
+ compilationDatabaseChanges;
arphaman wrote:
> ilya-biryukov wrote:
> > - Maybe add a comment that the ke
Anastasia added a comment.
In https://reviews.llvm.org/D49723#1174837, @asavonic wrote:
> In https://reviews.llvm.org/D49723#1173352, @Anastasia wrote:
>
> > Btw, has this restriction been removed from CL 2.0?
>
>
> No, it applies for CL2.0 as well.
It seems however the restriction on pointer t
ldionne created this revision.
ldionne added reviewers: EricWF, mclow.lists.
Herald added subscribers: cfe-commits, dexonsmith, christof.
ldionne added a comment.
This is the second step of the proposal aiming to remove uses of
`__always_inline__` in the visibility macros. This proposal is docume
ldionne added a comment.
This is the second step of the proposal aiming to remove uses of
`__always_inline__` in the visibility macros. This proposal is documented on
the list here: http://lists.llvm.org/pipermail/cfe-dev/2018-July/058633.html
Repository:
rCXX libc++
https://reviews.llvm.or
ilya-biryukov updated this revision to Diff 157680.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Move the test into an existing file
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49862
Files:
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
lebedev.ri added a comment.
(Duplicates https://reviews.llvm.org/D49158)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
krasimir updated this revision to Diff 157681.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D49797
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationInd
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:526
+ 0, Content[LineIndex].find_first_of(Blanks));
+ if (FirstWord == "@param")
+return Style.ContinuationIndentWidth;
mprobst wrote:
>
elsteveogrande updated this revision to Diff 157682.
elsteveogrande added a comment.
Herald added a subscriber: chrib.
Rebase very old diff
Repository:
rC Clang
https://reviews.llvm.org/D38320
Files:
lib/Serialization/ASTReaderDecl.cpp
lib/Serialization/ASTWriterDecl.cpp
test/PCH/cxx-t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338124: [clang-tidy] Fix a crash in
fuchsia-multiple-inheritance (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49862
Fi
Author: ibiryukov
Date: Fri Jul 27 07:05:39 2018
New Revision: 338124
URL: http://llvm.org/viewvc/llvm-project?rev=338124&view=rev
Log:
[clang-tidy] Fix a crash in fuchsia-multiple-inheritance
Summary: See the test case for a repro.
Reviewers: juliehockett, ioeric, hokein, aaron.ballman
Reviewe
martong added a comment.
> If you know the node is a decl, wrapping it in decl() should be enough.
> Does this work?
> auto WrappedMatcher = decl(anyOf(...));
Unfortunately this gives again the private ctor error (the same error when I
called explicitly the overload with the `DeclarationMatche
asavonic added a comment.
In https://reviews.llvm.org/D49723#1178127, @Anastasia wrote:
> In https://reviews.llvm.org/D49723#1174837, @asavonic wrote:
>
> > In https://reviews.llvm.org/D49723#1173352, @Anastasia wrote:
> >
> > > Btw, has this restriction been removed from CL 2.0?
> >
> >
> > No,
asavonic updated this revision to Diff 157685.
asavonic marked an inline comment as done.
asavonic added a comment.
Fix assert.
Repository:
rC Clang
https://reviews.llvm.org/D49723
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/invalid-kernel-parameters.cl
Index: test/SemaOpenCL/invalid-k
calixte created this revision.
calixte added reviewers: marco-c, davidxl.
Herald added a subscriber: cfe-commits.
Some lines have a hit counter where they should not have one.
Cleanup stuff is located to the last line of the body which is most of the time
a '}'.
And Exception stuff is added at th
asavonic updated this revision to Diff 157688.
asavonic added a comment.
Rollback accidentally squashed commit.
Repository:
rC Clang
https://reviews.llvm.org/D49723
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/invalid-kernel-parameters.cl
Index: test/SemaOpenCL/invalid-kernel-parameter
JonasToth added a comment.
In https://reviews.llvm.org/D49890#1178103, @lebedev.ri wrote:
> I'm not sure what this differential *actually* does.
This is a follow up from this discussion on the mailing list:
http://clang-developers.42468.n3.nabble.com/Fwd-Running-Clang-Tidy-on-a-Large-Project-t
JonasToth added inline comments.
Comment at: ClangTidy.cpp:612
+
+ std::unique_ptr Files =
+ make_unique(FileSystemOptions());
in this case you can use `auto` again, because the type of the `unique_ptr` is
clear from the `make_unique` call.
Repository:
greened updated this revision to Diff 157689.
greened added a comment.
The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This gets
the test passing when the clang default linker is something other than lld.
https://reviews.llvm.org/D49899
Files:
test/Driver/fuchsia.c
tes
mboehme created this revision.
mboehme added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, xazax.hun.
Fixes https://bugs.llvm.org/show_bug.cgi?id=36516.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49918
Files:
clang-tidy/utils/ExprSequence.cpp
test/cl
lebedev.ri added a comment.
In https://reviews.llvm.org/D49890#1178211, @JonasToth wrote:
> In https://reviews.llvm.org/D49890#1178103, @lebedev.ri wrote:
>
> > I'm not sure what this differential *actually* does.
>
>
> This is a follow up from this discussion on the mailing list:
> http://clang
TheAhmad added a comment.
The most comprehensive fix is to support all possible valid compilation
databases. The current fix is the fastest one.
> Can you just make clang-tidy respect the directory value?
This is exactly what I did. I prepended the directory value to the file value
and stored
mprobst accepted this revision.
mprobst added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/Format.cpp:814
+// by qualified identifiers.
+GoogleStyle.CommentPragmas = "(taze:|^/[
\t]*<|@see|@exports|@module|@mods)";
GoogleS
TheAhmad added a comment.
> Also, tests.
What should I provide for tests?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
JonasToth added inline comments.
Comment at: ClangTidy.cpp:614
+ vfs::FileSystem &FileSystem = *Files->getVirtualFileSystem();
+ auto InitialWorkingDir = FileSystem.getCurrentWorkingDirectory();
+ if (!InitialWorkingDir)
TheAhmad wrote:
> Eugene.Zelenko wrote:
ldionne updated this revision to Diff 157696.
ldionne added a comment.
Document the macro in the official documentation instead of the header, per
Eric's comment on a previous patch of mine.
Repository:
rCXX libc++
https://reviews.llvm.org/D49914
Files:
libcxx/docs/DesignDocs/VisibilityMac
JonasToth added a comment.
Actually, maybe this patch is relevant for clang-tooling itself (where the
compilation-database stuff actually is). @alexfh what is your opinion on that?
`llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp` This is the
path for the unittests there.
`llvm/t
elsteveogrande added a comment.
cc @rsmith as this has to do with modules.
Verified that (1) existing tests pass on trunk; (2) the new test included here
fails when applied to trunk; (3) all tests (including new test) pass when this
patch is applied.
Repository:
rC Clang
https://reviews.ll
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3426
+ let Content = [{
+The ``noderef`` attribute causes clang to throw a warning whenever a pointer
marked with
+this attribute is dereferenced. This is ideally used with pointers that point
to
Anastasia added inline comments.
Comment at: test/SemaOpenCL/atomic-ops.cl:61
__opencl_atomic_load(d, memory_order_seq_cst, memory_scope_work_group);
- __opencl_atomic_load(ci, memory_order_seq_cst, memory_scope_work_group); //
expected-error {{address argument to atomic ope
krasimir added inline comments.
Comment at: lib/Format/Format.cpp:814
+// by qualified identifiers.
+GoogleStyle.CommentPragmas = "(taze:|^/[
\t]*<|@see|@exports|@module|@mods)";
GoogleStyle.MaxEmptyLinesToKeep = 3;
mprobst wrote:
> `@exports` isn't
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D49723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
Oops, forgot to submit the inline comments.
(It is inconvenient that they aren't submitted with the rest.)
Comment at: docs/ReleaseNotes.rst:292
+ store = store + 768; // before addition, 'store' was promoted to int.
+(void)consume((
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM from OpenCL side! Thanks!
Comment at: test/SemaOpenCL/numbered-address-space.cl:9
+void
test_numeric_as_to_generic_explicit_cast(__attribute__((address_space(3)))
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D49223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
yaxunl requested changes to this revision.
yaxunl added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/AMDGPU.h:398
+
+ LangAS getCUDABuiltinAddressSpace(unsigned AS) const override {
+return LangAS::Default;
I
dexonsmith added a comment.
This looks correct to me, but I wouldn't mind having someone else take a look
too.
Comment at: libcxx/include/__config:798
-// Just so we can migrate to _LIBCPP_HIDE_FROM_ABI gradually.
-#define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI
-
-#
george.karpenkov added a comment.
@aaron.ballman @alexfh Further concerns?
https://reviews.llvm.org/D49701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:1157
+ /// language address space.
+ virtual LangAS getCUDABuiltinAddressSpace(unsigned AS) const {
+return getLangASFromTargetAS(AS);
I think this function is not needed.
Although
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:44
#include "clang/AST/Expr.h"
+#include "clang/AST/ExprObjC.h"
#include "clang/AST/Ex
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/builtins-amdgcn.cl:3
+// RUN: %clang_cc1 -cl-std=CL2.0 -triple amdgcn-unknown-unknown -S -emit-llvm
-o - %s | FileCheck -enable-var-scope %s
+// RUN: %clang_cc1 -cl-std=CL2.0 -triple amdgcn-unknown-unknown-opencl -S
-
Author: rsmith
Date: Fri Jul 27 10:13:18 2018
New Revision: 338135
URL: http://llvm.org/viewvc/llvm-project?rev=338135&view=rev
Log:
Add missing temporary materialization conversion on left-hand side of .
in some member function calls.
Specifically, when calling a conversion function, we would fa
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, that'll do.
Repository:
rC Clang
https://reviews.llvm.org/D49589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
LGTM
Jon
On Thu, Jul 26, 2018 at 10:12 PM David Greene via Phabricator <
revi...@reviews.llvm.org> wrote:
> greened created this revision.
> greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu.
> Herald added a subscriber: cfe-commits.
>
> This test fails if clang is configure wit
arphaman added a comment.
In https://reviews.llvm.org/D49758#1178056, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D49758#1177747, @arphaman wrote:
>
> > In https://reviews.llvm.org/D49758#1174629, @ilya-biryukov wrote:
> >
> > > The mode of operation where compile commands come from the c
yaxunl added a comment.
In https://reviews.llvm.org/D47154#1108813, @tra wrote:
> CUDA does not expose explicit AS on clang size. All pointers are treated as
> generic and we infer specific address space only in LLVM.
> `__nvvm_atom_*_[sg]_*` builtins should probably be removed as they are
> i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338137: [ASTMatchers] Introduce a matcher for
`ObjCIvarExpr`, support getting it's… (authored by george.karpenkov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
http
Author: george.karpenkov
Date: Fri Jul 27 10:26:11 2018
New Revision: 338137
URL: http://llvm.org/viewvc/llvm-project?rev=338137&view=rev
Log:
[ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's
declaration.
ObjCIvarExpr is *not* a subclass of MemberExpr, and a separate ma
Author: epilk
Date: Fri Jul 27 10:27:40 2018
New Revision: 338138
URL: http://llvm.org/viewvc/llvm-project?rev=338138&view=rev
Log:
[demangler] Support for reference collapsing
llvm.org/PR38323
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/test_demangle.pass.cpp
Mo
sepavloff added a comment.
@rjmccall Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D49589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Fri Jul 27 10:37:32 2018
New Revision: 338139
URL: http://llvm.org/viewvc/llvm-project?rev=338139&view=rev
Log:
[OPENMP] Static variables on device must be externally visible.
Do not mark static variable as internal on the device as they must be
visible from the host to be m
Author: george.karpenkov
Date: Fri Jul 27 10:40:59 2018
New Revision: 338140
URL: http://llvm.org/viewvc/llvm-project?rev=338140&view=rev
Log:
[ASTMatchers] Introduce a matcher for `ObjCIvarExpr`, support getting it's
declaration
ObjCIvarExpr is *not* a subclass of MemberExpr, and a separate mat
malaperle created this revision.
Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay,
ioeric, ilya-biryukov.
We do not have a global index of references but we can find the references
of local symbols within the AST in the mean time. Also, since we will not
record local symb
teemperor planned changes to this revision.
teemperor marked an inline comment as done.
teemperor added a comment.
(Just marking this as "Plan changes" because otherwise it's just stuck in my
"Waiting on review" queue).
https://reviews.llvm.org/D43871
rsmith created this revision.
rsmith added a reviewer: aaron.ballman.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
This patch adds support for a new attribute, [[clang::lifetimebound]], that
indicates that the lifetime of a function result is related to one of t
Author: rsmith
Date: Fri Jul 27 11:06:54 2018
New Revision: 338141
URL: http://llvm.org/viewvc/llvm-project?rev=338141&view=rev
Log:
Fix typos in comment.
Modified:
cfe/trunk/include/clang/AST/TypeLoc.h
Modified: cfe/trunk/include/clang/AST/TypeLoc.h
URL:
http://llvm.org/viewvc/llvm-project
juliehockett added a comment.
any further thoughts on this?
https://reviews.llvm.org/D48341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: include/clang/AST/TypeLoc.h:96-97
/// Convert to the specified TypeLoc type, returning a null TypeLoc if
- /// this TypeLock is not of the desired type. It will consider type
- /// adjustments from a type that wad written as a T to a
Hi Alexey,
from what I can see this change can't handle the case where there are
static variables with the same name in multiple TUs.
(The same problem exists for static CUDA kernels with -fcuda-rdc. I
found that nvcc mangles the function names in this case, but didn't have
time yet to prepare
bviyer updated this revision to Diff 157721.
bviyer added a comment.
I have fixed all the changes requested by Erik along with shortening the test
case.
Repository:
rC Clang
https://reviews.llvm.org/D49766
Files:
include/clang/AST/TemplateBase.h
test/SemaObjCXX/class-templ-error-null-in
rsmith added a comment.
Thanks, this is definitely a step in the right direction.
Comment at: include/clang/AST/Expr.h:3257-3261
+ // Get the FENV_ACCESS status of this operator. Only meaningful for
+ // operations on floating point types.
+ bool isFENVAccessOn() const {
+
Author: george.karpenkov
Date: Fri Jul 27 11:26:40 2018
New Revision: 338149
URL: http://llvm.org/viewvc/llvm-project?rev=338149&view=rev
Log:
[analyzer] Extend NoStoreFuncVisitor to insert a note on IVars
The note is added in the following situation:
- We are throwing a nullability-related war
ldionne added inline comments.
Comment at: libcxx/include/__config:798
-// Just so we can migrate to _LIBCPP_HIDE_FROM_ABI gradually.
-#define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI
-
-#ifndef _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
-# if !defined(_LIBCPP_DISABLE_VI
On Wed, Jul 25, 2018 at 4:39 AM Nico Weber wrote:
> I thought about adding -fblocks when that thread happened, but since
> there's no runtime for them that just works exposing it doesn't seem very
> helpful. Maybe we should instead change the warning text to not suggest
> -fblocks when building o
erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! Do you have your commit rights yet?
Comment at: include/clang/AST/TemplateBase.h:469
+
+// Allow more additional argument kinds for the co
ruiu added a comment.
> The Fuchsia driver relies on lld so invoke clang with -fuse-ld=lld. This gets
> the test passing when the clang default linker is something other than lld.
Does it work if lld is not installed at all? I believe if the driver cannot
find a specified linker, it reports an
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaTemplate.cpp:1899-1907
// Canonicalize the type. This (for instance) replaces references to
// typedef members of the current ins
bviyer updated this revision to Diff 157730.
bviyer added a comment.
Fixed the comment as you suggested.
I do not have check in rights yet. Can you please check it in for me?
Repository:
rC Clang
https://reviews.llvm.org/D49766
Files:
include/clang/AST/TemplateBase.h
test/SemaObjCXX/cla
rsmith added a comment.
In https://reviews.llvm.org/D49511#1170693, @leonardchan wrote:
> Done. I opted for not using `ExpressionEvaluationContextRecord` because I
> don't think I was using it correctly. A few other tests in sema failed when I
> tried pushing and popping from the stack holding
malaperle updated this revision to Diff 157732.
malaperle added a comment.
Fix silly bug I introduced in last minute clean-up.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49920
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/
malaperle planned changes to this revision.
malaperle added a comment.
Needs tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rupprecht created this revision.
rupprecht added reviewers: ldionne, rsmith.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, christof.
[libc++] Exclude posix_l/strtonum fallback inclusion for newlib > 2.4
r338122 changed the linkage of some methods which revealed an existi
1 - 100 of 172 matches
Mail list logo