mprobst accepted this revision.
mprobst added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Format/Format.cpp:814
+    // by qualified identifiers.
+    GoogleStyle.CommentPragmas = "(taze:|^/[ 
\t]*<|@see|@exports|@module|@mods)";
     GoogleStyle.MaxEmptyLinesToKeep = 3;
----------------
`@exports` isn't really a thing in JS, it is really `@export`.

But more generally, where do you get stuff like `@module` from, and what is it 
supposed to do?

google3 has `@pintomodule`, `@mods` and `@modName`, but I don't think those 
need special treatment.

I think I'd drop everything except the `@see` here.


Repository:
  rC Clang

https://reviews.llvm.org/D49797



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to