dexonsmith added a comment.
This looks correct to me, but I wouldn't mind having someone else take a look
too.
================
Comment at: libcxx/include/__config:798
-// Just so we can migrate to _LIBCPP_HIDE_FROM_ABI gradually.
-#define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI
-
-#ifndef _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
-# if !defined(_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)
-# define _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
__attribute__((__visibility__("default"), __always_inline__))
+#ifdef _LIBCPP_BUILDING_LIBRARY
+# if _LIBCPP_ABI_VERSION > 1
----------------
It looks like if you switch this to `#if !defined(...)` you can use `#elif`
instead of a nested `#if`. I think that would make the logic a bit more clear
for me, but if you disagree feel free to leave it as is.
Repository:
rCXX libc++
https://reviews.llvm.org/D49914
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
