krasimir added inline comments.
================
Comment at: lib/Format/Format.cpp:814
+ // by qualified identifiers.
+ GoogleStyle.CommentPragmas = "(taze:|^/[
\t]*<|@see|@exports|@module|@mods)";
GoogleStyle.MaxEmptyLinesToKeep = 3;
----------------
mprobst wrote:
> `@exports` isn't really a thing in JS, it is really `@export`.
>
> But more generally, where do you get stuff like `@module` from, and what is
> it supposed to do?
>
> google3 has `@pintomodule`, `@mods` and `@modName`, but I don't think those
> need special treatment.
>
> I think I'd drop everything except the `@see` here.
There were existing tests having these.
I can find a reference to `@exports` and `@module` here:
http://usejsdoc.org/tags-exports.html.
I think that in general if the annotation is supposed to only have the form
`@tag some-long-path-separated-machine-readable-identifier`, that should be
left on a single line.
For `@mods`, I vaguely remember adding that test case while fixing a bug that
it shouldn't be broken.
Still, happy to remove these and we'll wait to see if anyone complains.
Repository:
rC Clang
https://reviews.llvm.org/D49797
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
