hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
ahatanak updated this revision to Diff 128895.
ahatanak added a comment.
Address review comments.
Also, emit the declaration of the destructor of a trivial-abi override class in
Sema::ActOnParamDeclarator and mark it as referenced. This is necessary because
a trivial-abi type that is passed by
ahatanak marked 4 inline comments as done.
ahatanak added a comment.
In https://reviews.llvm.org/D41039#969171, @rjmccall wrote:
> I'll trust Richard on the tricky Sema/AST bits. The functionality of the
> patch looks basically acceptable to me, although I'm still not thrilled about
> the idea
JonasToth created this revision.
JonasToth added reviewers: aaron.ballman, alexfh, hokein.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai,
klimek.
The usage of `goto` is discourage in C++ since forever. This check implements
a warning for every `goto`. Even though the
MontyKutyi added a comment.
In https://reviews.llvm.org/D34030#967749, @bruno wrote:
> The change seems good to me in general. I wonder if this will hit any broken
> assumption in the code. Did you run other tests beside unittests?
I run the tests available by building the `clang-test` only.
JonasToth updated this revision to Diff 128898.
JonasToth added a comment.
- fix typos and return type of main in test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
Files:
clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp
clang-tidy/cppcoreguidelines/AvoidGotoCheck.h
JonasToth updated this revision to Diff 128899.
JonasToth added a comment.
- [Misc] emphasize goto in warning message
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
Files:
clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp
clang-tidy/cppcoreguidelines/AvoidGotoCheck.h
xazax.hun added a comment.
A high level comment: while it is very easy to get all the gotos using grep, it
is not so easy to get all the labels. So for this check to be complete, I think
it would be useful to also find labels (possibly having a configuration option
for that).
Repository:
rC
JonasToth updated this revision to Diff 128902.
JonasToth added a comment.
- [Misc] reformat
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
Files:
clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp
clang-tidy/cppcoreguidelines/AvoidGotoCheck.h
clang-tidy/cppcoreguideli
SjoerdMeijer added a comment.
Thanks for working on this!
Some comments inline.
Comment at: clang/include/clang/Basic/arm_fp16.td:19
+// The operations are subclasses of Operation providing a list of DAGs, the
+// last of which is the return value.
+//
nit: t
miyuki added a comment.
ping
https://reviews.llvm.org/D41179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
In https://reviews.llvm.org/D41815#969626, @xazax.hun wrote:
> A high level comment: while it is very easy to get all the gotos using grep,
> it is not so easy to get all the labels. So for this check to be complete, I
> think it would be useful to also find labels (p
ilya-biryukov added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:89
+// violations.
+if (ND->isInAnonymousNamespace())
return true;
Why don't we include symbols from anonymous namespaces too?
They are very similar to static symbols
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, dcoughlin, xazax.hun.
Herald added subscribers: a.sidorin, szepet, baloghadamsoftware, whisperity.
Left shifting a signed positive value is undefined if the result is not
representable in the unsigned version of the return type.
The
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:89
+// violations.
+if (ND->isInAnonymousNamespace())
return true;
ilya-biryukov wrote:
> Why don't we include symbols from anonymous namespaces too?
> They are very similar
aaron.ballman added a comment.
In https://reviews.llvm.org/D41815#969673, @JonasToth wrote:
> In https://reviews.llvm.org/D41815#969626, @xazax.hun wrote:
>
> > A high level comment: while it is very easy to get all the gotos using
> > grep, it is not so easy to get all the labels. So for this c
This revision was automatically updated to reflect the committed changes.
seaneveson marked an inline comment as done.
Closed by commit rL321992: [Driver] Add flag enabling the function stack size
section that was added in… (authored by seaneveson, committed by ).
Changed prior to commit:
https
Author: seaneveson
Date: Mon Jan 8 05:42:26 2018
New Revision: 321992
URL: http://llvm.org/viewvc/llvm-project?rev=321992&view=rev
Log:
[Driver] Add flag enabling the function stack size section that was added in
r319430
Adds the -fstack-size-section flag to enable the .stack_sizes section. The
JonasToth added a comment.
> Rather than add a warning for the labels, I would just add a note for the
> label when diagnosing the goto (since the goto has a single target).
That might lead to existing labels without any gotos for them, does it? Maybe
the check could also diagnose labels withou
aaron.ballman added inline comments.
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:163
+
+void noWarning() {
+ auto AsyncRetval1 = std::async(increment, 42);
khuttun wrote:
> aaron.ballman wrote:
> > Sorry, I just realized that we're missing a tes
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D35109#969109, @NoQ wrote:
> I guess it'd be an `-analyzer-config` flag. You can add it to the
> `AnalyzerOptions` object, which has access to these flags and can be accessed
> from `AnalysisManager`.
OK, I can do that. BUt how s
aaron.ballman added a comment.
In https://reviews.llvm.org/D41815#969708, @JonasToth wrote:
> > Rather than add a warning for the labels, I would just add a note for the
> > label when diagnosing the goto (since the goto has a single target).
>
> That might lead to existing labels without any go
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:22
+ if (getLangOpts().CPlusPlus)
+Finder->addMatcher(gotoStmt().bind("goto"), this);
+}
aaron.ballman wrote:
> aaron.ballman wrote:
> > Are you planning to add the
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:22
+ if (getLangOpts().CPlusPlus)
+Finder->addMatcher(gotoStmt().bind("goto"), this);
+}
JonasToth wrote:
> aaron.ballman wrote:
> > aaron.ballman wrote:
> > > A
modocache created this revision.
modocache added reviewers: rsmith, GorNishanov, eric_niebler.
Herald added a subscriber: EricWF.
Use corutine function arguments to initialize a promise type, but only
if the promise type defines a constructor that takes those arguments.
Otherwise, fall back to the
krasimir updated this revision to Diff 128921.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D41487
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
kosarev added a comment.
Sure, but since it is not a trivial change we could first replace 'tbaa.struct'
with 'tbaa' and then decide how to attach multiple TBAA tags to an instruction.
I didn't think enough about it, but one way to do that is to have different
kinds of TBAA tags for read and wr
Author: seaneveson
Date: Mon Jan 8 06:43:28 2018
New Revision: 321995
URL: http://llvm.org/viewvc/llvm-project?rev=321995&view=rev
Log:
Fix test added in r321992 failing on some buildbots.
Modified:
cfe/trunk/test/CodeGen/stack-size-section.c
Modified: cfe/trunk/test/CodeGen/stack-size-sect
baloghadamsoftware added a comment.
Strange, but modifying the tests from `m n` to `m - n 0`
does not help. The statement `if (m - n 0)` does not store a range
for `m - n` in the constraint manager. With the other patch which automatically
changes `m n` to `m - n 0` the range is stored
a
Author: sammccall
Date: Mon Jan 8 07:05:01 2018
New Revision: 321997
URL: http://llvm.org/viewvc/llvm-project?rev=321997&view=rev
Log:
Avoid assumption that lit tests are writable. NFC
Modified:
cfe/trunk/test/ARCMT/releases-driver.m
cfe/trunk/test/ARCMT/releases-driver.m.result
cfe/
Author: kosarev
Date: Mon Jan 8 07:36:06 2018
New Revision: 321999
URL: http://llvm.org/viewvc/llvm-project?rev=321999&view=rev
Log:
[CodeGen] Fix TBAA info for accesses to members of base classes
Resolves:
Bug 35724 - regression (r315984): fatal error: error in backend:
Broken function found (D
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321999: [CodeGen] Fix TBAA info for accesses to members of
base classes (authored by kosarev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41547
Files:
lib/CodeGen/CGExpr.cpp
tes
bkramer added inline comments.
Comment at: include/clang/Format/Format.h:1700
+typedef std::map>
+MapType;
Why unique_ptr?
Comment at: include/clang/Format/Format.h:1706
+// FormatStyleSet.
+void Add(FormatStyle Style);
+
Author: seaneveson
Date: Mon Jan 8 07:46:18 2018
New Revision: 322000
URL: http://llvm.org/viewvc/llvm-project?rev=322000&view=rev
Log:
Fix test added in r321992 failing on some buildbots (again), test requires x86.
Modified:
cfe/trunk/test/CodeGen/stack-size-section.c
Modified: cfe/trunk/t
Author: sammccall
Date: Mon Jan 8 07:49:40 2018
New Revision: 322001
URL: http://llvm.org/viewvc/llvm-project?rev=322001&view=rev
Log:
Avoid assumption that lit tests are writable. NFC
Modified:
clang-tools-extra/trunk/test/clang-apply-replacements/crlf.cpp
clang-tools-extra/trunk/test/c
(just a side note: perhaps this conversation would've been more suited to
cfe-dev? I sort of missed it because I only check commits once a week,
unless I'm specifically cc'd on something. All good though :))
On Wed, Jan 3, 2018 at 4:06 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322002: [clang-tidy] Fix DanglingHandleCheck for the correct
conversion operation… (authored by sbenza, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm
Author: sbenza
Date: Mon Jan 8 07:59:08 2018
New Revision: 322002
URL: http://llvm.org/viewvc/llvm-project?rev=322002&view=rev
Log:
[clang-tidy] Fix DanglingHandleCheck for the correct conversion operation
between basic_string and basic_string_view.
Summary:
Fix DanglingHandleCheck to handle th
krasimir updated this revision to Diff 128932.
krasimir marked 5 inline comments as done.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D41487
Files:
2
include/clang/Format/Format.h
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
krasimir updated this revision to Diff 128933.
krasimir added a comment.
- Remove accidentally added file
Repository:
rC Clang
https://reviews.llvm.org/D41487
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
> On Jan 8, 2018, at 10:57 AM, David Blaikie wrote:
> (just a side note: perhaps this conversation would've been more suited to
> cfe-dev? I sort of missed it because I only check commits once a week, unless
> I'm specifically cc'd on something. All good though :))
I suppose it's more design-an
I'm sure it's something obvious I don't understand here, but maybe someone
else doesn't either & could benefit from it:
What exactly does this change do? In what important way is "cp X Y"
different from "cat X > Y"?
On Mon, Jan 8, 2018 at 7:06 AM Sam McCall via cfe-commits <
cfe-commits@lists.llv
It helps to have the first line of the commit message be roughly
descriptive, since it forms the brief commit summary in version tools and
the subject line in commit email - just "NFC" is a bit unclear. Usually
these sort of commits are described as, say "Suppress -Asserts
unused-variable warning f
Rough guess: That seems like a lot of code changes for relatively little
test changes - are all parts of this change tested? (Might well be - just
lots of layers to plumb things through - but if there's lots of places that
get locations and only a few of those are tested, maybe this could use more
Great - are you tracking/planning to implement this for trivial_abi once
it's in? (was mentioned in the code review, but not sure if it's on your
plate/plan or not (no worries if it isn't, just keeping these things in
mind))
On Thu, Jan 4, 2018 at 5:14 PM Adrian Prantl via cfe-commits <
cfe-commit
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:811
+ bool hasTrivialABIOverride() const;
+
This should get a comment, even if it's just to refer to the CXXRecordDecl
method.
Comment at: lib/CodeGen/CGCall.cpp:3498
b
rjmccall added a comment.
Yes, I think that's fine.
I think unconditionally attaching the tag is probably wrong; you need suppress
it in the may_alias cases. I'll grant that the existing code doesn't honor
that, but that seems like a bug we should go ahead and fix. You'll need to
either prop
Author: amccarth
Date: Mon Jan 8 08:33:42 2018
New Revision: 322005
URL: http://llvm.org/viewvc/llvm-project?rev=322005&view=rev
Log:
Emit Function IDs table for Control Flow Guard
Adds option /guard:cf to clang-cl and -cfguard to cc1 to emit function IDs
of functions that have their address tak
ioeric created this revision.
ioeric added reviewers: hokein, ilya-biryukov.
Herald added subscribers: cfe-commits, klimek.
o We only collect symbols in namespace or translation unit scopes.
o Add an option to only collect symbols in included headers.
Repository:
rCTE Clang Tools Extra
https:
> On Jan 8, 2018, at 8:14 AM, David Blaikie wrote:
>
> Great - are you tracking/planning to implement this for trivial_abi once it's
> in? (was mentioned in the code review, but not sure if it's on your
> plate/plan or not (no worries if it isn't, just keeping these things in mind))
Yes, thi
Excellent :)
On Mon, Jan 8, 2018 at 8:39 AM Adrian Prantl wrote:
>
> On Jan 8, 2018, at 8:14 AM, David Blaikie wrote:
>
> Great - are you tracking/planning to implement this for trivial_abi once
> it's in? (was mentioned in the code review, but not sure if it's on your
> plate/plan or not (no w
khuttun added inline comments.
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:163
+
+void noWarning() {
+ auto AsyncRetval1 = std::async(increment, 42);
aaron.ballman wrote:
> khuttun wrote:
> > aaron.ballman wrote:
> > > Sorry, I just realized tha
Author: amccarth
Date: Mon Jan 8 09:12:01 2018
New Revision: 322008
URL: http://llvm.org/viewvc/llvm-project?rev=322008&view=rev
Log:
Revert "Emit Function IDs table for Control Flow Guard"
The new test fails on the Hexagon bot. Reverting while I investigate.
This reverts https://reviews.llvm.
aaron.ballman added inline comments.
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:163
+
+void noWarning() {
+ auto AsyncRetval1 = std::async(increment, 42);
khuttun wrote:
> aaron.ballman wrote:
> > khuttun wrote:
> > > aaron.ballman wrote:
> > >
Will add some more tests later today
-
Best regards,
Alexey Bataev
08.01.2018 11:13, David Blaikie пишет:
> Rough guess: That seems like a lot of code changes for relatively
> little test changes - are all parts of this change tested? (Might well
> be - just lots of layers to plumb thi
Hi David (and the list this time!),
If X is readonly, then after `cp X Y`, Y is also readonly. The `cat`
version doesn't propagate permissions.
The environment for lit tests isn't really spelled out, but relying on the
input files being +w doesn't seem obviously reasonable.
Google's internal runn
Author: marshall
Date: Mon Jan 8 09:43:46 2018
New Revision: 322011
URL: http://llvm.org/viewvc/llvm-project?rev=322011&view=rev
Log:
Document upcoming TS feature removal
Added:
libcxx/trunk/www/TS_deprecation.html
Added: libcxx/trunk/www/TS_deprecation.html
URL:
http://llvm.org/viewvc/llv
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry, I was hoping @akyrtzi would see this.
I don't know enough about the code to know whether DC==null is an indicator of
some other problem, but if this is crashing today then let's no
akyrtzi added a comment.
Could you add a test case for this change ? See examples in `test/Index/Core`.
Also for the test case code: `template class Actor =
actor>`, is the `actor` reference in this code reported ?
See the test examples on how to print out and test how the source symbols are
in
erichkeane marked 7 inline comments as done.
erichkeane added a comment.
patch incoming!
Comment at: include/clang/AST/ASTContext.h:2643-2648
+for (auto *CurDecl :
+ FD->getDeclContext()->getRedeclContext()->lookup(FD->getDeclName())) {
+ FunctionDecl *CurFD =
erichkeane updated this revision to Diff 128950.
erichkeane marked 2 inline comments as done.
erichkeane added a comment.
All of @rsmith 's comments on the last patch. 1 "open" item on the duplicate
discover in the resolver generation, but hopefully this otherwise acceptable.
https://reviews.l
kosarev added a comment.
OK, I'm reading your response so that this patch may significantly increase the
number of cases where we propagate TBAA tags from memory-transfer intrinsic
calls, which means potentially more cases where ignoring may_alias would lead
to problems. If so, then I tend to a
MaskRay added a comment.
@akyrtzi When I run `c-index-test core -print-source-symbols -- a.cc` on
template
struct actor;
template class Actor = actor>
struct terminal;
the issue disappears. It emerges only when `clang_indexTranslationUnit` is
called with interactions of other thing
MaskRay updated this revision to Diff 128953.
MaskRay added a comment.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D41575
Files:
tools/libclang/CXIndexDataConsumer.cpp
Index: tools/libclang/CXIndexDataConsumer.cpp
=
khuttun added inline comments.
Comment at: test/clang-tidy/bugprone-unused-return-value.cpp:163
+
+void noWarning() {
+ auto AsyncRetval1 = std::async(increment, 42);
aaron.ballman wrote:
> khuttun wrote:
> > aaron.ballman wrote:
> > > khuttun wrote:
> > > > aar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322017: [index] Return when DC is null in handleReference
(authored by MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41575
Files:
cf
Author: abataev
Date: Mon Jan 8 11:02:51 2018
New Revision: 322018
URL: http://llvm.org/viewvc/llvm-project?rev=322018&view=rev
Log:
[OPENMP] Current status of OpenMP support.
Summary: Some info about supported features of OpenMP 4.5-5.0.
Reviewers: hfinkel, rsmith
Subscribers: kkwli0, Hahnfel
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322018: [OPENMP] Current status of OpenMP support. (authored
by ABataev, committed by ).
Changed prior to commit:
https
Can we backport this page to release_60? I think the documented support
is also valid for 6.0 or did I miss recent commits that added support
for new directives / clauses?
Am 2018-01-08 20:02, schrieb Alexey Bataev via cfe-commits:
Author: abataev
Date: Mon Jan 8 11:02:51 2018
New Revision: 3
Author: marshall
Date: Mon Jan 8 11:18:00 2018
New Revision: 322019
URL: http://llvm.org/viewvc/llvm-project?rev=322019&view=rev
Log:
Add the C++17 extensions to std::search. Include the default searcher, but not
the Boyer-Moore or Boyer-Moore-Horspool searcher (yet). BUT put the BM and BMH
tes
rsmith accepted this revision.
rsmith added a comment.
Looks good to me with just a few more tweaks (assuming these comments don't
uncover any new issues). Thank you!
Comment at: lib/AST/ASTContext.cpp:9490
+ assert(FD->isMultiVersion() && "Only valid for multiversioned funct
ahatanak updated this revision to Diff 128960.
ahatanak marked 7 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D41039
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclCXX.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
hintonda created this revision.
hintonda added reviewers: beanz, compnerd, phosek, smeenai.
Herald added a subscriber: mgorny.
Add cache file to bootstrap 2-stage linux cross compile on
Darwin.
Repository:
rC Clang
https://reviews.llvm.org/D41829
Files:
cmake/caches/Linux.cmake
Index: cm
Author: bion
Date: Mon Jan 8 11:45:16 2018
New Revision: 322021
URL: http://llvm.org/viewvc/llvm-project?rev=322021&view=rev
Log:
Change add_ten to add_one to avoid triggering ubsan integer overflow.
Modified:
libcxx/trunk/test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exc
TyanNN created this revision.
TyanNN added a reviewer: EricWF.
Herald added a subscriber: cfe-commits.
Previously it thrown an error if the file didn't exist.
PR#35780
Repository:
rCXX libc++
https://reviews.llvm.org/D41830
Files:
src/experimental/filesystem/operations.cpp
test/libcxx/
efriedma added inline comments.
Comment at: test/Misc/ast-dump-stmt.c:66
+ // CHECK:ImplicitCastExpr
+ // CHECK: DeclRefExpr{{.*}}'T2' 'int'
+}
aaron.ballman wrote:
> efriedma wrote:
> > What does it mean for bitwise complement to "overflow"?
>
Author: abataev
Date: Mon Jan 8 12:09:47 2018
New Revision: 322022
URL: http://llvm.org/viewvc/llvm-project?rev=322022&view=rev
Log:
[OPENMP] Fix debug info for outlined functions in NVPTX + add more tests.
Fixed name of emitted outlined functions in NVPTX target + extra tests
for the debug inf
kromanova accepted this revision.
kromanova added a comment.
LGTM too.
https://reviews.llvm.org/D41507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apazos accepted this revision.
apazos added a comment.
This revision is now accepted and ready to land.
Please merge this patch, it looks in good shape. This patch is required for any
RISCV build.
https://reviews.llvm.org/D39963
___
cfe-commits mai
Author: waltl
Date: Mon Jan 8 12:36:08 2018
New Revision: 322023
URL: http://llvm.org/viewvc/llvm-project?rev=322023&view=rev
Log:
[Myriad] Remove invalidated -elf flag for MoviAsm
Summary:
The flag has been deprecated, and is becoming invalid in the latest
MDK.
Reviewers: jyknight
Subscribers
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322023: [Myriad] Remove invalidated -elf flag for MoviAsm
(authored by waltl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41713?vs=128557&id=128970#toc
Repository:
rC Clang
ht
apazos added a comment.
Hi Alex, just a reminder, it looks like Eli's and David's comments have not
been addressed yet.
https://reviews.llvm.org/D40023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
apazos added a comment.
This is ready to merge, just waiting for the dependence
https://reviews.llvm.org/D39963 to be merged first.
https://reviews.llvm.org/D41271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, looks good to me.
https://reviews.llvm.org/D41039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
vsapsai created this revision.
vsapsai added reviewers: rsmith, t.p.northover.
For input `0'e+1` lexer tokenized as numeric constant only `0'e`. Later
NumericLiteralParser skipped 0 and ' as digits and parsed `e+1` as valid
exponent going past the end of the token. Because it didn't mark numeric
l
vsapsai added a comment.
This fixes the OSS-Fuzz bug but I don't know if it is sufficient. Should I also
make `Lexer::LexNumericConstant` to include `+1` part as tok::numeric_constant?
https://reviews.llvm.org/D41834
___
cfe-commits mailing list
cf
Author: rsmith
Date: Mon Jan 8 13:12:04 2018
New Revision: 322024
URL: http://llvm.org/viewvc/llvm-project?rev=322024&view=rev
Log:
Factor out comparison handling for arithmetic types.
This is not quite NFC: we don't perform the usual arithmetic conversions unless
we have an operand of arithmeti
Author: dyung
Date: Mon Jan 8 13:21:17 2018
New Revision: 322027
URL: http://llvm.org/viewvc/llvm-project?rev=322027&view=rev
Log:
[DOXYGEN] Fix doxygen and content issues in avxintrin.h
- Fix incorrect wording in various intrinsic descriptions. Previously the
descriptions used "low-order" and
Author: erichkeane
Date: Mon Jan 8 13:34:17 2018
New Revision: 322028
URL: http://llvm.org/viewvc/llvm-project?rev=322028&view=rev
Log:
Implement Attribute Target MultiVersioning
GCC's attribute 'target', in addition to being an optimization hint,
also allows function multiversioning. We current
erichkeane closed this revision.
erichkeane marked 2 inline comments as done.
erichkeane added a comment.
Closed with revision 322028
https://reviews.llvm.org/D40819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
rsmith added a comment.
I'd like to see more testing for the template instantiation case. I don't see
any test coverage for the "attribute only affects instantiations whose members
are trivial-for-calls" part.
Comment at: include/clang/Sema/Sema.h:2239
bool SpecialMemberIs
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This seems fine, but will need https://reviews.llvm.org/D41673 to go in at the
same time. The sanitizers are pretty tightly coupled with the compiler, so I
don't think that it is too big
Author: rsmith
Date: Mon Jan 8 13:46:42 2018
New Revision: 322030
URL: http://llvm.org/viewvc/llvm-project?rev=322030&view=rev
Log:
PR35862: Suppress -Wmissing-variable-declarations warning on inline variables,
variable templates, and instantiations thereof.
Modified:
cfe/trunk/lib/Sema/Sema
Author: danalbert
Date: Mon Jan 8 13:49:12 2018
New Revision: 322031
URL: http://llvm.org/viewvc/llvm-project?rev=322031&view=rev
Log:
Make rehash(0) work with ubsan's unsigned-integer-overflow.
Reviewers: mclow.lists, EricWF
Reviewed By: mclow.lists
Subscribers: cfe-commits
Differential Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX322031: Make rehash(0) work with ubsan's
unsigned-integer-overflow. (authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40743?vs=125193&id=128979#toc
Repository
danalbert added inline comments.
Comment at: include/__hash_table:2141
__n = 2;
else if (__n & (__n - 1))
__n = __next_prime(__n);
mclow.lists wrote:
> danalbert wrote:
> > With `rehash(0)` this is `0 & (0 - 1)`, which triggers
> > unsigne
erichkeane created this revision.
erichkeane added reviewers: rsmith, hans, aaron.ballman, echristo.
Richard suggested that I add this feature to the release notes,
so I was hoping someone (anyone willing:) ) could do a quick read
through for me.
Thanks!
-Erich
Repository:
rC Clang
https://r
echristo added a comment.
I think you're missing that right now it's x86 only yes? :)
-eric
Repository:
rC Clang
https://reviews.llvm.org/D41837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
erichkeane updated this revision to Diff 128982.
erichkeane added a comment.
Ah, right :) Slipped my mind that ELF != x86-linux.
https://reviews.llvm.org/D41837
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
---
Author: marshall
Date: Mon Jan 8 14:16:30 2018
New Revision: 322034
URL: http://llvm.org/viewvc/llvm-project?rev=322034&view=rev
Log:
Apparently 'C++14' is different than 'c++14'
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.search/func.search.bm/hash.pass.cpp
Modified:
1 - 100 of 153 matches
Mail list logo
