arphaman updated this revision to Diff 126856.
arphaman marked an inline comment as done.
arphaman added a comment.
- Use separate functions for checks.
- "ARM" should match "thumb" arch too.
https://reviews.llvm.org/D41087
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPMacroExpansion.cp
steven_wu accepted this revision.
steven_wu added a comment.
LGTM
https://reviews.llvm.org/D41087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
In https://reviews.llvm.org/D40671#949732, @xgsa wrote:
> In https://reviews.llvm.org/D40671#949687, @alexfh wrote:
>
> > How are unknown check names handled? More specifically: will the `//
> > NOLINT(runtime/explicit)` comment disable all
rjmccall added a comment.
In https://reviews.llvm.org/D41050#953917, @danzimm wrote:
> Change tests to use non-O2 generated IR. It looks like the combined
> objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue calls
> annihilate each other and we just get a call/ret.
Is that really
timshen updated this revision to Diff 126872.
timshen marked 7 inline comments as done.
timshen added a comment.
Address second round of comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:594
+
+#warning " is under construction and not for practical use
for now."
+
EricWF wrote:
> I would just remove this. The `experimental` part of the name should say
> enough.
>
> Als
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
Herald added a subscriber: jfb.
[libcxx] [test] Improve MSVC portability.
test/support/msvc_stdlib_force_include.hpp
When testing MSVC's STL with C1XX, simulate a couple more compiler feature-test
macros.
When testin
Hello everyone,
Below are some buildbot numbers for the week of 11/26/2017 - 12/02/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 12/3/2017 - 12/9/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
danzimm added a comment.
In https://reviews.llvm.org/D41050#954668, @rjmccall wrote:
> In https://reviews.llvm.org/D41050#953917, @danzimm wrote:
>
> > Change tests to use non-O2 generated IR. It looks like the combined
> > objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue calls
>
saar.raz created this revision.
saar.raz added reviewers: changyu, rsmith, hubert.reinterpretcast, nwilson.
Herald added a subscriber: cfe-commits.
Part of the P0734r0 Concepts implementation effort. Added Concept
Specialization Expressions and tests thereof. Also added constraint expression
typ
lichray added inline comments.
Comment at: include/ostream:225
+basic_ostream& operator<<(nullptr_t)
+{ return *this << (const void*)0; }
+
K-ballo wrote:
> Quuxplusone wrote:
> > mclow.lists wrote:
> > > lichray wrote:
> > > > Oh, common, I persuaded the
danzimm added a comment.
I just dug into how the ARC optimization pass is invoked... it really shouldn't
be invoked if `-disable-llvm-passes` is passed (or `-disable-llvm-optzns` which
appears to just alias the first). Can you verify that my command is sane:
/Users/danzimm/oss/build/bin/clang
danzimm updated this revision to Diff 126892.
danzimm added a comment.
Pass -disable-llvm-passes with -O3 so that we can test that the IR we generate
actually is generated
Repository:
rC Clang
https://reviews.llvm.org/D41050
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenObjCXX/arc-forwarde
danzimm updated this revision to Diff 126893.
danzimm added a comment.
Remove unnecessary checks from tests (sorry for unbatched updates)
Repository:
rC Clang
https://reviews.llvm.org/D41050
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenObjCXX/arc-forwarded-lambda-call.mm
Index: test/Code
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D41189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
dcoughlin added a comment.
This is seems like a very useful visualization, *especially* for loops. Can we
this patch get it into a state where it can be committed and used for debugging
purposes?
One possibility is to turn this into a debug checker similar to
debug.ViewExplodedGraph. That chec
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
I've tried using the patch, and I got blocked at the following: CTU options are
only exposed when one goes through `analyze-build` frontend, which requires
`compi
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1976
+unsigned FileEndOffset = SM.getFileOffset(SM.getLocForEndOfFile(FID));
+for (unsigned i=Offset; BufferStart[i] != '\n' && i < FileEndOffset; ++i)
+ Ostream << BufferStar
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Heh, alright, that works. It's unfortunate that -disable-llvm-passes doesn't
suppress running the pass under -O0; that seems like an oversight.
Anyway, LGTM.
Repository:
rC Clang
htt
changyu added inline comments.
Comment at: lib/AST/ExprCXX.cpp:1481
+if (E.isInvalid() || Trap.hasErrorOccurred()) {
+// C++2a [temp.constr.atomic]p1
+// ...If substitution results in an invalid type or expression, the
You have four spaces o
dexonsmith added a comment.
In https://reviews.llvm.org/D41050#954863, @rjmccall wrote:
> Heh, alright, that works. It's unfortunate that -disable-llvm-passes doesn't
> suppress running the pass under -O0; that seems like an oversight.
>
> Anyway, LGTM.
I suspect `-O0` just generates differen
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me for a quick fix that we plan to address in a more
principled fashion later.
However, I'd like you to add a comment at each of the places where you use the
parent m
rjmccall added a comment.
Oh, yes, that could be.
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
I am happy now. But I don't have any authority to allow this patch to land
whatsoever. Who will be the code owner for `clang-doc`? I think the tooling
guys need to accept.
Comment at: tools/clang-doc/ClangDoc.cpp:54
+
+ // TODO: Move set attached t
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
This patch fixes llvm.org/PR35491
The fix attempts to maintain ABI compatibility by replacing the array with a
instance of `aligned_storage`.
https://reviews.llvm.org/D41223
Files:
include/array
test/std/containers/sequen
NoQ added a comment.
In https://reviews.llvm.org/D40809#954858, @dcoughlin wrote:
> One possibility is to turn this into a debug checker similar to
> debug.ViewExplodedGraph. That checker registers for a checkEndAnalysis()
> callback and traverses the node graph (see DebugCheckers.cpp). Can you
EricWF updated this revision to Diff 126898.
EricWF added a comment.
Fix begin/end/data.
===
https://reviews.llvm.org/D41223
Files:
include/array
test/std/containers/sequences/array/array.cons/default.pass.cpp
test/std/containers/sequences/array/array.data/data.pass.cpp
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTestObjC.cpp:388
+ // Wrapped method parameters should be indented.
+ verifyFormat("- (VeryLongReturnTypeName)\n"
+ "
xgsa added a comment.
In https://reviews.llvm.org/D40671#954661, @alexfh wrote:
> In https://reviews.llvm.org/D40671#953888, @aaron.ballman wrote:
>
> > FWIW, I think we should do something about unknown check names in NOLINT
> > comments, but that can be done as a follow-up patch. If we're igno
rwols closed this revision.
rwols added a comment.
https://reviews.llvm.org/D41118 fixes both the start positions as well as the
ranges, let's merge that.
https://reviews.llvm.org/D40860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: sammccall
Date: Wed Dec 13 00:34:48 2017
New Revision: 320554
URL: http://llvm.org/viewvc/llvm-project?rev=320554&view=rev
Log:
[clangd] Overload hash_value for SymbolID, fix struct/class warning
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
Modified: clang-tools-extra/trunk
JonasToth added a comment.
You can erase some namespace prefix in code, e.g. llvm or clang, because you
are working in them and/or had `using namespace clang`. Imo this is not
required only if you find it ok to shorten the code.
Comment at: tools/clang-doc/ClangDoc.cpp:30
+bo
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: sammccall
Date: Wed Dec 13 00:48:42 2017
New Revision: 320555
URL: http://llvm.org/viewvc/llvm-project?rev=320555&view=rev
Log:
[clangd] Emit ranges for clangd diagnostics, and fix off-by-one positions
Summary:
- when the diagnostic has an explicit range, we prefer that
- if the diagnos
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE320555: [clangd] Emit ranges for clangd diagnostics, and
fix off-by-one positions (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41118?vs=126563&id=126679#t
sammccall added inline comments.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier, using USR.
malaperle wrote:
> sammccall wrote:
> > malaperle wrote:
> > > malaperle wrote:
> >
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at:
google3/third_party/llvm/llvm/tools/clang/tools/clang-format/git-clang-format:252
+ assert len(commits) != 0
+ if len(commits) >= 2:
+return Revision(co
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D41147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ilya-biryukov updated this revision to Diff 126680.
ilya-biryukov added a comment.
- Make Context the first parameter in rename and a few helper methods.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D41130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
hokein added inline comments.
Comment at: clangd/index/Index.h:52
+private:
+ friend class llvm::DenseMapInfo;
+
sammccall wrote:
> ioeric wrote:
> > warning: class 'DenseMapInfo' was previously declared as a struct
> > [-Wmismatched-tags]
> Fixed in rCTE320554
lebedev.ri updated this revision to Diff 126681.
lebedev.ri changed the repository for this revision from rL LLVM to rCTE Clang
Tools Extra.
lebedev.ri added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
Files:
test/clang-tidy/check_clang_tidy.py
lebedev.ri updated this revision to Diff 126682.
lebedev.ri added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36836
Files:
LICENSE.TXT
clang-tidy/CMakeLists.txt
clang-tidy/plugin/CMakeLists.txt
clang-tidy/sonarsource/CMakeLists.txt
clang-tidy/so
ilya-biryukov updated this revision to Diff 126683.
ilya-biryukov added a comment.
These should be the last usages where Context is not a first paramter.
- Make Context the first parameter in findDefinitions and CppFile::rebuild.
- Make Context the first parameter in invokeCodeCompletion.
Repos
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks! Just style and comment nits left really.
Comment at: clangd/ClangdServer.cpp:216
-std::future>
-ClangdServer::codeComplete(PathRef File, Position Pos,
+std::f
ioeric updated this revision to Diff 126686.
ioeric added a comment.
Merged with origin/master and moved index-related files to index/ subdirectory.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdL
hokein added inline comments.
Comment at: test/clangd/diagnostics.test:10
{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///foo.c","languageId":"c","version":1,"text":"void
main() {}"}}}
# CHECK: "method": "textDocument/publishD
ro added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684
if (AddExportDynamic)
-CmdArgs.push_back("-export-dynamic");
+CmdArgs.push_back("--export-dynamic");
alekseyshl wrote:
> If it does not exist on Solaris, why change it the
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
I'll LGTM this to unblock @ioeric . We'll also get a test using the flag in
clangd soon. @arphaman, let us know if you feel there's something wrong with
the patch.
Repository:
rC Clang
https://reviews.llvm.org/D40562
__
seaneveson marked an inline comment as done.
seaneveson added a comment.
In https://reviews.llvm.org/D40712#949979, @MatzeB wrote:
> I also wonder whether it would be possible to move the fact that it defaults
> to on for PS4 into the PS4CPU.cpp file somehow (not that things are
> distributed t
ioeric updated this revision to Diff 126694.
ioeric added a comment.
- Merged with origin/master
Repository:
rC Clang
https://reviews.llvm.org/D40562
Files:
include/clang/Driver/CC1Options.td
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/CodeCompleteOptions.h
lib/Front
Author: ioeric
Date: Wed Dec 13 02:26:49 2017
New Revision: 320563
URL: http://llvm.org/viewvc/llvm-project?rev=320563&view=rev
Log:
[Sema] Ignore decls in namespaces when global decls are not wanted.
Summary: ... in qualified code completion and decl lookup.
Reviewers: ilya-biryukov, arphaman
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320563: [Sema] Ignore decls in namespaces when global decls
are not wanted. (authored by ioeric, committed by ).
Changed
sammccall added inline comments.
Comment at: test/clangd/diagnostics.test:10
{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///foo.c","languageId":"c","version":1,"text":"void
main() {}"}}}
# CHECK: "method": "textDocument/publi
ilya-biryukov updated this revision to Diff 126712.
ilya-biryukov marked 13 inline comments as done.
ilya-biryukov added a comment.
- Removed obsolete comments.
- Moved ScopeExitGuard to namespace detail.
- Added FIXMEs to pass context to compilation database.
- Addded a FIXME to JSONOutput.
- Rem
ilya-biryukov marked 13 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:216
-std::future>
-ClangdServer::codeComplete(PathRef File, Position Pos,
+std::future, Context>>
+ClangdServer::codeComplete(Context Ctx, PathRef File, Pos
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/Function.h:157
+
+ ScopeExitGuard(ScopeExitGuard &&Other)
+ : F(std::move(Other.F)), Moved(Other.Moved) {
ilya-biryukov wrote:
> sammccall wrote:
> > I'm struggling to thi
sberg added a comment.
friendly ping; any input on my two questions maybe?
https://reviews.llvm.org/D40295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg added a comment.
friendly ping
https://reviews.llvm.org/D40720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
uriel.k created this revision.
uriel.k added reviewers: craig.topper, igorb.
seperates the non-round version from the round version of sqrt builtins
and catching them in CGBuiltin.cpp to replace builtin with IR.
https://reviews.llvm.org/D41168
Files:
include/clang/Basic/BuiltinsX86.def
lib/
sammccall added a comment.
I think this patch is too big, and there are several separate pieces here:
- the index interface, and the implementation of the dynamic symbol index
(these probably belong together). We're missing unit tests for the
implementation.
- building and updating the dynamic
ilya-biryukov updated this revision to Diff 126725.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Simplify ScopeExitGuard by using llvm::Optional<>.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
cla
Author: hokein
Date: Wed Dec 13 04:39:06 2017
New Revision: 320574
URL: http://llvm.org/viewvc/llvm-project?rev=320574&view=rev
Log:
[clangd] Remove the const specifier of the takeSymbol method
otherwise we will copy an object.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.h
ilya-biryukov updated this revision to Diff 126728.
ilya-biryukov added a comment.
Merged with head
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/Clangd
Author: ibiryukov
Date: Wed Dec 13 04:51:22 2017
New Revision: 320576
URL: http://llvm.org/viewvc/llvm-project?rev=320576&view=rev
Log:
[clangd] Implemented logging using Context
Reviewers: sammccall, ioeric, hokein
Reviewed By: sammccall
Subscribers: klimek, cfe-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE320576: [clangd] Implemented logging using Context
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40486?vs=126728&id=126729#toc
Repository:
rCTE Clang To
Author: ibiryukov
Date: Wed Dec 13 04:53:16 2017
New Revision: 320577
URL: http://llvm.org/viewvc/llvm-project?rev=320577&view=rev
Log:
[clangd] clang-format the source code. NFC
Modified:
clang-tools-extra/trunk/clangd/index/Index.cpp
clang-tools-extra/trunk/clangd/index/Index.h
clan
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:196
+ /// \brief Counter indicating how often the preamble was build in total.
+ unsigned PreambleCounter;
+
nik wrote:
> Any better name for this one? Otherwise I would suggest r
miyuki updated this revision to Diff 126738.
miyuki added a comment.
Modified the test to use NULL instead of literal zero.
https://reviews.llvm.org/D40707
Files:
include/sstream
test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp
Index:
test/std/input.output/s
miyuki updated this revision to Diff 126739.
miyuki added a comment.
Use diff with context.
https://reviews.llvm.org/D40707
Files:
include/sstream
test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp
Index:
test/std/input.output/string.streams/stringbuf/stringbu
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
It seems this patch is out of date, we need to merge it with the latests head.
Comment at: clangd/DraftStore.cpp:45
std::lock_guard Lock(Mutex);
+
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ilya-biryukov, mgorny, klimek.
This will be used together with https://reviews.llvm.org/D40548 for the global
index source (experimental).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D
Author: ibiryukov
Date: Wed Dec 13 05:43:47 2017
New Revision: 320578
URL: http://llvm.org/viewvc/llvm-project?rev=320578&view=rev
Log:
[clangd] Try to workaround MSVC compilation failure.
Modified:
clang-tools-extra/trunk/clangd/Context.h
Modified: clang-tools-extra/trunk/clangd/Context.h
U
lebedev.ri added inline comments.
Herald added a subscriber: mgorny.
Comment at: test/clang-tidy/misc-static-assert.cpp:71
+
+ assert(ZERO_MACRO && "Report me!");
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be
Hmm. Are you sure about
Author: kparzysz
Date: Wed Dec 13 05:48:07 2017
New Revision: 320579
URL: http://llvm.org/viewvc/llvm-project?rev=320579&view=rev
Log:
[Hexagon] Add front-end support for Hexagon V65
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/lib/Basic/Targets/Hexagon.cpp
cfe/trunk/
ilya-biryukov updated this revision to Diff 126748.
ilya-biryukov added a comment.
Merged with head
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40488
Files:
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
clangd/Trace.h
clangd/tool/ClangdMain.cp
miyuki created this revision.
miyuki added reviewers: faisalv, rsmith, rogfer01.
[Sema] Diagnose template specializations with C linkage
According to the C++ standard, templates as well as their
specializations cannot have C language linkage. Clang currently does
not diagnose function template sp
sammccall added a comment.
Nice! just nits
Comment at: clangd/index/SymbolFromYAML.cpp:32
+// supported in YAML I/O.
+struct NPArray {
+ NPArray(IO &) {}
what does NP stand for?
Comment at: clangd/index/SymbolFromYAML.cpp:44
+
+ std::vector
aaron.ballman added a comment.
You're set to commit (if there are concerns, @rsmith can raise them
post-commit). Do you need me to commit on your behalf?
https://reviews.llvm.org/D39937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
aaron.ballman added a comment.
In https://reviews.llvm.org/D40671#953291, @xgsa wrote:
> @aaron.ballman, sorry for my insistence, but it seems all the comments are
> fixed and the patch is ready for commit or am I missing something? Could you
> please commit it on my behalf, as I don't have rig
Author: abataev
Date: Wed Dec 13 07:28:44 2017
New Revision: 320590
URL: http://llvm.org/viewvc/llvm-project?rev=320590&view=rev
Log:
[OPENMP] Fix handling of clauses in clause parsing mode.
The compiler may generate incorrect code if we try to capture the
variable in clause parsing mode.
Modifi
aaron.ballman added a comment.
I think you're set to commit this -- if @alexfh has concerns, they can be
addressed post-commit.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
___
cfe-commits mailing list
cfe-commits@lists.llv
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Do you need someone to commit it?
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
miyuki added a comment.
Yes, I don't have write access.
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ibiryukov
Date: Wed Dec 13 07:42:59 2017
New Revision: 320591
URL: http://llvm.org/viewvc/llvm-project?rev=320591&view=rev
Log:
[clangd] Fix bool conversion operator of UniqueFunction
Usages of it were giving compiler errors because of the missing
explicit conversion.
Modified:
clang
ilya-biryukov updated this revision to Diff 126762.
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added a comment.
- Changed the EventTracer interface to return a callback from beginEvent
instead of using begin_event/end_event method pairs.
Repository:
rCTE Clang Tools Extra
ilya-biryukov added inline comments.
Comment at: clangd/Trace.h:39
+ /// Called when event with \p Name starts.
+ virtual void begin_event(const ContextData &Ctx, llvm::StringRef Name) = 0;
+ /// Called when event with \p Name ends.
sammccall wrote:
> just cal
danzimm updated this revision to Diff 126763.
danzimm added a comment.
Change tests to use non-O2 generated IR. It looks like the combined
objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue calls annihilate
each other and we just get a call/ret.
Repository:
rC Clang
https://revi
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1809
bool DuplicateArchitecture = false;
+ bool operator==(const ParsedTargetAttr &Other) {
+return DuplicateArchitecture == Other.DuplicateArchitecture &&
This funct
lebedev.ri added a comment.
In https://reviews.llvm.org/D36892#953891, @aaron.ballman wrote:
> I think you're set to commit this
Should i commit it though?
Until licensing concerns with https://reviews.llvm.org/D36836 are finally
magically resolved and it is committed, there won't be any users
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Trace.cpp:134
+ Callback = T->beginSpan(Ctx, Name);
+ if (!Callback)
+return;
I'm not sure this is useful. Tracers that ar
aaron.ballman added a comment.
In https://reviews.llvm.org/D36892#953953, @lebedev.ri wrote:
> In https://reviews.llvm.org/D36892#953891, @aaron.ballman wrote:
>
> > I think you're set to commit this
>
>
> Should i commit it though?
> Until licensing concerns with https://reviews.llvm.org/D36836
rogfer01 added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7021
+ // C++ [temp]p6:
+ // A template, a template explicit specialization, and a class template
+ // partial specialization shall not have C linkage.
Can you add a test for a partial s
danzimm added a comment.
Ah, just found test/Transforms/ObjCARC/rv.ll test3:
; Delete a redundant retainRV,autoreleaseRV when forwaring a call result
; directly to a return value.
; CHECK-LABEL: define i8* @test3(
; CHECK: call i8* @returner()
; CHECK-NEXT: ret i8* %call
define i8*
asb updated this revision to Diff 126769.
asb edited the summary of this revision.
asb added a comment.
Update to add test cases based on the multilib Linux SDK produced by
https://github.com/riscv/riscv-gnu-toolchain/.
https://reviews.llvm.org/D39963
Files:
lib/Basic/CMakeLists.txt
lib/Ba
asb updated this revision to Diff 126771.
asb added a comment.
Apologies, the last version had a few lines of debug code left in.
I should say that this is to the best of my knowledge ready to merge (i.e.
there are no outstanding flagged issues). Particularly now that the majority of
the RV32I
Author: abataev
Date: Wed Dec 13 09:31:39 2017
New Revision: 320596
URL: http://llvm.org/viewvc/llvm-project?rev=320596&view=rev
Log:
[OPENMP] Support `reduction` clause on target-based directives.
OpenMP 5.0 added support for `reduction` clause in target-based
directives. Patch adds this support
mclow.lists added a comment.
Other than the actual text being output, this LGTM.
I'ld like to see the changes I suggested in the test go in, but they're really
minor.
Comment at: include/ostream:225
+basic_ostream& operator<<(nullptr_t)
+{ return *this << (const void*)
ABataev updated this revision to Diff 126773.
ABataev added a comment.
Status update.
Repository:
rC Clang
https://reviews.llvm.org/D39457
Files:
docs/OpenMPSupport.rst
docs/index.rst
Index: docs/index.rst
===
--- docs/ind
1 - 100 of 162 matches
Mail list logo
