JonasToth added a comment.
I am happy now. But I don't have any authority to allow this patch to land
whatsoever. Who will be the code owner for `clang-doc`? I think the tooling
guys need to accept.
================
Comment at: tools/clang-doc/ClangDoc.cpp:54
+
+ // TODO: Move set attached to the initial comment parsing, not here
+ if (Comment) {
----------------
Full sentence.
`set attached` == `setAttached`?
Removing the not here and using the method name is probably enough already.
================
Comment at: tools/clang-doc/tool/ClangDocMain.cpp:42
+
+ doc::OutFormat EmitFormat;
+ EmitLLVM ? EmitFormat = clang::doc::OutFormat::LLVM
----------------
The two lines could be merged when initializing `EmitFormat` directly.
================
Comment at: tools/clang-doc/tool/ClangDocMain.cpp:47
+ // TODO: Update the source path list to only consider changed files for
+ // incremental doc updates
+ doc::ClangDocReporter Reporter(OptionsParser.getSourcePathList());
----------------
Missing full stop. Comments are supposed to be full sentences by convention.
https://reviews.llvm.org/D41102
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
