sammccall added inline comments.
================
Comment at: test/clangd/diagnostics.test:10
{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///foo.c","languageId":"c","version":1,"text":"void
main() {}"}}}
# CHECK: "method": "textDocument/publishDiagnostics",
----------------
hokein wrote:
> Maybe the current tests are enough. Do we want to add a test where the
> diagnostic location is at the end of the line?
>
> ```
> f()
> // ^ missing ";"
> f();
> ```
Good point - the current tests only incidentally cover much of the diagnostics
functionality.
The lit tests for this are brittle and hard to read, I'll write some gtest
cases similar to CodeComplete.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41118
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
