[PATCH] D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added a comment. In https://reviews.llvm.org/D38821#895527, @compnerd wrote: > Don't you need a change to the intrinsics to actually map the builtin? This seems to be automatically mapped via this piece of code in CGBuiltin.cpp: // See if we have a target specific intrinsic. const

r315567 - [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

Author: mstorsjo Date: Thu Oct 12 00:05:37 2017 New Revision: 315567 URL: http://llvm.org/viewvc/llvm-project?rev=315567&view=rev Log: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb Differential Revision: https://reviews.llvm.org/D38821 Added: cfe/trunk/test/CodeGen/arm64-microsoft-intrin

[PATCH] D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

This revision was automatically updated to reflect the committed changes. Closed by commit rL315567: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D38821?vs=118689&id=118747#toc Repository: rL LLVM https://reviews

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny added a comment. In https://reviews.llvm.org/D38444#895403, @george.karpenkov wrote: > @mgorny I've replied via email, but the message didn't seem to appear here. > > From my (maybe limited) understanding, running tests on standalone > compiler-rt builds was never something which was supp

r315568 - Split the AlignTrailingComments on several lines. The comments were applied to the right columns

Author: sylvestre Date: Thu Oct 12 01:07:53 2017 New Revision: 315568 URL: http://llvm.org/viewvc/llvm-project?rev=315568&view=rev Log: Split the AlignTrailingComments on several lines. The comments were applied to the right columns Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modif

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

krasimir added a comment. ping https://reviews.llvm.org/D37695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added a comment. In https://reviews.llvm.org/D35082#895312, @yaxunl wrote: > Thanks. I will separate the implicit addr space flag to another patch. Thanks, appreciated. Comment at: include/clang/AST/Type.h:562 + static const uint32_t IMask = 0x200; + static const

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny abandoned this revision. mgorny added a comment. Ok, I think I've found a better solution. Will start submitting patches soonish. Repository: rL LLVM https://reviews.llvm.org/D38444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

mgorny created this revision. Herald added a subscriber: dberris. Fix typo in variable assignment inside sanitizer_test_compile() that resulted in TEST_DEPS parameter not being included in the clang_compile() call. Spotted by George Karpenkov in https://reviews.llvm.org/D38444. https://reviews.l

[PATCH] D38452: Mark test as a long-test

This revision was automatically updated to reflect the committed changes. Closed by commit rL315570: Mark test as a long-test (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D38452?vs=117317&id=118753#toc Repository: rL LLVM https://reviews.llvm.org/D38452 Files:

[libcxx] r315570 - Mark test as a long-test

Author: rogfer01 Date: Thu Oct 12 01:46:05 2017 New Revision: 315570 URL: http://llvm.org/viewvc/llvm-project?rev=315570&view=rev Log: Mark test as a long-test Differential Revision: https://reviews.llvm.org/D38452 Modified: libcxx/trunk/test/std/input.output/stream.buffers/streambuf/strea

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

mgorny created this revision. Herald added a subscriber: dberris. Fix the gtest dependency to be included in DEPS only, rather than in COMPILE_DEPS + DEPS. The former variable is apparently used to provide unconditional dependencies, while the latter are only used for non-standalone builds. Since

[PATCH] D38840: [compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests

mgorny created this revision. Herald added subscribers: dberris, kubamracek. Unify the ASAN dynamic test logic to use generate_asan_tests() in both MSVC and non-MSVC branch. It is unclear why this particular branch used add_compiler_rt_test() directly. However, it skipped the COMPILE_DEPS/DEPS log

[PATCH] D38444: [compiler-rt] [cmake] Create dummy gtest target for stand-alone builds

mgorny added a comment. https://reviews.llvm.org/D38838 addresses the typo. Now that I know how it's supposed to work, https://reviews.llvm.org/D38839 and https://reviews.llvm.org/D38840 address the issues, and fix it for me. Repository: rL LLVM https://reviews.llvm.org/D38444 __

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

NoQ added a comment. Ideas behind both hashing change and new testing mechanism look great to me. I think it would be great to split them into two different patches, to be able to easily see how the change in the hashing affects the tests (and maybe revert easily if something goes wrong). ==

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

xazax.hun added a comment. In https://reviews.llvm.org/D38728#895669, @NoQ wrote: > I think it would be great to split them into two different patches, to be > able to easily see how the change in the hashing affects the tests (and maybe > revert easily if something goes wrong). So you would

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

NoQ added a comment. The other way round, i guess. I like the test change, it's easier to understand, so it's better to have it before starting to understand :) https://reviews.llvm.org/D38728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38772: [refactor] allow the use of refactoring diagnostics

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Basic/DiagnosticIDs.cpp:46 unsigned WarnShowInSystemHeader : 1; - unsigned Category : 5; + unsigned Category : 6; arphaman

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Hi, I am not sure if could follow correctly, but the test for nested namespaces comments does not work correctly and is therefore currently disabled by fileextension? When running the check from trunk i get the following issues: $ clang-check google-readability-namespace-comments-cxx17.cpp -

r315573 - Fix warnings. [-Wdocumentation]

Author: chapuni Date: Thu Oct 12 02:42:14 2017 New Revision: 315573 URL: http://llvm.org/viewvc/llvm-project?rev=315573&view=rev Log: Fix warnings. [-Wdocumentation] Modified: cfe/trunk/lib/Lex/TokenLexer.cpp cfe/trunk/lib/Sema/MultiplexExternalSemaSource.cpp cfe/trunk/lib/Serializati

r315572 - SVal::getAsSymbol(bool IncludeBaseRegions): Follow clang/StaticAnalyzer/Core/PathSensitive/SVals.h, s/IncludeBaseRegion/IncludeBaseRegions/g [-Wdocumentation]

Author: chapuni Date: Thu Oct 12 02:42:12 2017 New Revision: 315572 URL: http://llvm.org/viewvc/llvm-project?rev=315572&view=rev Log: SVal::getAsSymbol(bool IncludeBaseRegions): Follow clang/StaticAnalyzer/Core/PathSensitive/SVals.h, s/IncludeBaseRegion/IncludeBaseRegions/g [-Wdocumentation] Mo

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

chapuni added inline comments. Comment at: cfe/trunk/lib/Basic/TargetInfo.cpp:351 +LangAS::ID TargetInfo::getOpenCLTypeAddrSpace(const Type *T) const { + auto BT = dyn_cast(T); Excuse me for old commit, I think it might be layering violation. Could we avoid us

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#890537, @r.stahl wrote: > In https://reviews.llvm.org/D34512#877643, @xazax.hun wrote: > > > - Unittests now creates temporary files at the correct location > > - Temporary files are also cleaned up when the process is terminated > > -

[clang-tools-extra] r315574 - Fix the google-readability-namespace-comments-cxx17 test after r315060.

Author: alexfh Date: Thu Oct 12 03:41:22 2017 New Revision: 315574 URL: http://llvm.org/viewvc/llvm-project?rev=315574&view=rev Log: Fix the google-readability-namespace-comments-cxx17 test after r315060. Restore the file extension. Make the namespace longer than the ShortNamespaceLines so that t

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

On Thu, Oct 12, 2017 at 11:12 AM, Jonas Toth wrote: > Hi, > > I am not sure if could follow correctly, but the test for nested > namespaces comments does not work correctly and is therefore currently > disabled by fileextension? > No, the removal of the file extension was unintentional (likely m

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Ok. I subscribe to r315057. I can look at debugging the change as well if you guys want. Should have time today evening and tomorrow. Am 12.10.2017 um 12:46 schrieb Alexander Kornienko: On Thu, Oct 12, 2017 at 11:12 AM, Jonas Toth > wrote: Hi, I am not

r315575 - [CodeGen] Generate TBAA info along with LValue base info

Author: kosarev Date: Thu Oct 12 04:29:46 2017 New Revision: 315575 URL: http://llvm.org/viewvc/llvm-project?rev=315575&view=rev Log: [CodeGen] Generate TBAA info along with LValue base info This patch enables explicit generation of TBAA information in all cases where LValue base info is propagat

[PATCH] D38733: [CodeGen] Generate TBAA info along with LValue base info

This revision was automatically updated to reflect the committed changes. Closed by commit rL315575: [CodeGen] Generate TBAA info along with LValue base info (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38733?vs=118551&id=118771#toc Repository: rL LLVM https://r

[PATCH] D38835: [refactor] selection: new CodeRangeASTSelection represents a set of selected consecutive statements

hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/ASTSelection.h:74 +/// An AST selection value that corresponds to a selection of a set of +/// statements that belong to one body of code (like one function). +/// I see all your tests ar

[PATCH] D38842: [CrossTU] Fix handling of Cross Translation Unit directory path

xazax.hun created this revision. The function map generator tool always creates absolute path. The correct logic to determine whether a path should be handled as absolute depends on the value of the CrossTU directory. Added a unit test to avoid regressions. https://reviews.llvm.org/D38842 Fil

[PATCH] D38843: [ASTImporter] Support importing CXXPseudoDestructorExpr

szepet created this revision. Adding VisitCXXPseudoDestructorExpr callback to the ASTImporter. Note: This is based on: https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp#L7624 . https://reviews.llvm.org/D38843 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTIm

[PATCH] D38464: [clangd] less boilerplate in RPC dispatch

sammccall updated this revision to Diff 118782. sammccall added a comment. Rebase https://reviews.llvm.org/D38464 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/JSONRPCDispatcher.cpp clangd/JSONRPCDispatcher.h clangd/Protocol.cpp clangd/Protocol.h clangd/Protoco

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

szepet created this revision. The visit callback implementations for the 3 C++ AST Node added to the ASTImporter. Note: Based on: https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp https://reviews.llvm.org/D38845 Files: lib/AST/ASTImporter.cpp unittests/AST/AS

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson updated this revision to Diff 118784. arichardson added a comment. Removed the additional namespace https://reviews.llvm.org/D38816 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h include/clang/Basic/TargetInfo.h lib/AST/A

Re: [PATCH] D38464: [clangd] less boilerplate in RPC dispatch

Interesting - this is pretty primitive, and still fairly tightly coupled to JSON-RPC. I can't easily tell from the code how the ORC RPC functionality - would it be easy to use with JSON-RPC, does it make sense to use serialization only, does it have opinions about threading models? And really, what

[clang-tools-extra] r315577 - [clangd] less boilerplate in RPC dispatch

Author: sammccall Date: Thu Oct 12 06:29:58 2017 New Revision: 315577 URL: http://llvm.org/viewvc/llvm-project?rev=315577&view=rev Log: [clangd] less boilerplate in RPC dispatch Summary: Make the ProtocolHandlers glue between JSONRPCDispatcher and ClangdLSPServer generic. Eliminate small differen

[PATCH] D38464: [clangd] less boilerplate in RPC dispatch

This revision was automatically updated to reflect the committed changes. Closed by commit rL315577: [clangd] less boilerplate in RPC dispatch (authored by sammccall). Repository: rL LLVM https://reviews.llvm.org/D38464 Files: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-tools

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

Anastasia added inline comments. Comment at: cfe/trunk/lib/Basic/TargetInfo.cpp:351 +LangAS::ID TargetInfo::getOpenCLTypeAddrSpace(const Type *T) const { + auto BT = dyn_cast(T); chapuni wrote: > Excuse me for old commit, I think it might be layering violation

r315578 - [OPENMP] Fix PR34925: Fix getting thread_id lvalue for inlined regions

Author: abataev Date: Thu Oct 12 06:51:32 2017 New Revision: 315578 URL: http://llvm.org/viewvc/llvm-project?rev=315578&view=rev Log: [OPENMP] Fix PR34925: Fix getting thread_id lvalue for inlined regions in C. If we try to get the lvalue for thread_id variables in inlined regions, we did not use

Re: [clang-tools-extra] r315057 - Fix nested namespaces in google-readability-nested-namespace-comments.

On Fri, Oct 6, 2017 at 2:57 PM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Fri Oct 6 05:57:28 2017 > New Revision: 315057 > > URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev > Log: > Fix nested namespaces in google-readability-ne

Re: [clang-tools-extra] r315057 - Fix nested namespaces in google-readability-nested-namespace-comments.

On Thu, Oct 12, 2017 at 10:01 AM, Alexander Kornienko wrote: > > On Fri, Oct 6, 2017 at 2:57 PM, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Fri Oct 6 05:57:28 2017 >> New Revision: 315057 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=315057&view=rev >> Log: >

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

alexfh added inline comments. Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:97 + } + while (Lexer::getRawToken(LBracketLocation, Tok, Sources, getLangOpts()) || + !Tok.is(tok::l_brace)) { The check started triggering an assertion failure

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. looks good. https://reviews.llvm.org/D37695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] r315580 - Revert "Fix nested namespaces in google-readability-nested-namespace-comments."

Author: alexfh Date: Thu Oct 12 07:25:16 2017 New Revision: 315580 URL: http://llvm.org/viewvc/llvm-project?rev=315580&view=rev Log: Revert "Fix nested namespaces in google-readability-nested-namespace-comments." This reverts r315057. The revision introduces assertion failures: assertion failed a

Re: [clang-tools-extra] r315057 - Fix nested namespaces in google-readability-nested-namespace-comments.

Reverted in r315580. On Thu, Oct 12, 2017 at 4:03 PM, Aaron Ballman wrote: > On Thu, Oct 12, 2017 at 10:01 AM, Alexander Kornienko > wrote: > > > > On Fri, Oct 6, 2017 at 2:57 PM, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author: aaronballman > >> Date: Fri Oct 6 05:57:28 2017 > >> N

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

alexfh added inline comments. Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:97 + } + while (Lexer::getRawToken(LBracketLocation, Tok, Sources, getLangOpts()) || + !Tok.is(tok::l_brace)) { alexfh wrote: > The check started triggering an as

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

xazax.hun updated this revision to Diff 118788. xazax.hun added a comment. - Rebase based on the dependent revision and minor cleanups https://reviews.llvm.org/D38728 Files: lib/StaticAnalyzer/Core/IssueHash.cpp test/Analysis/bug_hash_test.cpp test/Analysis/edges-new.mm Index: test/Anal

[libcxx] r315582 - More fuzzing infastructre - regex

Author: marshall Date: Thu Oct 12 07:48:09 2017 New Revision: 315582 URL: http://llvm.org/viewvc/llvm-project?rev=315582&view=rev Log: More fuzzing infastructre - regex Added: libcxx/trunk/test/libcxx/fuzzing/regex_ECMAScript.cpp libcxx/trunk/test/libcxx/fuzzing/regex_POSIX.cpp libcxx

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

Anastasia added a comment. I think it would be good to add a block test to CodeGenOpenCL where we would just call the block without any enqueue and check that the invoke function is generated but the kernel wrapper isn't. Comment at: lib/CodeGen/CGBuiltin.cpp:2846 +

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

Anastasia added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() Why do we need this change? https://rev

r315586 - [OPENMP] Fix PR34926: Fix handling of the array sections passed as

Author: abataev Date: Thu Oct 12 08:18:41 2017 New Revision: 315586 URL: http://llvm.org/viewvc/llvm-project?rev=315586&view=rev Log: [OPENMP] Fix PR34926: Fix handling of the array sections passed as function params. Codegen could crash if the array section base expression is the function parame

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. I have tested this on one of my machines after removing the checks for soft float (my debian install doesn't have the necessary headers for soft-float). With the patch you've pointed out and my inline comments addressed (bar the HI / LO register comments), it passes the

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri updated this revision to Diff 118793. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. @rsmith, thank you for the review! Rebased, address review notes, simplified all the things even further. Testing: - `$ ninja check-clang-sema check-clang-semacxx` - Stage 2

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8667-8679 + bool Result; // The result of the comparison + if ((Op == BO_GT && ValueType == LimitType::Max && ConstOnRight) || + (Op == BO_GT && ValueType == LimitType::Min && !ConstOnRight) || +

Re: r298369 - [OpenCL] Added diagnostic for checking length of vector

I think this bit is a bit confusing to us. Some of our original OpenCL checks were removed in some places because in some cases OpenCL semantic was adopted elsewhere. But I think this should indeed go under OpenCL check. Thanks, Anastasia From: Bruno Cardoso Lo

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl updated this revision to Diff 118795. yaxunl marked 5 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D38134 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBuiltin.cpp lib/CodeGen/CGOpenCLRuntime.cpp lib/CodeGen/CGOpenCLRu

[PATCH] D38134: [OpenCL] Emit enqueued block as kernel

yaxunl added a comment. In https://reviews.llvm.org/D38134#895848, @Anastasia wrote: > I think it would be good to add a block test to CodeGenOpenCL where we would > just call the block without any enqueue and check that the invoke function is > generated but the kernel wrapper isn't. we have

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123 + // Is variable changed anywhere in TU? + for (const Decl *D : AMgr.getASTContext().getTranslationUnitDecl()->decls()) { +if (isChanged(D, VD)) dcoughlin wrote:

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri added a comment. In https://reviews.llvm.org/D36836#889375, @aaron.ballman wrote: > Adding @dberlin for licensing discussion questions. Ping. Yes, i agree that what i have added is not a directory, and not a proper license. That is more of a template to hopefully stat moving things

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

RKSimon added inline comments. Comment at: lib/Headers/clwbintrin.h:34 + +static __inline__ void __DEFAULT_FN_ATTRS +_mm_clwb(void const *__m) { Worth adding the doxygen description? You can probably just copy+paste+modify the _mm_clflush documentation. ==

[PATCH] D38700: [Sema][Crash] Correctly handle an non-dependent noexcept expr in function template

erichkeane added a comment. Bump! I realize the two of you are super busy, but if anyone else on cfe-commits wants to take a look, I'd apprecate it! -Erich https://reviews.llvm.org/D38700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() Anastasia wrote: > Why do we need this

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:123 + // Is variable changed anywhere in TU? + for (const Decl *D : AMgr.getASTContext().getTranslationUnitDecl()->decls()) { +if (isChanged(D, VD)) danielmarjamaki w

[PATCH] D38852: [Hexagon] Handling of new HVX flags and target-features

sgundapa created this revision. Herald added a subscriber: eraman. This patch has the following changes 1. A new flag "-mhvx-length={64B|128B}" is introduced to specify the length of the vector. Previously we have used "-mhvx-double" for 128 Bytes. This adds the target-feature "+hvx-length{64|12

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Frontend/CodeGenOptions.def:182 CODEGENOPT(SoftFloat , 1, 0) ///< -soft-float. +CODEGENOPT(FineGrainedBitfieldAccesses, 1, 0) ///< E

Re: [PATCH] D38464: [clangd] less boilerplate in RPC dispatch

I mention it only out of interest of deduplication of functionality/code within the LLVM project as a whole. Be nice not to maintain two things if one would suffice. On Thu, Oct 12, 2017 at 6:21 AM Sam McCall wrote: > Interesting - this is pretty primitive, and still fairly tightly coupled > to

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Yep, thanks! This was probably the root cause of the failure. https://reviews.llvm.org/D38839 ___ cfe-commits mailing list cf

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Yep, thanks! Good to go provided tests run. Looks like we haven't spotted it due to other bug you have fixed cancelling this one out. https://reviews.llvm.org/D38838 __

[PATCH] D38840: [compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. @mgorny so this one actually changes semantics. The previous one reused generated object files, and with the change it will start recompiling all the tests again.

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. @arichardson, great work! Thanks a lot! https://reviews.llvm.org/D38816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r315594 - [X86] Use -ffreestanding instead of using the mm_malloc.h include guard hack on more of the builtin tests.

Author: ctopper Date: Thu Oct 12 10:21:01 2017 New Revision: 315594 URL: http://llvm.org/viewvc/llvm-project?rev=315594&view=rev Log: [X86] Use -ffreestanding instead of using the mm_malloc.h include guard hack on more of the builtin tests. Modified: cfe/trunk/test/CodeGen/adc-builtins.c

[PATCH] D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags.

morehouse created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D38853 Files: clang/tools/clang-format/CMakeLists.txt clang/tools/clang-format/fuzzer/CMakeLists.txt Index: clang/tools/clang-format/fuzzer/CMakeLists.txt ===

[PATCH] D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags.

kcc added a reviewer: bogner. kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM +Justin FYI Please also take a look at llvm-isel-fuzzer, which I've just added to oss-fuzz https://reviews.llvm.org/D38853 ___

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

craig.topper updated this revision to Diff 118816. craig.topper added a comment. Address review feedback https://reviews.llvm.org/D38781 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/CMakeLists.txt lib/Headers/clwbintrin.h lib/Headers/immintrin.h test/CodeGen/builtin-clwb.c

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl updated this revision to Diff 118813. yaxunl marked 7 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Separate implicit addr space flag to another patch as John suggested. This patch only introduces the private addr space but does not print it.

r315603 - [clang-format] Allow building fuzzer with OSS-Fuzz flags.

Author: morehouse Date: Thu Oct 12 11:39:10 2017 New Revision: 315603 URL: http://llvm.org/viewvc/llvm-project?rev=315603&view=rev Log: [clang-format] Allow building fuzzer with OSS-Fuzz flags. Reviewers: kcc, bogner Reviewed By: kcc Subscribers: cfe-commits, mgorny Differential Revision: http

[PATCH] D38853: [clang-format] Allow building fuzzer with OSS-Fuzz flags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315603: [clang-format] Allow building fuzzer with OSS-Fuzz flags. (authored by morehouse). Changed prior to commit: https://reviews.llvm.org/D38853?vs=118805&id=118819#toc Repository: rL LLVM https:

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - one minor Comment at: lib/Headers/clwbintrin.h:42 +/// +/// \param __p +///A pointer to the memory location used to identify the cache line to be ---

[PATCH] D38857: [OpenCL] Improve printing and semantic check related to implicit addr space

yaxunl created this revision. There are two issues: 1. only (void*)0 should be treated as nullptr 2. only explicit addr space should be printed This patch introduces a flag in Qualifier to indicating a non-default address space qualifier is deduced by context. Only non-implicit address space q

[PATCH] D38838: [compiler-rt] [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile()

This revision was automatically updated to reflect the committed changes. Closed by commit rL315604: [cmake] Fix skipping DEPS (typo) in sanitizer_test_compile() (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38838?vs=118752&id=118820#toc Repository: rL LLVM https:

[PATCH] D38839: [compiler-rt] [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

This revision was automatically updated to reflect the committed changes. Closed by commit rL315605: [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38839?vs=118754&id=118821#toc Repository: rL LLVM

r315607 - [X86] Add CLWB intrinsic. clang part

Author: ctopper Date: Thu Oct 12 11:57:15 2017 New Revision: 315607 URL: http://llvm.org/viewvc/llvm-project?rev=315607&view=rev Log: [X86] Add CLWB intrinsic. clang part Reviewers: RKSimon, zvi, igorb Reviewed By: RKSimon Subscribers: cfe-commits Differential Revision: https://reviews.llvm.or

[PATCH] D38781: [X86] Add CLWB intrinsic. clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rL315607: [X86] Add CLWB intrinsic. clang part (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D38781?vs=118816&id=118822#toc Repository: rL LLVM https://reviews.llvm.org/D387

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: lib/Sema/SemaChecking.cpp:8940 + } else if (!T->hasUnsignedIntegerRepresentation()) +IsComparisonConstant = E->isIntegerConstantExp

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

mgorny updated this revision to Diff 118826. mgorny retitled this revision from "[compiler-rt] [cmake] [asan] Reuse generate_asan_tests for dynamic tests" to "[compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests". mgorny edited the summary of this revision. mgorny added a

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri updated this revision to Diff 118829. lebedev.ri marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D38101 Files: docs/ReleaseNotes.rst include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8930 +// We only care about expressions where just one side is literal +if (IsRHSIntegralLiteral ^ IsLHSIntegralLiteral) { + // Is the constant on the RHS or LHS? rsmith wrote: >

[PATCH] D38859: [clang] Enable clang build with LLVM_BUILD_INSTRUMENTED without setting LLVM_PROFTDATA

alexshap created this revision. Herald added a subscriber: mgorny. At the moment if LLVM_BUILD_INSTRUMENTED is set to True one has to set LLVM_PROFTDATA even if it's not necessary (because of message(FATAL_ERROR ...)). Building instrumented Clang is useful even if one doesn't plan to use the t

r315611 - [OPENMP] Fix PR34927: Emit initializer for reduction array with declare

Author: abataev Date: Thu Oct 12 13:03:39 2017 New Revision: 315611 URL: http://llvm.org/viewvc/llvm-project?rev=315611&view=rev Log: [OPENMP] Fix PR34927: Emit initializer for reduction array with declare reduction. If the reduction is an array or an array section and reduction operation is decl

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

lebedev.ri updated this revision to Diff 118833. lebedev.ri added a comment. Getting really weird problems when trying to use arc patch, maybe re-updating the differential helps Repository: rL LLVM https://reviews.llvm.org/D38101 Files: docs/ReleaseNotes.rst include/clang/Basic/Diagnost

r315614 - [Sema] Diagnose tautological comparison with type's min/max values

Author: lebedevri Date: Thu Oct 12 13:16:51 2017 New Revision: 315614 URL: http://llvm.org/viewvc/llvm-project?rev=315614&view=rev Log: [Sema] Diagnose tautological comparison with type's min/max values Summary: Currently, clang only diagnoses completely out-of-range comparisons (e.g. `char` and

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

yaxunl added inline comments. Comment at: include/clang/Basic/AddressSpaces.h:66 +inline LangAS LangASFromTargetAS(unsigned TargetAS) { + return static_cast((TargetAS) + how about `getLangASFromTargetAS` ? It is preferred to start with small letters. ===

[PATCH] D38101: [Sema] Diagnose tautological comparison with type's min/max values

This revision was automatically updated to reflect the committed changes. Closed by commit rL315614: [Sema] Diagnose tautological comparison with type's min/max values (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D38101?vs=118833&id=118835#toc Repository: rL LLV

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM, provided tests pass both in standalone and "normal" modes. https://reviews.llvm.org/D38840 ___ cfe-commits mailing list

r315615 - [Analysis] Silence -Wtautological-constant-compare in two tests

Author: lebedevri Date: Thu Oct 12 13:27:41 2017 New Revision: 315615 URL: http://llvm.org/viewvc/llvm-project?rev=315615&view=rev Log: [Analysis] Silence -Wtautological-constant-compare in two tests Yes, did not check that. Need to do better :( I do not believe it makes sense to do expect that w

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 118838. Nebiroth marked an inline comment as done. Nebiroth added a comment. Addressed review comments. Fixed some tests not having updated providers. Removed TargetDeclarationFinder for less code reuse. DocumentHighlight struct is now unparsed correctly. h

[PATCH] D38840: [compiler-rt] [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL315620: [cmake] [asan] Remove unnecessary gtest dep from dynamic tests (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D38840?vs=118826&id=118842#toc Repository: rL LLVM http

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

rnk accepted this revision. rnk added a comment. lgtm Comment at: src/libunwind.cpp:188 + co->getInfo(&info); + pint_t orgArgSize = (pint_t)info.gp; + uint64_t orgFuncStart = info.start_ip; mstorsjo wrote: > rnk wrote: > > I think it makes sense

r315621 - [SemaChecking] Suppress a GCC warning. NFCI.

Author: davide Date: Thu Oct 12 14:08:29 2017 New Revision: 315621 URL: http://llvm.org/viewvc/llvm-project?rev=315621&view=rev Log: [SemaChecking] Suppress a GCC warning. NFCI. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL: http://llvm.org/

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added a comment. This one can be abandoned now. https://reviews.llvm.org/D36111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >