RKSimon added inline comments.
================ Comment at: lib/Headers/clwbintrin.h:34 + +static __inline__ void __DEFAULT_FN_ATTRS +_mm_clwb(void const *__m) { ---------------- Worth adding the doxygen description? You can probably just copy+paste+modify the _mm_clflush documentation. ================ Comment at: test/CodeGen/builtin-clwb.c:4 + +#include <immintrin.h> +void test_mm_clwb(const void *__m) { ---------------- Match what is done in the other files: use -ffreestanding instead of defining __MM_MALLOC_H and include the "top header":<x86intrin.h> https://reviews.llvm.org/D38781 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits