alexfh added inline comments.

================
Comment at: clang-tidy/readability/NamespaceCommentCheck.cpp:97
+  }
+  while (Lexer::getRawToken(LBracketLocation, Tok, Sources, getLangOpts()) ||
+         !Tok.is(tok::l_brace)) {
----------------
alexfh wrote:
> The check started triggering an assertion failure and incredible slowness 
> (infinite loops?) on some real files. I've not yet come up with an isolated 
> test case, but all this seems to be happening around this loop.
> 
> I'm going to revert this revision. A bug report (and hopefully a test case ;) 
> will follow.
> 
Reverted in r315580.


https://reviews.llvm.org/D38284



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D38284: ... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D38... Alexandru Octavian Buțiu via Phabricator via cfe-commits
    • [PATCH] D38... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D38... Alexandru Octavian Buțiu via Phabricator via cfe-commits
    • [PATCH] D38... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexander Kornienko via Phabricator via cfe-commits
    • [PATCH] D38... Alexandru Octavian Buțiu via Phabricator via cfe-commits

Reply via email to