arichardson added inline comments.

================
Comment at: lib/AST/TypePrinter.cpp:1323
     OS << "address_space(";
-    OS << T->getEquivalentType().getAddressSpace();
+    OS << T->getEquivalentType()
+              .getQualifiers()
----------------
Anastasia wrote:
> Why do we need this change?
`__attribute__((address_space(n)))` is a target address space and not a 
language address space like `LangAS::opencl_generic`. Isn't 
`Qualifiers::getAddressSpaceAttributePrintValue()` meant exactly for this use 
case?


https://reviews.llvm.org/D38816



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to