[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun updated this revision to Diff 105153. vladimir.plyashkun added a subscriber: alexfh. vladimir.plyashkun added a comment. - moved test-case from separate file to existing one - fixed `No newline at end of file` problem and put space inside comment Repository: rL LLVM https:/

r307067 - [OpenCL] Rename err_opencl_enqueue_kernel_expected_type

Author: joey Date: Tue Jul 4 04:50:23 2017 New Revision: 307067 URL: http://llvm.org/viewvc/llvm-project?rev=307067&view=rev Log: [OpenCL] Rename err_opencl_enqueue_kernel_expected_type Rename err_opencl_enqueue_kernel_expected_type so that other builtins can use the same diagnostic. https://re

[PATCH] D34947: [clangd] Add support for per-file extra flags

ilya-biryukov added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:22 +return; + if (Command.CommandLine.empty()) +Command.CommandLine.push_back("clang"); If `Command.CommandLine.empty()` is true, extra flags will be added **before**

[PATCH] D34948: [OpenCL] Generalise err_opencl_enqueue_kernel_expected_type to be used with other builtins

bader added a comment. >> Do you have another built-in in mind which can use this diagnostic message? >> If so, it would make sense to re-use it in the same patch. > > This is split off from https://reviews.llvm.org/D33945, which I will be > rebasing/re-uploading once this patch is committed.

[clang-tools-extra] r307068 - ClangdServer.cpp: Suppress a warning. [-Wunused-lambda-capture]

Author: chapuni Date: Tue Jul 4 05:12:14 2017 New Revision: 307068 URL: http://llvm.org/viewvc/llvm-project?rev=307068&view=rev Log: ClangdServer.cpp: Suppress a warning. [-Wunused-lambda-capture] Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp Modified: clang-tools-extra/trunk/cl

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:385 + } + int getSizeS() const { return RootIds.size(); } + NodeId getIdInRoot(SNodeId Id) const { What's the purpose of the `S` prefix in the name of this method and a couple of othe

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:359 + + explicit SNodeId(int Id) : Id(Id){}; + explicit SNodeId() = default; NIT: This ';' is redundant. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:363 + operator i

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiffInternal.h:38 + operator int() const { return Id; } + NodeId &operator++() { return ++this->Id, *this; } + NodeId &operator--() { return --this->Id, *this; } NIT: You don't need `

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

andrewng added a comment. Hi, I believe that this "build mode" is intended for the Visual Studio MSVC build. This build is special in that it can produce builds for multiple configurations, e.g. Debug, Release & RelWithDebInfo, within the same top level build output directory. It is this confi

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 105161. johannes added a comment. - style fixes - correct getSimilarity() https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/AST

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

malhar1995 updated this revision to Diff 105160. malhar1995 added a comment. Herald added a subscriber: eraman. Changed function name from 'isAnnotatedToSkipDiagnostics' to 'isTrustedReferenceCountImplementation'. Added some test-cases to test/Analysis/retain-release-inline.m. Applied clang-forma

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. You can request commit access at http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. https://reviews.llvm.org/D34329 __

r307074 - [index] Index nested name qualifiers in a forward declaration of a

Author: arphaman Date: Tue Jul 4 05:50:53 2017 New Revision: 307074 URL: http://llvm.org/viewvc/llvm-project?rev=307074&view=rev Log: [index] Index nested name qualifiers in a forward declaration of a class template specialization rdar://33122110 Modified: cfe/trunk/lib/Index/IndexDecl.cpp

[PATCH] D34947: [clangd] Add support for per-file extra flags

ilya-biryukov added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:20 + const SmallVectorImpl &ExtraFlags) { + assert(Command && !Command->CommandLine.empty()); + if (!Command || ExtraFlags.empty()) Maybe pass `Comman

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34980: [OpenCL] Test on image access modifiers and image type can only be a type of a function argument.

echuraev created this revision. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D34980 Files: test/SemaOpenCL/images.cl Index: test/SemaOpenCL/images.cl === --- test/SemaOpenCL/images.cl +++ test/SemaOpenCL/images.cl

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. ping? https://reviews.llvm.org/D33589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: unittests/Tooling/DiagnosticsYamlTest.cpp:51 + + ASSERT_STREQ("---\n" +"MainSourceFile: path/to/source.cpp\n" EXPECT_STREQ is

[PATCH] D34981: RecursiveASTVisitor should visit the nested name qualifiers in a template specialisation

arphaman created this revision. Right now because of this issue rename cannot be initiated at name qualifiers in a template specialisation, e.g.: struct Outer { template struct Nested { }; }; template<> struct Outer::Nested; // Rename cannot be initiated at 'Outer' because

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: test/clang-tidy/modernize-make-shared-header.cpp:9 +// RUN: -- -std=c++11 \ +// RUN: -I%S/Inputs/modernize-smart-ptr + -

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

djasper added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:723 FormatDecision LastFormat = Node->State.NextToken->Decision; if (LastFormat == FD_Unformatted || LastFormat == FD_Continue) +addNextStateToQueue(Penalty, Node, /*NewLine=*/f

[PATCH] D33844: terminating continue check

alexfh added a comment. Please don't forget to add cfe-commits to `Subscribers:` when initially sending the patch for review. Otherwise nobody on the list will see it. Could you run the check on LLVM+Clang and post a summary of your findings here? https://reviews.llvm.org/D33844 ___

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

dcoughlin added a comment. Thanks for the tests. Have you tried this on the ISL codebase to make sure it is suppressing the diagnostics in related to reference counting implementation that you expect? I think it would be good to add some tests that reflect the reference counting implementation

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

v.g.vassilev updated this revision to Diff 105172. v.g.vassilev added a comment. Add test case. https://reviews.llvm.org/D34912 Files: lib/AST/TemplateBase.cpp test/SemaTemplate/temp_arg_nontype.cpp Index: test/SemaTemplate/temp_arg_nontype.cpp

[PATCH] D34947: [clangd] Add support for per-file extra flags

krasimir added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:20 + const SmallVectorImpl &ExtraFlags) { + assert(Command && !Command->CommandLine.empty()); + if (!Command || ExtraFlags.empty()) ilya-biryukov wrote: >

[PATCH] D34947: [clangd] Add support for per-file extra flags

krasimir updated this revision to Diff 105147. krasimir marked 7 inline comments as done. krasimir added a comment. - Addess review comments https://reviews.llvm.org/D34947 Files: clangd/ClangdLSPServer.cpp clangd/ClangdUnitStore.cpp clangd/GlobalCompilationDatabase.cpp clangd/GlobalCom

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. ping... Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34984 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp Index: lib/Serialization/ASTWriter.cpp ===

[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

v.g.vassilev added a subscriber: karies. v.g.vassilev added a comment. What would be the best way to test this. Shall we put: echo '#define LITERAL 42' > HEADER.h clang++ -std=c++14 -x c++-header -o HEADER.h.pch HEADER.h chmod a-r HEADER.h echo 'void f(int); void g() { f(12); }'

[PATCH] D34985: Do not read the file to determine its name.

v.g.vassilev created this revision. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34985 Files: lib/Basic/SourceManager.cpp Index: lib/Basic/SourceManager.cpp === --- lib/Basic/SourceManager.cpp +++ lib

[PATCH] D34985: Do not read the file to determine its name.

v.g.vassilev added a comment. The test case could be shared from PR33688: echo 'void* func(char* p) __attribute__((annotate("blah"))); void* func(char* p){return p;}' > HEADER.h clang++ -std=c++14 -x c++-header -o HEADER.h.pch HEADER.h chmod a-r HEADER.h echo 'char i; void

r307087 - clang-format: [JS] space between pseudo keywords and template literals.

Author: mprobst Date: Tue Jul 4 08:30:21 2017 New Revision: 307087 URL: http://llvm.org/viewvc/llvm-project?rev=307087&view=rev Log: clang-format: [JS] space between pseudo keywords and template literals. Summary: Before: yield`foo`; After: yield `foo`; This reinstates commit 71d3b5cd91 /

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

What about the import side? On Mon, Jul 3, 2017 at 10:37 PM Shoaib Meenai via Phabricator via cfe-commits wrote: > smeenai created this revision. > > Under Windows Itanium, we need to export virtual and non-virtual thunks > if the functions being thunked are exported. These thunks would > previo

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

vladimir.plyashkun added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:23 + SmallVector EmptyNotes; + return tooling::Diagnostic(DiagnosticName, Message, Replacements, EmptyNotes, + tooling::Diagnostic::War

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

vladimir.plyashkun added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:18 + +static tooling::Diagnostic makeDiagnostic(const StringRef DiagnosticName, + DiagnosticMessage &Message, --

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

malhar1995 updated this revision to Diff 105186. malhar1995 added a comment. Added relevant test-cases to verify the added functionality. Repository: rL LLVM https://reviews.llvm.org/D34937 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp test/Analysis/retain-release-inline.m I

[PATCH] D34987: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space

yaxunl created this revision. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. Currently AMDGPUTargetInfo does not initialize AddrSpaceMap in constructor, which causes regressions in mesa/clover with libclc. This patch fixes that. https://reviews.llvm.org/D34987 Files: lib/B

[PATCH] D34987: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space

yaxunl updated this revision to Diff 105189. yaxunl added a comment. Fix typo. https://reviews.llvm.org/D34987 Files: lib/Basic/Targets.cpp test/CodeGenOpenCL/address-spaces.cl Index: test/CodeGenOpenCL/address-spaces.cl ===

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

hokein updated this revision to Diff 105190. hokein marked 2 inline comments as done. hokein added a comment. Fix small nits. https://reviews.llvm.org/D34206 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h docs/clang-tidy/checks/modernize-make-sh

[PATCH] D34913: [clang-tidy] Add a new Android check "android-cloexec-socket"

hokein added inline comments. Comment at: clang-tidy/utils/CloexecFlagChecker.h:21 +/// specific macro flag in a given argument. +bool hasCloseOnExecFlag(const Expr *Flags, const SourceManager &SM, +const LangOptions &LangOpts, Maybe put t

[PATCH] D34980: [OpenCL] Test on image access modifiers and image type can only be a type of a function argument.

Anastasia added inline comments. Comment at: test/SemaOpenCL/images.cl:14 +void myReadWrite (read_write image2d_t); +void myIndifferent (image2d_t); // expected-note 2{{passing argument to parameter here}} + Would it be better to rename to make the purpose more

[PATCH] D34987: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space

awatry accepted this revision. awatry added a comment. This revision is now accepted and ready to land. FWIW, this looks ok to me. Just as importantly, this fixes the address space mapping regressions for both r600 (BARTS) and GCN/AMDGPU (PITCAIRN) for me. https://reviews.llvm.org/D34987 __

r307104 - Enable LLVM asan support for NetBSD/amd64

Author: kamil Date: Tue Jul 4 12:55:56 2017 New Revision: 307104 URL: http://llvm.org/viewvc/llvm-project?rev=307104&view=rev Log: Enable LLVM asan support for NetBSD/amd64 Summary: Enable LLVM asan sanitizer for NetBSD/amd64. Don't generate -ldl for dlopen(3)-like functions on NetBSD. These fe

r307105 - [AMDGPU] Fix regressions on mesa/clover with libclc due to address space

Author: yaxunl Date: Tue Jul 4 12:57:18 2017 New Revision: 307105 URL: http://llvm.org/viewvc/llvm-project?rev=307105&view=rev Log: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space Currently AMDGPUTargetInfo does not initialize AddrSpaceMap in constructor, which causes r

[PATCH] D34987: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space

This revision was automatically updated to reflect the committed changes. Closed by commit rL307105: [AMDGPU] Fix regressions on mesa/clover with libclc due to address space (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D34987?vs=105189&id=105196#toc Repository: rL

[PATCH] D34475: [RFC] [AArch64] Add support for __builtin_ms_va_list on aarch64

mstorsjo updated this revision to Diff 105200. mstorsjo added a comment. Did a minor adjustment, to make sure a plain va_arg produces the right kind of output, when targeting windows directly (while the rest of the patch mostly is about supporting the MS ABI while targeting a different OS). ht

[PATCH] D34992: Emit static constexpr member as available_externally definition

mehdi_amini created this revision. This enables better optimization, I don't if it is legal c++11 though. https://reviews.llvm.org/D34992 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp Index: clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp ===

r307115 - [modules ts] Declarations from a module interface unit are only visible outside

Author: rsmith Date: Tue Jul 4 18:42:07 2017 New Revision: 307115 URL: http://llvm.org/viewvc/llvm-project?rev=307115&view=rev Log: [modules ts] Declarations from a module interface unit are only visible outside the module if declared in an export block. Added: cfe/trunk/test/CXX/modules-ts

Re: [PATCH v3] [PPC64]: Add support for Swift calling convention

Ping - is anyone able to provide feedback? Cheers, Andrew On Thu, 2017-06-22 at 16:02 +0930, Andrew Jeffery wrote: > For the tests I've extracted the int5 and int8 cases to cater for > different alignments for different platform ABIs. For Linux on POWER the > 5 and 8 element vectors must be natu

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi updated this revision to Diff 105209. yamaguchi added a comment. Fixed typo. https://reviews.llvm.org/D34770 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/autocomplete.c clang/utils/bash-autocomplete.sh llvm/include/llvm/Option/OptTable.h llvm/lib/Option/OptTable.cpp

[PATCH] D34927: [Bash-autocompletion] Fix a bug that -foo=bar doesn't handled properly

yamaguchi updated this revision to Diff 105208. yamaguchi added a comment. Update diff. Thanks for the pointing out. https://reviews.llvm.org/D34927 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh ==

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

yamaguchi added a comment. We are going to ask community which flags should be autocompleted or not, and tidy Options.td. https://reviews.llvm.org/D34930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified

yamaguchi added inline comments. Comment at: clang/utils/bash-autocomplete.sh:16 + if [[ "${COMP_WORDS[1]}" == "-cc1" || "$w1" == "-Xclang" ]]; then +arg="#" + fi compnerd wrote: > `prefix` may be a better term? Thanks for reviewing! $arg has string like `-

[PATCH] D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID

This revision was automatically updated to reflect the committed changes. Closed by commit rL307116: [Bash-autocompletion] Show flags which has HelpText or GroupID (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D34930?vs=105017&id=105211#toc Repository: rL LLVM h

[libcxx] r307117 - Implement LWG 2937 - equivalent("dne", "exists") is not an error

Author: ericwf Date: Tue Jul 4 20:37:05 2017 New Revision: 307117 URL: http://llvm.org/viewvc/llvm-project?rev=307117&view=rev Log: Implement LWG 2937 - equivalent("dne", "exists") is not an error This patch speculatively implements the PR for LWG 2937, which fixes two issues with equivalent. (

[libcxx] r307118 - Add dummy CMake target for *.pass.cpp tests when LIBCXX_CONFIGURE_IDE=ON.

Author: ericwf Date: Tue Jul 4 20:50:03 2017 New Revision: 307118 URL: http://llvm.org/viewvc/llvm-project?rev=307118&view=rev Log: Add dummy CMake target for *.pass.cpp tests when LIBCXX_CONFIGURE_IDE=ON. In order for IDE's like CLion to correctly parse and highlight the tests it needs to know

[libcxx] r307119 - Fix equivalent test on OS X and FreeBSD

Author: ericwf Date: Tue Jul 4 20:54:38 2017 New Revision: 307119 URL: http://llvm.org/viewvc/llvm-project?rev=307119&view=rev Log: Fix equivalent test on OS X and FreeBSD Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.equivalent/equivalent.pass.cpp Modified: li

[PATCH] D34995: [AMDGPU] Fix size and alignment of size_t and pointer types

yaxunl created this revision. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. This patch is split from https://reviews.llvm.org/D33842 https://reviews.llvm.org/D34995 Files: lib/Basic/Targets.cpp test/CodeGen/default-address-space.c test/CodeGenCXX/amdgcn-automa

[PATCH] D34995: [AMDGPU] Fix size and alignment of size_t and pointer types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D34995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

r307121 - [AMDGPU] Fix size and alignment of size_t and pointer types

Author: yaxunl Date: Tue Jul 4 21:58:24 2017 New Revision: 307121 URL: http://llvm.org/viewvc/llvm-project?rev=307121&view=rev Log: [AMDGPU] Fix size and alignment of size_t and pointer types Differential Revision: https://reviews.llvm.org/D34995 Added: cfe/trunk/test/CodeGenOpenCL/amdgpu-s

[PATCH] D34995: [AMDGPU] Fix size and alignment of size_t and pointer types

This revision was automatically updated to reflect the committed changes. Closed by commit rL307121: [AMDGPU] Fix size and alignment of size_t and pointer types (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D34995?vs=105213&id=105215#toc Repository: rL LLVM https:/

r307123 - fix trivial typos in comments; NFC

Author: inouehrs Date: Tue Jul 4 22:37:45 2017 New Revision: 307123 URL: http://llvm.org/viewvc/llvm-project?rev=307123&view=rev Log: fix trivial typos in comments; NFC Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/Sema/SemaLambda.cpp Modified: cfe/trunk/lib/AST/ExprConstan

[PATCH] D34980: [OpenCL] Test on image access modifiers and image type can only be a type of a function argument.

echuraev updated this revision to Diff 105218. echuraev marked 6 inline comments as done. https://reviews.llvm.org/D34980 Files: test/SemaOpenCL/images.cl Index: test/SemaOpenCL/images.cl === --- test/SemaOpenCL/images.cl +++ tes

r307129 - [modules ts] Improve merging of module-private declarations.

Author: rsmith Date: Wed Jul 5 00:47:11 2017 New Revision: 307129 URL: http://llvm.org/viewvc/llvm-project?rev=307129&view=rev Log: [modules ts] Improve merging of module-private declarations. These cases occur frequently for declarations in the global module (above the module-declaration) in a

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL307130: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique… (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D34206 Files: clang-tools-extra/trunk/clang

[clang-tools-extra] r307130 - [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

Author: hokein Date: Wed Jul 5 00:49:00 2017 New Revision: 307130 URL: http://llvm.org/viewvc/llvm-project?rev=307130&view=rev Log: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks. Reviewers: alexfh, aaron.ballman Reviewed By: alexfh Subscribers: JDevlieg

[PATCH] D32914: Introduce Wzero-as-null-pointer-constant.

lebedev.ri added a comment. @thakis ping? https://reviews.llvm.org/D32914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

echuraev created this revision. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D35000 Files: test/CodeGenOpenCL/kernel-arg-info.cl Index: test/CodeGenOpenCL/kernel-arg-info.cl === --- test/CodeGenOpenCL/kernel-arg-in

[PATCH] D34985: Do not read the file to determine its name.

karies added a comment. To be clear: emitting annotations will trigger the determination of `PresumedLoc`s. As part of that (but not the first part, IIRC) `SourceManager::getBufferName(()` will be called which will trigger the `fopen` of the file, just to get its name. Another task of `Presume

r307134 - Fix invalid warnings for header guards in preambles

Author: erikjv Date: Wed Jul 5 02:44:07 2017 New Revision: 307134 URL: http://llvm.org/viewvc/llvm-project?rev=307134&view=rev Log: Fix invalid warnings for header guards in preambles Fixes https://bugs.llvm.org/show_bug.cgi?id=33574 Differential Revision: https://reviews.llvm.org/D34882 Modi

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

vladimir.plyashkun updated this revision to Diff 105240. vladimir.plyashkun added a comment. - use `EXPECT_*` instead of `ASSERT_*` where it's possible - `Diagnostic` constructor now takes `const` references for it's arguments - removed extra namespace qualifiers Repository: rL LLVM https://r

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. On windows on arm64, the va_list is a plain pointer. https://reviews.llvm.org/D35008 Files: lib/CodeGen/TargetInfo.cpp Index: lib/CodeGen/TargetInfo.cpp =

r307143 - Add const to reference arguments of Diagnostic ctor

Author: alexfh Date: Wed Jul 5 04:45:09 2017 New Revision: 307143 URL: http://llvm.org/viewvc/llvm-project?rev=307143&view=rev Log: Add const to reference arguments of Diagnostic ctor Modified: cfe/trunk/include/clang/Tooling/Core/Diagnostic.h cfe/trunk/lib/Tooling/Core/Diagnostic.cpp M

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

alexfh added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:23 + SmallVector EmptyNotes; + return tooling::Diagnostic(DiagnosticName, Message, Replacements, EmptyNotes, + tooling::Diagnostic::Warning, BuildD

[PATCH] D34475: [RFC] [AArch64] Add support for __builtin_ms_va_list on aarch64

mstorsjo updated this revision to Diff 105254. mstorsjo edited the summary of this revision. mstorsjo added reviewers: mgrang, t.p.northover. mstorsjo added a comment. Split the patch into two; one for generic handling of va_arg for win/arm64, and one for using the same functionality while target

r307147 - [clang-format] Fix an uninitialized memory access

Author: krasimir Date: Wed Jul 5 05:24:01 2017 New Revision: 307147 URL: http://llvm.org/viewvc/llvm-project?rev=307147&view=rev Log: [clang-format] Fix an uninitialized memory access Modified: cfe/trunk/lib/Format/FormatToken.h Modified: cfe/trunk/lib/Format/FormatToken.h URL: http://llvm

[PATCH] D34947: [clangd] Add support for per-file extra flags

krasimir updated this revision to Diff 105257. krasimir marked 2 inline comments as done. krasimir added a comment. - Addess review comments https://reviews.llvm.org/D34947 Files: clangd/ClangdLSPServer.cpp clangd/ClangdUnitStore.cpp clangd/GlobalCompilationDatabase.cpp clangd/GlobalCom

[PATCH] D34947: [clangd] Add support for per-file extra flags

ilya-biryukov added a comment. I forgot to submit this last comment yesterday, sorry about that. Comment at: clangd/GlobalCompilationDatabase.h:51 + void addExtraFlagsForFile(PathRef File, std::vector ExtraFlags); + Maybe rename to `setExtraFlagsForFile`? Th

r307151 - [driver][mips] Remove redundant curly brackets. NFC

Author: atanasyan Date: Wed Jul 5 05:57:32 2017 New Revision: 307151 URL: http://llvm.org/viewvc/llvm-project?rev=307151&view=rev Log: [driver][mips] Remove redundant curly brackets. NFC Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Arch/M

r307152 - [driver][mips] Use AddTargetFeature to check arguments and add feature flags. NFC

Author: atanasyan Date: Wed Jul 5 05:57:37 2017 New Revision: 307152 URL: http://llvm.org/viewvc/llvm-project?rev=307152&view=rev Log: [driver][mips] Use AddTargetFeature to check arguments and add feature flags. NFC Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp Modified: cfe/tru

r307156 - [SystemZ] Simplify handling of ISA revisions

Author: uweigand Date: Wed Jul 5 06:19:47 2017 New Revision: 307156 URL: http://llvm.org/viewvc/llvm-project?rev=307156&view=rev Log: [SystemZ] Simplify handling of ISA revisions This moves determination of the ISA revision from the CPU name to one single place, removing a bunch of duplicated co

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

vladimir.plyashkun updated this revision to Diff 105260. vladimir.plyashkun added a comment. - marked some arguments as `const` - use `{}` instead of explicit variable declarations Repository: rL LLVM https://reviews.llvm.org/D34404 Files: include/clang/Tooling/DiagnosticsYaml.h unittest

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

vladimir.plyashkun added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:23 + SmallVector EmptyNotes; + return tooling::Diagnostic(DiagnosticName, Message, Replacements, EmptyNotes, + tooling::Diagnostic::War

[PATCH] D34913: [clang-tidy] Add a new Android check "android-cloexec-socket"

alexfh requested changes to this revision. alexfh added inline comments. Comment at: test/clang-tidy/android-cloexec-socket.cpp:20 + // CHECK-MESSAGES: :[[@LINE-1]]:24: warning: 'socket' should use SOCK_CLOEXEC where possible [android-cloexec-socket] + // CHECK-FIXES: SOCK_STR

Re: r304207 - Allow for unfinished #if blocks in preambles

> On 30. Jun 2017, at 16:31, Erik Verbruggen via cfe-commits > wrote: > > >> On 23. Jun 2017, at 23:54, Richard Smith > > wrote: >> >> On 23 June 2017 at 13:34, Benjamin Kramer via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Since this change we

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-default-numerics.cpp:28 +struct numeric_limits { + static int min() { return -1; } + static SpecializedType max() { return SpecializedType(); } This is not a proper specialization according t

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

dcoughlin added a comment. Thanks for the tests. Have you tried this on the ISL codebase to make sure it is suppressing the diagnostics in related to reference counting implementation that you expect? I think it would be good to add some tests that reflect the reference counting implementation

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

malhar1995 added a comment. In https://reviews.llvm.org/D34937#799504, @dcoughlin wrote: > Thanks for the tests. > > Have you tried this on the ISL codebase to make sure it is suppressing the > diagnostics in related to reference counting implementation that you expect? > > I think it would be g

[PATCH] D35012: [refactor] Add the AST source selection component

arphaman created this revision. Herald added a subscriber: mgorny. This patch adds the base AST source selection component to the refactoring library. AST selection is represented using a tree of `SelectedASTNode` values. Each selected node gets its own selection kind, which can actually be `Non

[PATCH] D35012: [refactor] Add the AST source selection component

arphaman updated this revision to Diff 105269. arphaman added a comment. A a test-case for implicit declarations. Repository: rL LLVM https://reviews.llvm.org/D35012 Files: include/clang/Tooling/Refactoring/ASTSelection.h lib/Tooling/Refactoring/ASTSelection.cpp lib/Tooling/Refactoring

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

alexfh added a comment. A few more nits. Comment at: unittests/Tooling/DiagnosticsYamlTest.cpp:39 + + StringMap Fix1{ +{ "path/to/source.cpp", Replacements(Replacement("path/to/source.cpp", 100, The assignment form of initialization is clearer for containe

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

vladimir.plyashkun added a comment. Thanks, Alex for your suggestions. I agree with your remarks, but i thought it's only style preferences. I'll fix it soon. Repository: rL LLVM https://reviews.llvm.org/D34404 ___ cfe-commits mailing list cfe-co

[PATCH] D34170: [libcxx] Moving compiler specific test infrastructure to compiler.py

bcraig updated this revision to Diff 105268. bcraig added a comment. Rebased. Separating out logging into it's own class. Also tweaked the output slightly so that the language dialect under test shows up as the first line of output. https://reviews.llvm.org/D34170 Files: test/lit.cfg utils

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:380 +if (Verbose.getNumOccurrences() != 0) +outs() << "Formatting " << FileNames[0] << '\n'; break; djasper wrote: > As clang-format often returns the result on

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: run-clang-tidy.py:49 +import yaml +import glob Please sort the imports Comment at: run-clang-tidy.py:99 +

[PATCH] D34440: [Clang] Expand response files before loading compilation database

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: lib/Tooling/CommonOptionsParser.cpp:120 + + // Expand response files before loading compilation database from command line + SmallVector newArg

[PATCH] D34888: [OpenMP] Fix mapping of scalars for combined directives

gtbercea added a comment. Does this also include the fixes in the following revision? https://reviews.llvm.org/D29905 Repository: rL LLVM https://reviews.llvm.org/D34888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D34936: [clangd] Add -ffreestanding on VFS tests.

mibintc added a comment. Thanks so much! Repository: rL LLVM https://reviews.llvm.org/D34936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34170: [libcxx] Moving compiler specific test infrastructure to compiler.py

EricWF added a comment. I'll try and get to this tonight. https://reviews.llvm.org/D34170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34992: Emit static constexpr member as available_externally definition

arphaman added a comment. Does this apply to all constexpr global variables? It could potentially fix https://bugs.llvm.org/show_bug.cgi?id=31860 . https://reviews.llvm.org/D34992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

  1   2   3   >