vladimir.plyashkun added inline comments.
================ Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:23 + SmallVector<DiagnosticMessage, 1> EmptyNotes; + return tooling::Diagnostic(DiagnosticName, Message, Replacements, EmptyNotes, + tooling::Diagnostic::Warning, BuildDirectory); ---------------- alexfh wrote: > alexfh wrote: > > Will `{}` work instead of `EmptyNotes`? > `tooling::` is not needed due to the using directive above. Same below. Unfortunately, no. Constructor expects non-const reference `SmallVector<DiagnosticMessage, 1> &Notes`, so i can't pass rvalue directly to it. Repository: rL LLVM https://reviews.llvm.org/D34404 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits