ilya-biryukov added a comment. I forgot to submit this last comment yesterday, sorry about that.
================ Comment at: clangd/GlobalCompilationDatabase.h:51 + void addExtraFlagsForFile(PathRef File, std::vector<std::string> ExtraFlags); + ---------------- Maybe rename to `setExtraFlagsForFile`? The name `addExtraFlags...` sounds like it appends to the existing list, but we actually replace the flags there. https://reviews.llvm.org/D34947 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
