[PATCH] D32825: [clang-format] Improve understanding of combined typedef+record declarations

jtbandes added a comment. Ping :) https://reviews.llvm.org/D32825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32350: [Analyzer] Exception Checker

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ExceptionMisuseChecker.cpp:80 + bool WasReThrow; + Types CurrentThrows; // actually alive exceptions + FunctionExceptionsMap There are some comment formatting issues along these lines.

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

xazax.hun added a comment. Looks good for me, I only have a few questions. Could you reupload the diff with contexts? It might make the review easier for others. Comment at: lib/AST/ASTImporter.cpp:1311 + EmptyDecl *ToD = EmptyDecl::Create(Importer.getToContext(), DC, Loc); +

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

xazax.hun added a comment. Do you have a benchmark how this affects the performance and memory usage when the old constraint manager is used? I wonder if most of people are using the old one, it might make no sense to generate symbolic expressions that can not be solved anyway. Maybe the analyz

[PATCH] D32350: [Analyzer] Exception checker for misuse: uncaught/noncompliant throws

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ExceptionMisuseChecker.cpp:105 + ReportExnSpec(ReportExnSpec) { + // In the beginning we have to parse list formatted options + SmallVector EnabledFuncsVec; All comments should be ful

[PATCH] D32543: [X86] Clang option -fuse-init-array has no effect when generating for MCU target

This revision was automatically updated to reflect the committed changes. Closed by commit rL302513: [X86] Clang option -fuse-init-array has no effect when generating for MCU target (authored by n.bozhenov). Changed prior to commit: https://reviews.llvm.org/D32543?vs=97866&id=98262#toc Reposit

[PATCH] D31588: Fix PR25627: Certain constant local variables must be usable as template arguments (without being odr-used)

faisalv added a comment. *ping* https://reviews.llvm.org/D31588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/CodeGen/mips-aggregate-arg.c:3 +// RUN: %clang_cc1 -triple mips64el-unknown-linux-gnu -S -emit-llvm -o - %s -target-abi n32 | FileCheck -check-pref

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

sdardis added a comment. Spotted a minor nit. Comment at: test/CodeGen/mips-aggregate-arg.c:36 + f2(g2); + f3(g3); +} Nit: spurious whitespace here. https://reviews.llvm.org/D32900 ___ cfe-commits mailing lis

[clang-tools-extra] r302516 - docs: Fix Sphinx detection with out-of-tree builds

Author: tstellar Date: Tue May 9 06:11:52 2017 New Revision: 302516 URL: http://llvm.org/viewvc/llvm-project?rev=302516&view=rev Log: docs: Fix Sphinx detection with out-of-tree builds Adapt to changes made in r302499. Modified: clang-tools-extra/trunk/docs/CMakeLists.txt Modified: clang-t

[libcxx] r302517 - docs: Fix Sphinx detection with out-of-tree builds

Author: tstellar Date: Tue May 9 06:18:03 2017 New Revision: 302517 URL: http://llvm.org/viewvc/llvm-project?rev=302517&view=rev Log: docs: Fix Sphinx detection with out-of-tree builds Adapt to changes made in r302499. Modified: libcxx/trunk/docs/CMakeLists.txt Modified: libcxx/trunk/docs/

r302518 - Reland "Warn about unused static file scope function template declarations."

Author: vvassilev Date: Tue May 9 06:25:41 2017 New Revision: 302518 URL: http://llvm.org/viewvc/llvm-project?rev=302518&view=rev Log: Reland "Warn about unused static file scope function template declarations." This patch reinstates r299930, reverted in r299956, as a separate diagnostic option

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Relanded in r302518. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

smaksimovic updated this revision to Diff 98269. smaksimovic added a comment. Herald added a subscriber: krytarowski. Thanks, fixed. https://reviews.llvm.org/D32900 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/mips-aggregate-arg.c Index: test/CodeGen/mips-aggregate-arg.c ===

[PATCH] D32997: clang-format: [JS] keep triple slash directives intact.

mprobst created this revision. Herald added a subscriber: klimek. TypeScript uses triple slash directives of the form: /// For various non-source instructions that should not be wrapped. Reference: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html https://reviews.ll

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

alexfh added a comment. Paweł, are you planning to finish this patch? https://reviews.llvm.org/D30748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302521 - PR5935: Adjust documentation.

Author: vvassilev Date: Tue May 9 07:37:15 2017 New Revision: 302521 URL: http://llvm.org/viewvc/llvm-project?rev=302521&view=rev Log: PR5935: Adjust documentation. https://reviews.llvm.org/D31867 Patch by Johannes Altmanninger! Modified: cfe/trunk/include/clang/Basic/TargetOptions.h Modi

[clang-tools-extra] r302522 - [clang-tidy] Minor cleanup + a disabled test case for PR26228. NFC

Author: alexfh Date: Tue May 9 07:41:11 2017 New Revision: 302522 URL: http://llvm.org/viewvc/llvm-project?rev=302522&view=rev Log: [clang-tidy] Minor cleanup + a disabled test case for PR26228. NFC Modified: clang-tools-extra/trunk/clang-tidy/readability/BracesAroundStatementsCheck.cpp

[PATCH] D32997: clang-format: [JS] keep triple slash directives intact.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D32997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r302521. https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32997: clang-format: [JS] keep triple slash directives intact.

This revision was automatically updated to reflect the committed changes. Closed by commit rL302523: clang-format: [JS] keep triple slash directives intact. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D32997?vs=98270&id=98272#toc Repository: rL LLVM https://revi

r302523 - clang-format: [JS] keep triple slash directives intact.

Author: mprobst Date: Tue May 9 07:45:48 2017 New Revision: 302523 URL: http://llvm.org/viewvc/llvm-project?rev=302523&view=rev Log: clang-format: [JS] keep triple slash directives intact. Summary: TypeScript uses triple slash directives of the form: /// For various non-source instructions

[PATCH] D32989: Don't indent JavaScript IIFEs

mprobst added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2346 +bool UnwrappedLineParser::isIIFE() const { + // Look for the start of an immediately invoked anonymous function. Why not just a static function? Comment at:

[PATCH] D32989: Don't indent JavaScript IIFEs

mprobst added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2362 + ++I; + if (I->Tok->isNot(tok::l_paren)) +return false; One more - do we want to support IIFEs that take arguments? ``` (function(global) { ... }(window)); ``` https:/

Re: [PATCH] D29877: Warn about unused static file scope function template declarations.

On 11/04/17 22:25, Richard Smith wrote: On 11 April 2017 at 08:35, Marshall Clow via Phabricator via cfe-commits > wrote: mclow.lists added a comment. Complete reproducer: // Tested with with: clang++ -std=c++14 -Wunused-function UnusedFVass

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware updated this revision to Diff 98275. baloghadamsoftware marked 11 inline comments as done. baloghadamsoftware added a comment. Updated according to the review. https://reviews.llvm.org/D32592 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Chec

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware added a comment. In https://reviews.llvm.org/D32592#747132, @NoQ wrote: > Then, in methods that deal with iterator `SVal`s directly, i wish we had > hints explaining what's going on in these ~7 cases. In my opinion, that'd > greatly help people understand the code later, and

[PATCH] D33000: Add support for pretty platform names to `@available`/`__builtin_available`

arphaman created this revision. We should allow macOS/iOS/tvOS/watchOS in `@available`/`__builtin_available`. Repository: rL LLVM https://reviews.llvm.org/D33000 Files: include/clang/Basic/Attr.td lib/Parse/ParseExpr.cpp lib/Sema/SemaDeclAttr.cpp test/FixIt/fixit-availability.c tes

[PATCH] D33000: Add support for pretty platform names to `@available`/`__builtin_available`

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks for working on this! Repository: rL LLVM https://reviews.llvm.org/D33000 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r302534 - Change EOL style to LF. NFC

Author: alexfh Date: Tue May 9 09:56:28 2017 New Revision: 302534 URL: http://llvm.org/viewvc/llvm-project?rev=302534&view=rev Log: Change EOL style to LF. NFC Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/trunk/clang-tidy/misc/ForwardingR

[PATCH] D33004: getIdentifierInfo now updates the returned information by default

teemperor created this revision. Calling `Preprocessor::getIdentifierInfo` is not automatically updating the returned identifier at the moment. This patch adds a flag that is ensuring by default that the returned IdentifierInfo is updated. The flag is true by default because that seems like the

[PATCH] D33004: getIdentifierInfo now updates the returned information by default

teemperor planned changes to this revision. teemperor added a comment. Work in progress patch. We probably also need to update a few other places where we call this. https://reviews.llvm.org/D33004 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang-tools-extra] r302536 - [clang-tidy] Allow disabling compatibility check for generated fixes.

Author: alexfh Date: Tue May 9 10:10:26 2017 New Revision: 302536 URL: http://llvm.org/viewvc/llvm-project?rev=302536&view=rev Log: [clang-tidy] Allow disabling compatibility check for generated fixes. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-too

r302540 - Add support for pretty platform names to `@available`/

Author: arphaman Date: Tue May 9 10:34:46 2017 New Revision: 302540 URL: http://llvm.org/viewvc/llvm-project?rev=302540&view=rev Log: Add support for pretty platform names to `@available`/ `__builtin_available` This commit allows us to use the macOS/iOS/tvOS/watchOS platform names in `@available

[PATCH] D33000: Add support for pretty platform names to `@available`/`__builtin_available`

This revision was automatically updated to reflect the committed changes. Closed by commit rL302540: Add support for pretty platform names to `@available`/ (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D33000?vs=98276&id=98297#toc Repository: rL LLVM https://revi

r302542 - Revert r302476 "Update testcase for upstream LLVM changes."

Author: hans Date: Tue May 9 10:55:39 2017 New Revision: 302542 URL: http://llvm.org/viewvc/llvm-project?rev=302542&view=rev Log: Revert r302476 "Update testcase for upstream LLVM changes." That test update was for r302469, which was reverted in r302533 due to PR32977. Modified: cfe/trunk/t

[PATCH] D32988: [libc++] Refactor Windows support headers.

bcraig added inline comments. Comment at: include/__config:232-235 +#ifndef NOMINMAX +#define NOMINMAX +#endif + I can see this helping when we are build libc++, but I don't think it helps client apps. They could have included windows.h before including our hea

r302545 - [CodeCompletion] Complete platform names in @available expressions

Author: arphaman Date: Tue May 9 11:05:04 2017 New Revision: 302545 URL: http://llvm.org/viewvc/llvm-project?rev=302545&view=rev Log: [CodeCompletion] Complete platform names in @available expressions rdar://32074504 Added: cfe/trunk/test/Index/complete-available.m Modified: cfe/trunk/i

[PATCH] D32972: [index] Index simple dependent declaration references

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. A couple of minor comments, but otherwise LGTM. Comment at: include/clang/AST/DeclCXX.h:1569 + bool lookupInBases(BaseMatchesCallback BaseMatches, CXXBasePaths &Pa

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington added a comment. Ping! @mclow.lists: Do you have any thoughts here? https://reviews.llvm.org/D30837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

This revision was automatically updated to reflect the committed changes. Closed by commit rL302547: [mips] Impose a threshold for coercion of aggregates (authored by petarj). Changed prior to commit: https://reviews.llvm.org/D32900?vs=98269&id=98304#toc Repository: rL LLVM https://reviews.

r302547 - [mips] Impose a threshold for coercion of aggregates

Author: petarj Date: Tue May 9 11:24:03 2017 New Revision: 302547 URL: http://llvm.org/viewvc/llvm-project?rev=302547&view=rev Log: [mips] Impose a threshold for coercion of aggregates Modified MipsABIInfo::classifyArgumentType so that it now coerces aggregate structures only if the size of said

[PATCH] D31839: make -Winteger-overflow find overflows in function arguments

nlewycky added a comment. Ping! https://reviews.llvm.org/D31839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl updated this revision to Diff 98314. yaxunl added a comment. Revised by reviewers' comments. https://reviews.llvm.org/D32248 Files: include/clang/AST/Type.h lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenTypes.cpp lib/CodeGen/TargetInfo.cpp lib/CodeGen/TargetInfo.h test/CodeGen/ad

[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Let's go ahead with this. I've been unable to find a testcase that triggers the problem, but we shouldn't keep a known latent bug around just because we don't know how to expose it yet. http

[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

dexonsmith added a comment. In https://reviews.llvm.org/D32724#747728, @aprantl wrote: > Is it the right solution to use the module hash for correctness, or should > the mismatch of the serialized langopts trigger a module rebuild and the > module hash is only there to tune the performance/disk

Re: r302547 - [mips] Impose a threshold for coercion of aggregates

On Tue, May 9, 2017 at 9:24 AM, Petar Jovanovic via cfe-commits wrote: > Author: petarj > Date: Tue May 9 11:24:03 2017 > New Revision: 302547 > > URL: http://llvm.org/viewvc/llvm-project?rev=302547&view=rev > Log: > [mips] Impose a threshold for coercion of aggregates > > Modified MipsABIInfo::c

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This makes a lot of sense to me. See also r302463: I think we probably want three levels of shadowing here: the main input shadows -fmodule-map-file, which shadows module maps loaded implicitl

r302555 - Revert r302547 ([mips] Impose a threshold for coercion of aggregates)

Author: petarj Date: Tue May 9 12:20:06 2017 New Revision: 302555 URL: http://llvm.org/viewvc/llvm-project?rev=302555&view=rev Log: Revert r302547 ([mips] Impose a threshold for coercion of aggregates) Reverting Modified MipsABIInfo::classifyArgumentType so that it now coerces aggregate stru

RE: r302547 - [mips] Impose a threshold for coercion of aggregates

Reverted in r302555. From: hwennb...@google.com [hwennb...@google.com] on behalf of Hans Wennborg [h...@chromium.org] Sent: Tuesday, May 09, 2017 7:18 PM To: Petar Jovanovic Cc: cfe-commits Subject: Re: r302547 - [mips] Impose a threshold for coercion of ag

[PATCH] D32603: Build the Apple-style stage2 with modules and full debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL302556: Build the Apple-style stage2 with modules (authored by adrian). Changed prior to commit: https://reviews.llvm.org/D32603?vs=96952&id=98320#toc Repository: rL LLVM https://reviews.llvm.org/D3

r302556 - Build the Apple-style stage2 with modules

Author: adrian Date: Tue May 9 12:27:03 2017 New Revision: 302556 URL: http://llvm.org/viewvc/llvm-project?rev=302556&view=rev Log: Build the Apple-style stage2 with modules Green dragon had a green stage2 modules bot for a long time now[1] and it is time to retire it and make a modules build th

r302557 - [X86][LWP] Removing LWP todo comment. NFCI.

Author: rksimon Date: Tue May 9 12:43:16 2017 New Revision: 302557 URL: http://llvm.org/viewvc/llvm-project?rev=302557&view=rev Log: [X86][LWP] Removing LWP todo comment. NFCI. LWP / lwpintrin.h is now supported Modified: cfe/trunk/lib/Headers/x86intrin.h Modified: cfe/trunk/lib/Headers/x8

r302558 - [WebAssembly] Fix location and -flavor when running lld

Author: sbc Date: Tue May 9 12:47:50 2017 New Revision: 302558 URL: http://llvm.org/viewvc/llvm-project?rev=302558&view=rev Log: [WebAssembly] Fix location and -flavor when running lld Add the toolchain installation directory to the program path so that lld can be found. Change -flavor to wasm.

r302559 - [X86][LWP] Remove MSVC LWP intrinsics stubs.

Author: rksimon Date: Tue May 9 12:50:16 2017 New Revision: 302559 URL: http://llvm.org/viewvc/llvm-project?rev=302559&view=rev Log: [X86][LWP] Remove MSVC LWP intrinsics stubs. Now provided in lwpintrin.h Modified: cfe/trunk/lib/Headers/intrin.h Modified: cfe/trunk/lib/Headers/intrin.h UR

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); ---

[PATCH] D32897: [OpenCL] Added checking OpenCL version for cl_khr_mipmap_image built-ins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! It's a pity we are not testing anything here. https://reviews.llvm.org/D32897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32898: [OpenCL] Handle OpenCL specific subelement types

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: test/SemaOpenCL/array-init.cl:4 + +__kernel void k2(queue_t q1, queue_t q2) { + queue_t q[] = {q1, q2}; Minor thing - I would use sequ

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

aprantl added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:3814 + } else // TypeAliasTemplateDecl +assert(0 && "TypeAliasTemplateDecl doesn't have specs!"); +} llvm_unreachable() Repository: rL LLVM https://reviews.llvm.o

[PATCH] D33013: Driver must return non-zero code on errors in command line

sepavloff created this revision. Herald added subscribers: krytarowski, javed.absar, nhaehnle, rengolin, aemerson. Now if clang driver is given wrong arguments, in some cases it continues execution and returns zero code. This change fixes this behavior. The fix revealed some errors in clang test

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 98330. sepavloff added a comment. Herald added subscribers: krytarowski, rengolin. Updated patch https://reviews.llvm.org/D24933 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticDriverKinds.td include/clang/Config/config.h.cmake include/c

[PATCH] D32989: Don't indent JavaScript IIFEs

danbeam updated this revision to Diff 98332. danbeam marked 4 inline comments as done. danbeam added a comment. mprobst@ review https://reviews.llvm.org/D32989 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

[PATCH] D32989: Don't indent JavaScript IIFEs

danbeam added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2353 + // expressions? + if (Line->Tokens.size() < 5) +return false; mprobst wrote: > There's a `startsSequenceInternal` on `Line` that might come in handy here? it wasn't on `Lin

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev updated this revision to Diff 98333. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Reduce code duplication. Use llvm_unreachable. https://reviews.llvm.org/D29951 Files: lib/Serialization/ASTReaderDecl.cpp Index: lib/Serialization/ASTReaderDecl.cpp

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

rsmith added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:213-215 + assert(isa(D) || + isa(D) && + "Decl doesn't have specializations."); Can this ever fail at runtime? I'd expect the below code to not compile if `

r302569 - [WebAssembly] Fix failing wasm-toolchain test

Author: sbc Date: Tue May 9 13:44:23 2017 New Revision: 302569 URL: http://llvm.org/viewvc/llvm-project?rev=302569&view=rev Log: [WebAssembly] Fix failing wasm-toolchain test This test was broken in r302558. Differential Revision: https://reviews.llvm.org/D33015 Modified: cfe/trunk/test/Dr

[PATCH] D32828: [Modules] Fix conservative assertion for import diagnostics

rsmith added inline comments. Comment at: lib/Sema/SemaLookup.cpp:4971-4972 assert(Owner && "definition of hidden declaration is not in a module"); + assert((!isVisible(Decl) || VisibleModules.isVisible(Owner)) && + "missing import for non-hidden decl?"); --

[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

vsk added a comment. In https://reviews.llvm.org/D32724#749868, @dexonsmith wrote: > In https://reviews.llvm.org/D32724#747728, @aprantl wrote: > > > Is it the right solution to use the module hash for correctness, or should > > the mismatch of the serialized langopts trigger a module rebuild an

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:1464 + /// Determine if \p D abd \p Suggested have a structurally compatibale + /// layout as described in C11 6.2.7/1. rsmith wrote: > Typo 'abd' Typo 'compatibale' =) Com

[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

dexonsmith added a comment. In https://reviews.llvm.org/D32724#750074, @vsk wrote: > In https://reviews.llvm.org/D32724#749868, @dexonsmith wrote: > > > In https://reviews.llvm.org/D32724#747728, @aprantl wrote: > > > > > Is it the right solution to use the module hash for correctness, or > > >

[PATCH] D32550: Supress all uses of LLVM_END_WITH_NULL

This revision was automatically updated to reflect the committed changes. Closed by commit rL302572: Suppress all uses of LLVM_END_WITH_NULL. NFC. (authored by serge_sans_paille). Changed prior to commit: https://reviews.llvm.org/D32550?vs=96798&id=98339#toc Repository: rL LLVM https://revi

r302572 - Suppress all uses of LLVM_END_WITH_NULL. NFC.

Author: serge_sans_paille Date: Tue May 9 14:31:30 2017 New Revision: 302572 URL: http://llvm.org/viewvc/llvm-project?rev=302572&view=rev Log: Suppress all uses of LLVM_END_WITH_NULL. NFC. Use variadic templates instead of relying on + sentinel. This enforces better type checking and makes cod

[PATCH] D32984: [Sema] Implement Core 2094: Trivial copy/move constructor for class with volatile member

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please first check in a change that just regenerates cxx_dr_status without your changes, to separate out the changes due to the new issues list from the changes due to this patch. (You can go

r302577 - Update testcase for upstream LLVM changes (r302469).

Author: adrian Date: Tue May 9 14:47:41 2017 New Revision: 302577 URL: http://llvm.org/viewvc/llvm-project?rev=302577&view=rev Log: Update testcase for upstream LLVM changes (r302469). Modified: cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp Modified: cfe/trunk/test/CodeGenCXX/lin

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98343. vsk retitled this revision from "[Modules] Include the enabled sanitizers in the module hash" to "[Modules] Handle sanitizer feature mismatches when importing modules". vsk edited the summary of this revision. vsk added a comment. If compatible difference

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id); --

[PATCH] D32989: Don't indent JavaScript IIFEs

mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTestJS.cpp:371 +TEST_F(FormatTestJS, IIFE) { + verifyFormat("(function() {\n" + "var a = 1;\n" danbea

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302580 - clang-format: [JS] Don't indent JavaScript IIFEs.

Author: mprobst Date: Tue May 9 15:04:09 2017 New Revision: 302580 URL: http://llvm.org/viewvc/llvm-project?rev=302580&view=rev Log: clang-format: [JS] Don't indent JavaScript IIFEs. Because IIFEs[1] are often used like an anonymous namespace around large sections of JavaScript code, it's useful

[PATCH] D32989: Don't indent JavaScript IIFEs

This revision was automatically updated to reflect the committed changes. Closed by commit rL302580: clang-format: [JS] Don't indent JavaScript IIFEs. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D32989?vs=98332&id=98344#toc Repository: rL LLVM https://reviews.ll

[PATCH] D32743: [clang-tidy] Add new cert-dcl21-cpp check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98349. vsk marked 7 inline comments as done. vsk added a comment. Add a comment explaining how and why ASTReader checks for sanitizer feature mismatches. https://reviews.llvm.org/D32724 Files: include/clang/Basic/Sanitizers.h lib/Basic/LangOptions.cpp li

Re: [PATCH] D24933: Enable configuration files in clang

On 1 March 2017 at 02:50, Serge Pavlov via Phabricator < revi...@reviews.llvm.org> wrote: > sepavloff added a comment. > > Glad to know that someone is interested in this feature! > Below is actual proposal. > > **Adding named configuration files to clang driver** > > A configuration file is a col

r302588 - Fix CGObjCGNU::init bug introduced by r302572

Author: serge_sans_paille Date: Tue May 9 16:19:44 2017 New Revision: 302588 URL: http://llvm.org/viewvc/llvm-project?rev=302588&view=rev Log: Fix CGObjCGNU::init bug introduced by r302572 Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp URL: http

[PATCH] D33013: Driver must return non-zero code on errors in command line

rsmith added a comment. Thank you, some of these test typos are ... alarming. =) A couple of the test updates don't look quite right, but this mostly looks great. Comment at: test/Driver/amdgpu-features.c:1 -// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

eugenis updated this revision to Diff 98354. eugenis marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D32886 Files: include/clang/Driver/Options.td include/clang/Driver/SanitizerArgs.h include/clang/Frontend/CodeGenOptions.def lib/CodeGen/BackendUtil.cpp

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

eugenis added a comment. I'll fix the other unnecessary MakeArgString calls in a separate commit Repository: rL LLVM https://reviews.llvm.org/D32886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

rsmith added a comment. Er, please ignore the inline review comments; those predated the realisation that this doesn't actually fix the glibc build problem. https://reviews.llvm.org/D16171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D16171#540261, @phabricss wrote: > ../include/sys/stat.h:16:15: error: cannot apply asm label to function > after its first use > hidden_proto (__fxst

r302590 - Remove unnecessary calls to MakeArgString.

Author: eugenis Date: Tue May 9 16:57:39 2017 New Revision: 302590 URL: http://llvm.org/viewvc/llvm-project?rev=302590&view=rev Log: Remove unnecessary calls to MakeArgString. Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp Modified: cfe/tr

r302591 - [asan] A clang flag to enable ELF globals-gc.

Author: eugenis Date: Tue May 9 16:57:43 2017 New Revision: 302591 URL: http://llvm.org/viewvc/llvm-project?rev=302591&view=rev Log: [asan] A clang flag to enable ELF globals-gc. This feature is subtly broken when the linker is gold 2.26 or earlier. See the following bug for details: https://s

[PATCH] D32886: [asan] A clang flag to enable ELF globals-gc

eugenis closed this revision. eugenis added a comment. r302591, thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D32886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7129 +NewVD->getType().getAddressSpace() != LangAS::opencl_constant) || NewVD->hasExternalStorage()) { if (!T->isSamplerT() && Seeing criteria like this, and a lot of the ot

r302592 - Update Clang C++ DR documentation for new issue list

Author: ericwf Date: Tue May 9 17:17:23 2017 New Revision: 302592 URL: http://llvm.org/viewvc/llvm-project?rev=302592&view=rev Log: Update Clang C++ DR documentation for new issue list Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL: http://llvm.or

[PATCH] D32984: [Sema] Implement Core 2094: Trivial copy/move constructor for class with volatile member

EricWF updated this revision to Diff 98359. EricWF added a comment. - Remove unrelated issues list changes. https://reviews.llvm.org/D32984 Files: lib/AST/Type.cpp test/CXX/drs/dr20xx.cpp test/CXX/drs/dr4xx.cpp test/SemaCXX/type-traits.cpp www/cxx_dr_status.html Index: www/cxx_dr_sta

r302593 - [Sema] Implement Core 2094: Trivial copy/move constructor for class with volatile member

Author: ericwf Date: Tue May 9 17:21:24 2017 New Revision: 302593 URL: http://llvm.org/viewvc/llvm-project?rev=302593&view=rev Log: [Sema] Implement Core 2094: Trivial copy/move constructor for class with volatile member Summary: This patch implements http://www.open-std.org/jtc1/sc22/wg21/doc

r302594 - Fix clang_cl argument in fsanitize.c driver test.

Author: eugenis Date: Tue May 9 17:28:57 2017 New Revision: 302594 URL: http://llvm.org/viewvc/llvm-project?rev=302594&view=rev Log: Fix clang_cl argument in fsanitize.c driver test. Modified: cfe/trunk/test/Driver/fsanitize.c Modified: cfe/trunk/test/Driver/fsanitize.c URL: http://llvm.or

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98363. vsk added a comment. I've uploaded the correct diff this time, sorry for the confusion. https://reviews.llvm.org/D32724 Files: include/clang/Basic/Sanitizers.h lib/Basic/LangOptions.cpp lib/Frontend/CompilerInvocation.cpp lib/Serialization/ASTRea

r302596 - Don't mark a member as a member specialization until we know we're keeping the specialization.

Author: rsmith Date: Tue May 9 18:02:10 2017 New Revision: 302596 URL: http://llvm.org/viewvc/llvm-project?rev=302596&view=rev Log: Don't mark a member as a member specialization until we know we're keeping the specialization. This improves our behavior in a few ways: * We now guarantee that

[PATCH] D32988: [libc++] Refactor Windows support headers.

compnerd requested changes to this revision. compnerd added inline comments. Comment at: include/__config:232-235 +#ifndef NOMINMAX +#define NOMINMAX +#endif + bcraig wrote: > I can see this helping when we are build libc++, but I don't think it helps > client a

  1   2   >