benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
A couple of minor comments, but otherwise LGTM.
================
Comment at: include/clang/AST/DeclCXX.h:1569
+ bool lookupInBases(BaseMatchesCallback BaseMatches, CXXBasePaths &Paths,
+ bool LookupInDependent = false) const;
----------------
Since the other params are documented above, this should be too.
================
Comment at: lib/AST/CXXInheritance.cpp:281
+ }
+ } else
+ BaseRecord = cast<CXXRecordDecl>(
----------------
Please put `{}` around this else. The first two times I read this I thought
the following if was nested inside this else.
Repository:
rL LLVM
https://reviews.llvm.org/D32972
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
