[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

Hahnfeld added a comment. Hi Michal, this currently breaks for me: `-lunwind` will find the system default `libunwind.so.8` instead of LLVMs `libunwind.so.1` which breaks some tests. This has worked magically before because libc++ and libc++abi where explicitely linked against LLVMs `libunwind.

[PATCH] D25402: [Driver] Pass -lunwind when using libc++ + compiler-rt on Linux

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains.cpp:4704 + GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT) +CmdArgs.push_back("-lunwind"); +} As just written in D25008: This will probably result in problems if a system default `l

[PATCH] D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType

klimek added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2119 + "template \n" + "void Function(Namespace::Template param) {\n" + " param.Method();\n" lukasza wrote: > klimek wrote: > > Given your use case: why d

r284958 - Fix myriad test with CLANG_DEFAULT_CXX_STDLIB

Author: hahnfeld Date: Mon Oct 24 03:04:17 2016 New Revision: 284958 URL: http://llvm.org/viewvc/llvm-project?rev=284958&view=rev Log: Fix myriad test with CLANG_DEFAULT_CXX_STDLIB Modified: cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/test/Driver/myriad-toolchain.c URL: htt

r284959 - [Sema][TreeTransform] Re-create DesignatedInitExpr when a field designator

Author: arphaman Date: Mon Oct 24 04:33:32 2016 New Revision: 284959 URL: http://llvm.org/viewvc/llvm-project?rev=284959&view=rev Log: [Sema][TreeTransform] Re-create DesignatedInitExpr when a field designator has no field declaration. This commit fixes an invalid Winitializer-overrides warning t

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL284959: [Sema][TreeTransform] Re-create DesignatedInitExpr when a field designator (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D2

r284960 - [analyzer] Add StdLibraryFunctions checker.

Author: dergachev Date: Mon Oct 24 04:41:38 2016 New Revision: 284960 URL: http://llvm.org/viewvc/llvm-project?rev=284960&view=rev Log: [analyzer] Add StdLibraryFunctions checker. This checker does not emit reports, however it influences the analysis by providing complete summaries for, or otherw

[PATCH] D20811: [analyzer] Model some library functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL284960: [analyzer] Add StdLibraryFunctions checker. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D20811?vs=75446&id=75560#toc Repository: rL LLVM https://reviews.llvm.o

r284961 - [Sema] Formatting warnings should see through Objective-C message sends

Author: arphaman Date: Mon Oct 24 04:42:34 2016 New Revision: 284961 URL: http://llvm.org/viewvc/llvm-project?rev=284961&view=rev Log: [Sema] Formatting warnings should see through Objective-C message sends This commit improves the '-Wformat' warnings by ensuring that the formatting checker can s

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

This revision was automatically updated to reflect the committed changes. Closed by commit rL284961: [Sema] Formatting warnings should see through Objective-C message sends (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25820?vs=75408&id=75561#toc Repository: rL L

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

bader added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); AlexeySotkin wrote: > Anastasia wr

[PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

joey added a comment. Two minor comments, but otherwise LGTM! Comment at: include/clang/Basic/OpenCLOptions.h:33 // Enable all options. + void setAll(bool Enable = true) { This comment needs to be changed, to reflect that they are now all enabled or disa

r284963 - [X86][AVX512][Clang][Intrinsics][reduce] Adding missing reduce (Operators: +, *, &&, ||) intrinsics to Clang

Author: mzuckerm Date: Mon Oct 24 05:53:20 2016 New Revision: 284963 URL: http://llvm.org/viewvc/llvm-project?rev=284963&view=rev Log: [X86][AVX512][Clang][Intrinsics][reduce] Adding missing reduce (Operators: +,*,&&,||) intrinsics to Clang Committed after LGTM and check-all Vector-reduction ar

r284964 - Adjust for TimePoint interface change in llvm: D25730. NFC

Author: labath Date: Mon Oct 24 05:59:13 2016 New Revision: 284964 URL: http://llvm.org/viewvc/llvm-project?rev=284964&view=rev Log: Adjust for TimePoint interface change in llvm: D25730. NFC Modified: cfe/trunk/include/clang/Basic/VirtualFileSystem.h cfe/trunk/lib/Driver/Tools.cpp Modif

[PATCH] D23712: [OpenCL] Override supported OpenCL extensions with -cl-ext option

asavonic updated this revision to Diff 75568. asavonic added a comment. - Fix comments and code formatting https://reviews.llvm.org/D23712 Files: include/clang/Basic/OpenCLOptions.h include/clang/Basic/TargetInfo.h include/clang/Basic/TargetOptions.h include/clang/Driver/CC1Options.td

r284967 - revert r284963

Author: mzuckerm Date: Mon Oct 24 06:30:23 2016 New Revision: 284967 URL: http://llvm.org/viewvc/llvm-project?rev=284967&view=rev Log: revert r284963 because new test file is failing in some OS. test/CodeGen/avx512-reduceIntrin.c Removed: cfe/trunk/test/CodeGen/avx512-reduceIntrin.c Modifi

Re: r284960 - [analyzer] Add StdLibraryFunctions checker.

On 24 October 2016 at 10:41, Artem Dergachev via cfe-commits wrote: > Author: dergachev > Date: Mon Oct 24 04:41:38 2016 > New Revision: 284960 > > URL: http://llvm.org/viewvc/llvm-project?rev=284960&view=rev > Log: > [analyzer] Add StdLibraryFunctions checker. Hi Artem, I'm not sure what you're

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); Anastasia wrote: > Why this

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good from a Clang perspective. You also might want to get review from someone who knows how the os_log API is supposed to work, as I can't comment on that. Com

[PATCH] D25402: [Driver] Pass -lunwind when using libc++ + compiler-rt on Linux

mgorny added inline comments. Comment at: lib/Driver/ToolChains.cpp:4704 + GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT) +CmdArgs.push_back("-lunwind"); +} Hahnfeld wrote: > As just written in D25008: This will probably result in problems if a sy

r284969 - [analyzer] Fix an ARM buildbot after r284960.

Author: dergachev Date: Mon Oct 24 07:54:27 2016 New Revision: 284969 URL: http://llvm.org/viewvc/llvm-project?rev=284969&view=rev Log: [analyzer] Fix an ARM buildbot after r284960. I guess we should always specify triples in all analyzer tests, regardless. Modified: cfe/trunk/test/Analysis/

[PATCH] D25402: [Driver] Pass -lunwind when using libc++ + compiler-rt on Linux

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains.cpp:4704 + GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT) +CmdArgs.push_back("-lunwind"); +} mgorny wrote: > Hahnfeld wrote: > > As just written in D25008: This will probably result

Re: r284960 - [analyzer] Add StdLibraryFunctions checker.

Strange, i'm not receiving any buildbot emails again. Will look through bots manually next time, that doesn't sound too hard. Pushed a hotfix in r284969. On 10/24/16 3:08 PM, Renato Golin wrote: On 24 October 2016 at 10:41, Artem Dergachev via cfe-commits wrote: Author: dergachev Date: Mon O

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

mgorny added a comment. I think it'd be technically possible to force a specific SONAME in the linker script but I don't think that's a good idea. Clang should be able to use any libunwind implementation, and libc++ shouldn't really be encoding internal implementation details to the point of sp

[PATCH] D25402: [Driver] Pass -lunwind when using libc++ + compiler-rt on Linux

mgorny added inline comments. Comment at: lib/Driver/ToolChains.cpp:4704 + GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT) +CmdArgs.push_back("-lunwind"); +} Hahnfeld wrote: > mgorny wrote: > > Hahnfeld wrote: > > > As just written in D25008: This

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

Hahnfeld added a comment. `LIBCXXABI_USE_LLVM_UNWINDER` implies to me: "Use LLVM's `libunwind` whenever you use `libc++abi`". This has worked until now and I would vote for this to be the right thing to do. Repository: rL LLVM https://reviews.llvm.org/D25008 _

Re: r284960 - [analyzer] Add StdLibraryFunctions checker.

On 24 October 2016 at 14:09, Artem Dergachev wrote: > Strange, i'm not receiving any buildbot emails again. Will look through bots > manually next time, that doesn't sound too hard. Pushed a hotfix in r284969. The buildmaster was restarted this weekend and got all old builds data wiped. I only k

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:462 + case CK_ReinterpretMemberPointer: { +const Expr *UOExpr = CastE->getSubExpr()->IgnoreParenCasts(); +assert(isa(UOExpr) && dcoughlin wrote: > dcoughli

[PATCH] D25402: [Driver] Pass -lunwind when using libc++ + compiler-rt on Linux

Hahnfeld added inline comments. Comment at: lib/Driver/ToolChains.cpp:4704 + GetRuntimeLibType(Args) == ToolChain::RLT_CompilerRT) +CmdArgs.push_back("-lunwind"); +} mgorny wrote: > Hahnfeld wrote: > > mgorny wrote: > > > Hahnfeld wrote: > > > > As just

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

joerg added a comment. So the historical reason for the libgcc_s dance for glibc was the use of unwinding for thread cancellation. With all the glibc versions I can find, going back to SLES11 SP1, this is no longer the case. To check for yourself, look for _Unwind* symbols in libc.so and libc.a

Re: [clang-tools-extra] r284888 - Remove 'misc-pointer-and-integral-operation' clang-tidy check. The only cases

Wait, I thought the check was mostly useful for C code, where it detects real issues? Etienne, can you comment? On Fri, Oct 21, 2016 at 11:50 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Oct 21 16:50:28 2016 > New Revision: 284888 > > URL: ht

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

NoQ updated this revision to Diff 75586. NoQ marked an inline comment as done. NoQ added a comment. - Update warning messages. I think it's better to pattern-match for integer sizes after all when we're suggesting API, this especially looks ugly for OSNumber (which is rare). - Add tests for conv

[PATCH] D25893: [clang] Remove redundant --check-prefix=CHECK from tests

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D25893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. As documentation in https://developer.apple.com/reference/dispatch/dispatch_once_t says, only global or static variables should have type `dispatch_once_t`, otherwise the magic with fast m

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ updated this revision to Diff 75589. NoQ added a comment. Hotfix code duplication i just noticed. https://reviews.llvm.org/D25909 Files: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp test/Analysis/dispatch-once.m Index: test/Analysis/dispatch-once.m

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

mehdi_amini added a comment. Thanks! For the API part, this is already in production ( https://github.com/apple/swift-clang/blob/stable/lib/CodeGen/CGBuiltin.cpp#L2071 ), so it should be OK! https://reviews.llvm.org/D25888 ___ cfe-commits mailing

[PATCH] D25911: [clang-move] Support moving template class forward declarations.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. [clang-tidy] Don't warn implicit variables in peformance-unnecessary-copy-initialization. This will prevent the check warning the variables which have been implicitly added by compiler, like th

[PATCH] D25911: [clang-move] Support moving template class forward declarations.

hokein updated this revision to Diff 75595. hokein added a comment. Don't mess up with other patches. https://reviews.llvm.org/D25911 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp test/clang-tidy/performance-unnecessary-copy-initialization.cpp Index: test/clang-tidy/perf

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:462 + case CK_ReinterpretMemberPointer: { +const Expr *UOExpr = CastE->getSubExpr()->IgnoreParenCasts(); +assert(isa(UOExpr) && kromanenkov wrote: > dcoughli

r284988 - Fix clang-format vim integration issue with non-ascii characters

Author: alexfh Date: Mon Oct 24 11:31:26 2016 New Revision: 284988 URL: http://llvm.org/viewvc/llvm-project?rev=284988&view=rev Log: Fix clang-format vim integration issue with non-ascii characters clang-format.py currently seems to treat vim.current.buf as ascii-encoded data, which leads to an U

RE: [PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

Hi Ettore, As far as I understand the whole problem is that the optimized functions are marked by __attribute__((pure)). If the attribute is removed from your example, we get LLVM dump preserving correctness: define i32 @bar(i32 %x) local_unnamed_addr #0 { entry: %call = tail call i32 @foo()

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:92 + else if (isa(RS)) +os << " heap allocated memory"; + else if (isa(RS)) { "heap allocated" --> "heap-allocated" Comment at: lib/StaticAnalyz

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

This revision was automatically updated to reflect the committed changes. Closed by commit rL284990: Add support for __builtin_os_log_format[_buffer_size] (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D25888?vs=75552&id=75608#toc Repository: rL LLVM https://re

r284990 - Add support for __builtin_os_log_format[_buffer_size]

Author: mehdi_amini Date: Mon Oct 24 11:56:23 2016 New Revision: 284990 URL: http://llvm.org/viewvc/llvm-project?rev=284990&view=rev Log: Add support for __builtin_os_log_format[_buffer_size] These new builtins support a mechanism for logging OS events, using a printf-like format string to specif

Re: [clang-tools-extra] r284888 - Remove 'misc-pointer-and-integral-operation' clang-tidy check. The only cases

On Mon, Oct 24, 2016 at 8:31 AM, Alexander Kornienko wrote: > Wait, I thought the check was mostly useful for C code, where it detects > real issues? Etienne, can you comment? > See below. This is only checking for cases that are already ill-formed, some of which we accept as an extension, and a

[PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

Anastasia added a comment. In https://reviews.llvm.org/D25343#567374, @tstellarAMD wrote: > In https://reviews.llvm.org/D25343#565288, @Anastasia wrote: > > > Do you have any code example where Clang/LLVM performs wrong optimizations > > with respect to the control flow of SPMD execution? > > >

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); bader wrote: > AlexeySotkin wr

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:94 + else if (isa(RS)) { +// FIXME: Presence of an IVar region has priority over this branch, because +// ObjC objects are on the heap even if the core doesn't realize this. -

[clang-tools-extra] r284992 - [clang-tidy] Fix identifier naming in macro args.

Author: jhen Date: Mon Oct 24 12:20:32 2016 New Revision: 284992 URL: http://llvm.org/viewvc/llvm-project?rev=284992&view=rev Log: [clang-tidy] Fix identifier naming in macro args. Summary: clang-tidy should fix identifier naming even when the identifier is referenced inside a macro expansion, pr

[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

jhen added a comment. Thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D25450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25450: [clang-tidy] Fix identifier naming in macro args.

This revision was automatically updated to reflect the committed changes. jhen marked an inline comment as done. Closed by commit rL284992: [clang-tidy] Fix identifier naming in macro args. (authored by jhen). Changed prior to commit: https://reviews.llvm.org/D25450?vs=75430&id=75610#toc Repos

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

NoQ updated this revision to Diff 75612. NoQ added a comment. Do not suggest any API when we're not sure (was already advised by Anna but i missed it somehow). https://reviews.llvm.org/D25731 Files: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp test/Analysis/number-object-c

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > timshen created this revision. > timshen added reviewers: rsmith, pirama. > timshen added a subscriber: cfe-commits. > > https://reviews.llvm.org/D24010 > > Files: > clang/include/clang/AST/Stmt.h >

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

bruno added inline comments. Comment at: lib/Driver/ToolChains.cpp:3937 +StringRef Data = File.get()->getBuffer(); +SmallVector Lines; +Data.split(Lines, "\n"); This file usually has 5-6 lines, can you use 8 instead? Comment at: lib

Re: [PATCH] D21508: Make friend function template definition available if class is instantiated.

Ping. Thanks, --Serge 2016-10-18 0:09 GMT+07:00 Serge Pavlov : > Ping. > > Thanks, > --Serge > > 2016-10-13 11:51 GMT+07:00 Serge Pavlov : > >> sepavloff updated the summary for this revision. >> >> https://reviews.llvm.org/D21508 >> >> >> >> > ___ cfe

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

mgorny updated this revision to Diff 75615. mgorny added a comment. Refactored the code as requested. Also I've noticed that if VERSION had invalid value, the code continued reading the file — now it immediately returns UnknownDistro in that case. https://reviews.llvm.org/D24954 Files: lib/

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast added a comment. Friendly ping... https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

delena added inline comments. Comment at: lib/Headers/avx512fintrin.h:8394 _MM_FROUND_CUR_DIRECTION); } Using vfmaddss3_mask is wrong in this case. It will propagate -B to lower bits if mask==0. Comment at: lib/Headers/avx512fintr

[PATCH] D25916: Modules: emit an error instead of a random crash (or a misleading error) due to use-after-free.

manmanren created this revision. manmanren added reviewers: benlangmuir, rsmith. manmanren added a subscriber: cfe-commits. With implicit modules, it is hard to debug issues that depend on state of the module cache before the clang invocation. The state of the module cache can be changed by othe

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

bruno added inline comments. Comment at: lib/Driver/ToolChains.cpp:3942 + int Version; + if (SplitLine.first.trim() != "VERSION") +continue; You can check `Line.trim() != VERSION` before the `split` as to do not try to split unnecessary lines.

Re: r284960 - [analyzer] Add StdLibraryFunctions checker.

This code also fails with UBSan: tools/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:285:62: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long' #0 0x5e1642f in (anonymous namespace)::StdLibraryFunctionsChecker::ValueRange::ap

[PATCH] D25916: Modules: emit an error instead of a random crash (or a misleading error) due to use-after-free.

manmanren added a comment. In this testing case, the first clang invocation builds a system module X and a non-system module Y (X imports Y). At the second clang invocation, the parent thread validates the existing module X and module Y. Because X is a system module, we don't diagnose the diffe

r284999 - Fix crash if StmtProfile finds a type-dependent member access for which we have

Author: rsmith Date: Mon Oct 24 13:47:04 2016 New Revision: 284999 URL: http://llvm.org/viewvc/llvm-project?rev=284999&view=rev Log: Fix crash if StmtProfile finds a type-dependent member access for which we have resolved the -> to a call to a specific operator-> function. The particular test case

r285000 - [analyzer] Use unsigned integers to rely on well-defined overflow semantics.

Author: dergachev Date: Mon Oct 24 13:49:04 2016 New Revision: 285000 URL: http://llvm.org/viewvc/llvm-project?rev=285000&view=rev Log: [analyzer] Use unsigned integers to rely on well-defined overflow semantics. Found by the UBSan buildbot. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/St

Re: r284960 - [analyzer] Add StdLibraryFunctions checker.

Thanks! Should get better with r285000. On 10/24/16 9:34 PM, Evgenii Stepanov wrote: This code also fails with UBSan: tools/clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:285:62: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'lon

[PATCH] D25893: [clang] Remove redundant --check-prefix=CHECK from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL285001: [clang] Remove redundant --check-prefix=CHECK from tests (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D25893?vs=75521&id=75620#toc Repository: rL LLVM https://revi

r285001 - [clang] Remove redundant --check-prefix=CHECK from tests

Author: mgrang Date: Mon Oct 24 13:53:43 2016 New Revision: 285001 URL: http://llvm.org/viewvc/llvm-project?rev=285001&view=rev Log: [clang] Remove redundant --check-prefix=CHECK from tests Reviewers: mkuper, rengolin, hans Subscribers: cfe-commits Tags: #clang-c Differential Revision: https:/

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

craig.topper added inline comments. Comment at: lib/Headers/avx512fintrin.h:8394 _MM_FROUND_CUR_DIRECTION); } delena wrote: > Using vfmaddss3_mask is wrong in this case. > It will propagate -B to lower bits if mask==0. I dont' understand this. The p

Re: [PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

On Fri, Oct 21, 2016 at 3:16 AM Alex Lorenz wrote: > arphaman updated this revision to Diff 75403. > arphaman added a comment. > > The updated patch improves error handling and adds a test for the fixit. > > > If we issue a fixit we should recover as-if the code was written with > the fixit in. D

[PATCH] D25895: [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1779-1780 + MicrosoftVTableContext &VFTContext = CGM.getMicrosoftVTableContext(); MicrosoftVTableContext::MethodVFTableLocation

[PATCH] D25063: [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints for extended inline assembly, enabling use of AVX512 masked vectorized instructions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D25063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D25920: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.

yaxunl created this revision. yaxunl added reviewers: tstellarAMD, arsenm. yaxunl added a subscriber: cfe-commits. Herald added subscribers: tony-tye, wdng, kzhuravl. Patch by Laurent Morichetti. https://reviews.llvm.org/D25920 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp =

r285007 - Revert "Add support for __builtin_os_log_format[_buffer_size]"

Author: mehdi_amini Date: Mon Oct 24 14:41:36 2016 New Revision: 285007 URL: http://llvm.org/viewvc/llvm-project?rev=285007&view=rev Log: Revert "Add support for __builtin_os_log_format[_buffer_size]" This reverts commit r284990, two opencl test are broken Removed: cfe/trunk/include/clang/An

RE: [PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

Just my two cents. Let's consider a simple example: for (int I = 0; I < 2; I++) { A = Compute(); barrier(); Use(A); } This does not mean Compute() needs to be executed for all the loop iterations before barrier() being executed. This only means that during each loop iteration, Compute()

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode added a comment. Thanks for pointing it out, just a minute ago I found a proper document mentioning it (I have no idea how I could miss it). I hope to be more use in future :) Comment at: unittests/Format/FormatTest.cpp:11365 +

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

idlecode updated this revision to Diff 75635. https://reviews.llvm.org/D25439 Files: lib/Format/FormatTokenLexer.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === --- unittests/Format/FormatTest.cpp

[PATCH] D25439: Fixed column shift when formatting line containing bit shift operators

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D25439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[libcxx] r285011 - Fix shadow warnings in string_view tests. Patch from s...@microsoft.com

Author: ericwf Date: Mon Oct 24 15:10:00 2016 New Revision: 285011 URL: http://llvm.org/viewvc/llvm-project?rev=285011&view=rev Log: Fix shadow warnings in string_view tests. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_append/T_s

[libcxx] r285012 - Add missing include in string_view tests. Patch from Billy ONeil @ microsoft

Author: ericwf Date: Mon Oct 24 15:11:17 2016 New Revision: 285012 URL: http://llvm.org/viewvc/llvm-project?rev=285012&view=rev Log: Add missing include in string_view tests. Patch from Billy ONeil @ microsoft Modified: libcxx/trunk/test/std/strings/string.view/string.view.ops/copy.pass.cpp

[PATCH] D25492: [libcxx] [test] Fix shadowing in string.assign and string.append

EricWF closed this revision. EricWF added a comment. r285011. https://reviews.llvm.org/D25492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

EricWF closed this revision. EricWF added a comment. r285012. https://reviews.llvm.org/D25531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

timshen updated this revision to Diff 75644. timshen added a comment. Simplified the test. https://reviews.llvm.org/D24010 Files: clang/include/clang/AST/Stmt.h clang/lib/Analysis/ReachableCode.cpp clang/test/SemaCXX/PR29152.cpp Index: clang/test/SemaCXX/PR29152.cpp

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

On Mon, Oct 24, 2016 at 10:33 AM David Blaikie wrote: > On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > timshen created this revision. > timshen added reviewers: rsmith, pirama. > timshen added a subscriber: cfe-commits. > > https://reviews.llvm

r285015 - Fix mangling of implicit calls to operator-> to only include a single "pt",

Author: rsmith Date: Mon Oct 24 15:29:40 2016 New Revision: 285015 URL: http://llvm.org/viewvc/llvm-project?rev=285015&view=rev Log: Fix mangling of implicit calls to operator-> to only include a single "pt", rather than including an extra one for each level of 'operator->()' invoked. Modified:

[PATCH] D25925: [clang-tidy] Update cert-err58-cpp to match its new generalised form.

malcolm.parsons created this revision. malcolm.parsons added a reviewer: aaron.ballman. malcolm.parsons added a subscriber: cfe-commits. Aaron modified cert-err58-cpp to include all exceptions thrown before main() Update the check to match. https://reviews.llvm.org/D25925 Files: clang-tidy/ce

r285019 - Add support for __builtin_os_log_format[_buffer_size]

Author: mehdi_amini Date: Mon Oct 24 15:39:34 2016 New Revision: 285019 URL: http://llvm.org/viewvc/llvm-project?rev=285019&view=rev Log: Add support for __builtin_os_log_format[_buffer_size] This reverts commit r285007 and reapply r284990, with a fix for the opencl test that I broke. Original co

[libcxx] r285020 - Fix non-portable tests for temp_directory_path(...)

Author: ericwf Date: Mon Oct 24 15:40:35 2016 New Revision: 285020 URL: http://llvm.org/viewvc/llvm-project?rev=285020&view=rev Log: Fix non-portable tests for temp_directory_path(...) Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path

r285022 - Fix bug where one of the cases where we mangle a failed

Author: rsmith Date: Mon Oct 24 15:47:04 2016 New Revision: 285022 URL: http://llvm.org/viewvc/llvm-project?rev=285022&view=rev Log: Fix bug where one of the cases where we mangle a failed to emit the portion. Refactor so that mangleUnresolvedName actually emits the entire , so this mistake is h

r285023 - CodeGen: centralise label construction for method lists

Author: compnerd Date: Mon Oct 24 15:47:58 2016 New Revision: 285023 URL: http://llvm.org/viewvc/llvm-project?rev=285023&view=rev Log: CodeGen: centralise label construction for method lists Move all the label construction for the various method list emission into EmitMethodList. Rather than hav

[PATCH] D25925: [clang-tidy] Update cert-err58-cpp to match its new generalised form.

aaron.ballman added a comment. Thank you for working on this! I have a few more test cases to try, but I think you're already handling them properly. Comment at: test/clang-tidy/cert-static-object-exception.cpp:29 + X(S = {}) noexcept; +}; + We should also ha

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

mgorny added inline comments. Comment at: lib/Driver/ToolChains.cpp:3942 + int Version; + if (SplitLine.first.trim() != "VERSION") +continue; bruno wrote: > You can check `Line.trim() != VERSION` before the `split` as to do not try to > split u

r285027 - Fix test on non-X86 platforms

Author: mehdi_amini Date: Mon Oct 24 16:22:01 2016 New Revision: 285027 URL: http://llvm.org/viewvc/llvm-project?rev=285027&view=rev Log: Fix test on non-X86 platforms This is a fixup for r285019, adding an `#ifdef __x86_64__` since the os_log builtin is platform specific. Modified: cfe/trun

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

bruno added inline comments. Comment at: lib/Driver/ToolChains.cpp:3942 + int Version; + if (SplitLine.first.trim() != "VERSION") +continue; mgorny wrote: > bruno wrote: > > You can check `Line.trim() != VERSION` before the `split` as to do not

r285028 - CodeGen: remove incorrect temporary Twine

Author: compnerd Date: Mon Oct 24 16:25:57 2016 New Revision: 285028 URL: http://llvm.org/viewvc/llvm-project?rev=285028&view=rev Log: CodeGen: remove incorrect temporary Twine Twines should not be stack allocated. This somehow managed to get past me. Modified: cfe/trunk/lib/CodeGen/CGObjCM

[PATCH] D25838: [Basic] Support 32-bit x86 and ARM targets for Fuchsia

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D25838 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

Simplify it further by replacing A() with just a function instead of a class? Or does that break the repro? bool Foo(); void Bar(); void Baz() { if (False && Foo()) Bar(); } On Mon, Oct 24, 2016 at 1:38 PM Tim Shen wrote: > On Mon, Oct 24, 2016 at 10:33 AM David Blaikie wrote: > > On Mon

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

On Mon, Oct 24, 2016 at 2:38 PM David Blaikie wrote: > Simplify it further by replacing A() with just a function instead of a > class? Or does that break the repro? > > bool Foo(); > void Bar(); > void Baz() { > if (False && Foo()) > Bar(); > } > This actually breaks the repro. My test int

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

Ah, right - thanks for reminding/explaining! On Mon, Oct 24, 2016 at 2:42 PM Tim Shen wrote: > On Mon, Oct 24, 2016 at 2:38 PM David Blaikie wrote: > > Simplify it further by replacing A() with just a function instead of a > class? Or does that break the repro? > > bool Foo(); > void Bar(); > v

Re: r285027 - Fix test on non-X86 platforms

Doesn't this exclude 32-bit x86? ~Craig On Mon, Oct 24, 2016 at 2:22 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mehdi_amini > Date: Mon Oct 24 16:22:01 2016 > New Revision: 285027 > > URL: http://llvm.org/viewvc/llvm-project?rev=285027&view=rev > Log: > Fix te

r285031 - [Sema][ObjC] Warn about implicitly autoreleasing out-parameters captured

Author: ahatanak Date: Mon Oct 24 16:45:54 2016 New Revision: 285031 URL: http://llvm.org/viewvc/llvm-project?rev=285031&view=rev Log: [Sema][ObjC] Warn about implicitly autoreleasing out-parameters captured by blocks. Add a new warning "-Wblock-capture-autoreleasing". The warning warns about imp

  1   2   >