bruno added inline comments.

================
Comment at: lib/Driver/ToolChains.cpp:3942
+      int Version;
+      if (SplitLine.first.trim() != "VERSION")
+        continue;
----------------
mgorny wrote:
> bruno wrote:
> > You can check `Line.trim() != VERSION` before the `split` as to do not try 
> > to split unnecessary lines.
> You mean `line.trim().startswith()`, correct?
Yep, you got the idea :-)


https://reviews.llvm.org/D24954



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to