joey added a comment.
Two minor comments, but otherwise LGTM!
================
Comment at: include/clang/Basic/OpenCLOptions.h:33
// Enable all options.
+ void setAll(bool Enable = true) {
----------------
This comment needs to be changed, to reflect that they are now all enabled or
disabled.
================
Comment at: include/clang/Basic/TargetInfo.h:992
+ virtual void setOpenCLExtensionOpts() {
+ for (const auto &Ext:getTargetOpts().OpenCLExtensionsAsWritten) {
+ getTargetOpts().SupportedOpenCLOptions.set(Ext);
----------------
Can you put a space around the ':'.
https://reviews.llvm.org/D23712
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
