bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land.
This looks good from a Clang perspective. You also might want to get review from someone who knows how the os_log API is supposed to work, as I can't comment on that. ================ Comment at: clang/test/CodeGenObjC/os_log.m:13 +// Behavior of __builtin_os_log differs between platforms, so only test on X86 +#ifdef __x86_64__ +// CHECK-LABEL: define i8* @test_builtin_os_log ---------------- This is only ever compile for x86 (you have a triple in the command line). Just drop the #ifdef. https://reviews.llvm.org/D25888 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
