omtcyfz created this revision.
omtcyfz added reviewers: ClockMan, ioeric, aaron.ballman.
omtcyfz added a subscriber: cfe-commits.
Start using `argparse` instead of mimicking CLI parsing.
PEPify the code.
https://reviews.llvm.org/D25074
Files:
clang-tidy/rename_check.py
Index: clang-tidy/ren
alexshap added inline comments.
> rename_check.py:81
> +args = parser.parse_args()
> +print(args)
> +
the script always prints the args, is it intentional ?
https://reviews.llvm.org/D25074
___
cfe-commits mailing list
cfe-commits@lists.llvm
EricWF updated this revision to Diff 73000.
EricWF added a comment.
Run patch through clang-format.
https://reviews.llvm.org/D25068
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaCoroutine.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/coroutines.c
EricWF added a comment.
Hijacked to address review comments. @GorNishanov feel free to commandeer this
revision back.
https://reviews.llvm.org/D25068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
NoQ updated this revision to Diff 72991.
NoQ added a comment.
- Update the commit messages.
- Move a run-away test file to its correct directory.
- Fix a copy-paste error in initialization of the variable field of a clone
pair.
https://reviews.llvm.org/D24916
Files:
include/clang/Analysis/Cl
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Committed in r282792.
https://reviews.llvm.org/D25060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
The title says it all.
https://reviews.llvm.org/D25078
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
te
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with nits.
> ClangMove.cpp:36
> + llvm::sys::fs::make_absolute(InitialDirectory, AbsolutePath))
> +llvm::errs() << "warning: could not make absolute file: '" <<
> EC.message
klimek added inline comments.
> MigrateTool.cpp:52
> + // Get all files that are affected by the migration, i.e. users of the
> symbol.
> + auto Files =
> Env.getAffectedFilesFinder().getAffectedFiles(Spec.getOldName());
> + if (!Files)
I'm wondering whether we really want to evolve this to
rmaprath updated this revision to Diff 73007.
rmaprath added a comment.
Updated with the following changes:
- Address review comments from @EricWF and @compnerd regarding using
`_POSIX_THREADS` for detecting pthread availability. Now the patch is checking
for `defined(_POSIX_THREADS) && _POSIX_
rmaprath added a comment.
@tavianator: I'm about to commit https://reviews.llvm.org/D24864, which will
affect this patch (indirectly). https://reviews.llvm.org/D24864 basically
refactors all pthread dependencies behind a separate API. It would be pretty
straightforward for you to update this pa
rmaprath added a comment.
@ikudrin: Looks like you've reverted this soon after. I'm just about to commit
https://reviews.llvm.org/D24864, which will affect this slightly.
https://reviews.llvm.org/D24864 basically refactors all pthread dependencies
behind a separate API. It would be pretty strai
EricWF added a comment.
@rmaprath I'll merge this if needed. Feel free to commit your patch first.
@tavianator Do you need somebody to merge this for you?
https://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rL LLVM
https://reviews.llvm.org/D25049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
ioeric added inline comments.
> klimek wrote in MigrateTool.cpp:52
> I'm wondering whether we really want to evolve this to a callback / executor
> based design. That is, have AffectedFilesFinder give an interface like
> RunOnAffectedFiles(...)
That sounds like a good design, but I'm not sure
klimek added inline comments.
> ioeric wrote in MigrateTool.cpp:52
> That sounds like a good design, but I'm not sure if we need this at this
> point since actions on affected files would simply be renaming and include
> fixing now and in the foreseeable future.
Well, my main concern is how we
malcolm.parsons updated this revision to Diff 73019.
malcolm.parsons added a comment.
Rebase
https://reviews.llvm.org/D24965
Files:
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h
clang-tidy/utils/TypeTraits.cpp
test/clang-ti
omtcyfz updated this revision to Diff 73018.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Remove leftover from debugging.
https://reviews.llvm.org/D25074
Files:
clang-tidy/rename_check.py
Index: clang-tidy/rename_check.py
ioeric added inline comments.
> klimek wrote in MigrateTool.cpp:52
> Well, my main concern is how we hook this up to full codebase wide analyses.
> Currently, we basically hard-code the execution strategy, right?
I see. That makes sense then. Thanks!
https://reviews.llvm.org/D24380
omtcyfz updated this revision to Diff 73025.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Minor improvements.
https://reviews.llvm.org/D25024
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cp
omtcyfz added inline comments.
> omtcyfz wrote in OneNamePerDeclarationCheck.cpp:30
> Sure it can. I just thought `declCountIsGreaterThan` might be useful at some
> point.
Actually, for the sake of simplicity I'll use `unless(declCountIs(1))`, when
some other part of code would need similar st
omtcyfz added inline comments.
> alexshap wrote in rename_check.py:81
> the script always prints the args, is it intentional ?
Aw, a leftover from debugging.
Good catch! Thanks for the note!
https://reviews.llvm.org/D25074
___
cfe-commits mailing
bkramer added inline comments.
> add_new_check.py:16
>
> +from six.moves import filter
> +
Can we rely on six being available? It's not part of the default python
installation afaik.
https://reviews.llvm.org/D25019
___
cfe-commits mailing list
c
rmaprath added a comment.
In https://reviews.llvm.org/D24864#556845, @rmaprath wrote:
> I'm going to test this on a Mac before committing.
Good call that was, wouldn't have compiled there. Attaching updated patch soon.
https://reviews.llvm.org/D24864
___
rmaprath updated this revision to Diff 73033.
rmaprath added a comment.
`pthread_mach_thread_np` is Mac specific. I've introduced a Mac-only
`__libcxxabi_thread_get_port()` API call to sort this out (didn't think it
would be nice to leave a pthread call even if it is Mac specific).
I can revisi
ikudrin reopened this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.
@rmaprath: There are some issues in the test which upset build bots and I need
some time to fix them. You don't need to wait for me, I'll put my patch on the
top of yours when my fix is read
Anastasia added a comment.
Sam, I ran a few more tests and understood that the overhead mainly comes from
extra initialization (in Sema::Initialize()). Therefore, it's more noticeable
on a very small kernels. However, I agree we can probably neglect the overhead
as it account for only a couple
omtcyfz added inline comments.
> bkramer wrote in add_new_check.py:16
> Can we rely on six being available? It's not part of the default python
> installation afaik.
Yes, I am pretty sure about that. Absolute majority of Python projects relies
on having six available and Python installation wi
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Okay. If six is installed by default on Ubuntu and macOS we should be fine. The
script isn't in the critical path for anyone.
https://reviews.llvm.org/D25019
ioeric added a comment.
The code looks about right, but I am not the right person to decide whether
checks go into clang-tidy.
https://reviews.llvm.org/D25024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
omtcyfz added a comment.
UPD: This patch is eventually causing some problems in Python 3. Working on
that.
https://reviews.llvm.org/D25019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
omtcyfz added a comment.
In https://reviews.llvm.org/D25024#557033, @ioeric wrote:
> The code looks about right, but I am not the right person to decide whether
> checks go into clang-tidy.
Okay, thank you!
https://reviews.llvm.org/D25024
___
cf
On Fri, Sep 30, 2016 at 2:04 AM, Eric Liu via cfe-commits
wrote:
> I've switched the default email format to be plain text only now. This
> option should be per-user configurable, but somehow it is not shown in the
> "Settings"; I'll try if I can make the option personalized.
Thank you for workin
Thanks for the feedback Aaron! :)
I've disabled it. I think the annoying part really is the status (e.g.
Request, Closed etc) in the tag, and I am wondering if a tag with just line
numbers like "(N Loc)" would be better. But I'm not really sure about the
trade-off here.
- Eric
On Fri, Sep 30, 20
On Fri, Sep 30, 2016 at 9:21 AM, Eric Liu wrote:
> Thanks for the feedback Aaron! :)
>
> I've disabled it. I think the annoying part really is the status (e.g.
> Request, Closed etc) in the tag, and I am wondering if a tag with just line
> numbers like "(N Loc)" would be better. But I'm not really
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin.
NoQ added a subscriber: cfe-commits.
Fix clang path event diagnostics around operators `&&` and `||`. Now there's a
separate event for both sides of the operator.
Control flow pieces are unaffected - they
ahatanak added a comment.
This patch doesn't detect more complex conflicts (like the following code), but
I think it's OK for now.
asm ("foo" : "=Q" (x) : : "%rax", "%rbx", "%rcx", "%rdx"); // Q: Any register
accessible as rh: a, b, c, and d.
> TargetInfo.h:593
>///
>/// For examp
mgorny created this revision.
mgorny added reviewers: EricWF, beanz.
mgorny added a subscriber: cfe-commits.
Adjust the stand-alone build files to accept either CMake files from
LLVM_CMAKE_PATH or from LLVM_MAIN_SRC_DIR instead of requiring both. This
makes it possible to run libcxx tests on t
Author: rksimon
Date: Fri Sep 30 09:18:06 2016
New Revision: 282857
URL: http://llvm.org/viewvc/llvm-project?rev=282857&view=rev
Log:
Fix int <= bool comparison warning on MSVC
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL:
http://llvm.org/vie
Author: rksimon
Date: Fri Sep 30 09:25:09 2016
New Revision: 282858
URL: http://llvm.org/viewvc/llvm-project?rev=282858&view=rev
Log:
Strip trailing whitespace (NFCI)
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL:
http://llvm.org/viewvc/llvm-p
spatel added a comment.
Ping.
https://reviews.llvm.org/D24815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 30 September 2016 at 14:21, Eric Liu via llvm-commits
wrote:
> Thanks for the feedback Aaron! :)
>
> I've disabled it. I think the annoying part really is the status (e.g.
> Request, Closed etc) in the tag, and I am wondering if a tag with just line
> numbers like "(N Loc)" would be better. But
tahonermann added a comment.
For what it's worth, Coverity has been running with this patch in place for at
least a year and a half now. I believe the only reason it wasn't committed was
due to concerns with the test case in https://reviews.llvm.org/D9126. I
haven't had time to address those
Is there any way to disable emails when a revision is closed? I always find
those annoying, especially when it's a mass closing to clean out your
dashboard
On Fri, Sep 30, 2016 at 7:45 AM Alex Bradbury via llvm-dev <
llvm-...@lists.llvm.org> wrote:
> On 30 September 2016 at 14:21, Eric Liu via llv
@Alex I tried glancing through emails in llvm-commits, and I found
"[PATCH]" makes it easier to tell revisions from patches, and I guess
people are also used to "[PATCH]" after all these years :)
@Zachary Yes! This option can be configured in "Email Preferences" in your
personal setting, but I'm n
rnk added a comment.
I'm pretty sure GCCRegNames is used to parse constraint lists, not to parse
inline asm text. Your test should try using kN as a constraint.
Repository:
rL LLVM
https://reviews.llvm.org/D25011
___
cfe-commits mailing list
cfe
rnk added inline comments.
> x86_inlineasm_curly_bracket_escape.c:1
> +// RUN: %clang_cc1 %s -target-cpu skylake-avx512 -O0 -S -o - -Wall -Werror
> | FileCheck %s
> +// This test checks validity of inline assembly using curly brackets syntax
Please check the LLVM IR, not the assembly
Reposito
GorNishanov added inline comments.
> DiagnosticSemaKinds.td:8569
>"'%0' cannot be used in a varargs function">;
> def ext_coroutine_without_co_await_co_yield : ExtWarn<
>"'co_return' used in a function "
I am wondering, if we can handle all four cases when function can be a
coroutine.
Author: sfantao
Date: Fri Sep 30 10:34:19 2016
New Revision: 282865
URL: http://llvm.org/viewvc/llvm-project?rev=282865&view=rev
Log:
[CUDA][OpenMP] Add a generic offload action builder
Summary:
This patch proposes a new class to generate and record action dependences
related with offloading. Th
This revision was automatically updated to reflect the committed changes.
sfantao marked an inline comment as done.
Closed by commit rL282865: [CUDA][OpenMP] Add a generic offload action builder
(authored by sfantao).
Changed prior to commit:
https://reviews.llvm.org/D18172?vs=72117&id=73060#to
> On Sep 29, 2016, at 11:04 PM, Eric Liu wrote:
>
> I've switched the default email format to be plain text only now. This option
> should be per-user configurable, but somehow it is not shown in the
> "Settings"; I'll try if I can make the option personalized.
>
> Regarding new features and
Hi Eric,
Thanks for your work.
> On Sep 29, 2016, at 11:04 PM, Eric Liu via cfe-dev
> wrote:
>
> I've switched the default email format to be plain text only now. This option
> should be per-user configurable, but somehow it is not shown in the
> "Settings"; I'll try if I can make the option
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
hiraditya added a comment.
I had to revert the patch because this test case was failing. The problem was
that the destructors have different return type for different targets. So I'll
modify the testcase and put the patch back in.
Repository:
rL LLVM
https://reviews.llvm.org/D24682
_
zaks.anna added a comment.
Looks good overall. Very minor nits.
> BugReporterVisitors.cpp:1274
>
> + // In the code below, Term is a CFG terminator, and Cond is a branch
> + // condition expression upon which the decision is made on this terminator.
nit: no comma before "and".
> BugReport
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
This is ugh, but it makes us compatible with NVCC. Fixes bug 26341.
https://reviews.llvm.org/D25103
Files:
clang/lib/Parse/ParseExprCXX.cpp
clang/test/Parser/lambda-attr.cu
Index: clang
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rnk, cfe-commits.
NVCC compat. Fixes bug 30567.
https://reviews.llvm.org/D25105
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema/SemaLambda.cpp
clang/test/SemaCUDA/imp
agutowski added inline comments.
> BuiltinsX86_32.def:1
> +//===--- BuiltinsX86_32.def - X86-32 Builtin function database --*- C++
> -*-===//
> +//
Will we ever need that file? It seems to nicely complement the 64-bit one, but
if it's going to be empty forever maybe it's better to remove it.
arphaman created this revision.
arphaman added reviewers: aaron.ballman, rogfer01.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the packed member warning by showing the name of the
anonymous structure/union when it was def
rmaprath added a comment.
Sigh. I've bumped into some downstream problems. Will commit as soon as I've
verified these problems are not related to the patch.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
rnk added inline comments.
> ParseExprCXX.cpp:1135
> +// "[...]", even if there is no "(...)" before the lambda body.
> +MaybeParseGNUAttributes(Attr, &DeclEndLoc);
> + }
Does nvcc support __declspec style attributes? Maybe we should check for those
too?
> ParseExprCXX.cpp:1280
>
arphaman removed rL LLVM as the repository for this revision.
arphaman updated this revision to Diff 73076.
arphaman added a comment.
I had to reuploaded the diff as Phabricator seemed to have removed the 'lib'
and 'test' paths prefixes from the filenames in the original diff.
https://reviews.l
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> SemaExpr.cpp:8084
> +// type. Note that this is already done by non-compound assignments in
> +// CheckAssignmentConstraints. If it's a scalar type, only biscast for
> +// <1 x T
rsmith added a comment.
LGTM, go ahead when Gor is happy.
https://reviews.llvm.org/D25078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I noticed that other TSes has experimental in their SD-6 macro name, hence,
I changed it to match the concepts TS macro __cpp_experimental_concepts.
We are reviewing the wording coming Monday and can tweak the SD-6 macro as
needed.
Also, Richard mentioned in the feedback that:
>> However, we *sho
jlebar updated this revision to Diff 73085.
jlebar marked an inline comment as done.
jlebar added a comment.
Don't hallucinate a function declarator.
https://reviews.llvm.org/D25103
Files:
clang/lib/Parse/ParseExprCXX.cpp
clang/test/Parser/lambda-attr.cu
Index: clang/test/Parser/lambda-at
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> jlebar wrote in ParseExprCXX.cpp:1135
> nvcc doesn't seem to support __declspec attributes.
>
> I have no strong opinion on whether or not we should add them ourselves,
> though I guess I
Author: jlebar
Date: Fri Sep 30 12:14:53 2016
New Revision: 282880
URL: http://llvm.org/viewvc/llvm-project?rev=282880&view=rev
Log:
[CUDA] Make lambdas inherit __host__ and __device__ attributes from the scope
in which they're created.
Summary: NVCC compat. Fixes bug 30567.
Reviewers: tra
Su
Author: jlebar
Date: Fri Sep 30 12:14:48 2016
New Revision: 282879
URL: http://llvm.org/viewvc/llvm-project?rev=282879&view=rev
Log:
[CUDA] Handle attributes on CUDA lambdas appearing between [...] and (...).
Summary: This is ugh, but it makes us compatible with NVCC. Fixes bug 26341.
Reviewers
Author: jlebar
Date: Fri Sep 30 12:14:44 2016
New Revision: 282878
URL: http://llvm.org/viewvc/llvm-project?rev=282878&view=rev
Log:
[CUDA] Add missing comment on Sema::CheckCUDAVLA.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Modified: cfe/trunk/include/clang/Sema/Sema.h
URL:
http://llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282880: [CUDA] Make lambdas inherit __host__ and __device__
attributes from the scope… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25105?vs=73073&id=73089#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282879: [CUDA] Handle attributes on CUDA lambdas appearing
between [...] and (...). (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25103?vs=73085&id=73088#toc
Repository:
rL
jlebar added inline comments.
> rnk wrote in ParseExprCXX.cpp:1135
> Does nvcc support __declspec style attributes? Maybe we should check for
> those too?
nvcc doesn't seem to support __declspec attributes.
I have no strong opinion on whether or not we should add them ourselves, though
I gues
mgorny added a comment.
Combined with https://reviews.llvm.org/D25076 (on llvm), this lets me run
libcxx test suite on top of installed LLVM+lit, without LLVM sources.
https://reviews.llvm.org/D25093
___
cfe-commits mailing list
cfe-commits@lists.l
GorNishanov added a comment.
LGTM
I am happy either way. Fixes for co_return can come later.
https://reviews.llvm.org/D25078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
> ms-volatile-arm.c:2
> +// REQUIRES: arm-registered-target
> +// RUN: %clang_cc1 -triple thumbv7-win32 -emit-llvm -fms-extensions
> -fms-volatile -o - < %s | FileCheck %s
> +
You
mstorsjo added inline comments.
> majnemer wrote in ms-volatile-arm.c:2
> You don't need -fms-volatile.
Well, originally, the point was to clarify that these volatile stores end up
without atomic semantics, regardless of whether -volatile:ms has been
specified. The original version of this pat
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. Please commit!
https://reviews.llvm.org/D24759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the displayed diagnostics when encountering a redefinition
of a function whose previous definition was typo-co
dcoughlin added a comment.
Sorry, missed this patch.
I think it would good to add a test to make sure we do warn when the var decl
has an initializer, since that will not be executed.
void varDecl(int X) {
switch (X) {
int A = 12; // We do want a warning here, since the variable wil
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
There's an overload that we can use to make this a bit cleaner.
https://reviews.llvm.org/D25114
Files:
clang/lib/Parse/ParseExprCXX.cpp
Index: clang/lib/Parse/ParseExprCXX.cpp
===
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added subscribers: tra, cfe-commits.
This is probably the sane place for the attribute to go, but nvcc
specifically rejects it. Other GNU-style attributes are allowed in this
position (although judging from the warning it emits fo
majnemer added inline comments.
> mstorsjo wrote in ms-volatile-arm.c:2
> Well, originally, the point was to clarify that these volatile stores end up
> without atomic semantics, regardless of whether -volatile:ms has been
> specified. The original version of this patch (with an inline implemen
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282900: [MS] Implement __iso_volatile loads/stores as
builtins (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D24986?vs=72988&id=73113#toc
Repository:
rL LLVM
https://revi
Author: mstorsjo
Date: Fri Sep 30 14:13:46 2016
New Revision: 282900
URL: http://llvm.org/viewvc/llvm-project?rev=282900&view=rev
Log:
[MS] Implement __iso_volatile loads/stores as builtins
These are supposed to produce the same as normal volatile
pointer loads/stores. When -volatile:ms is specif
rogfer01 added a comment.
Ping?
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 73116.
ioeric added a comment.
- Remove redundant variable.
https://reviews.llvm.org/D25065
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
=
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Fri Sep 30 14:55:55 2016
New Revision: 282911
URL: http://llvm.org/viewvc/llvm-project?rev=282911&view=rev
Log:
[CUDA] Emit a warning if a CUDA host/device/global attribute is placed after
'(...)'.
Summary:
This is probably the sane place for the attribute to go, but nvcc
sp
Author: jlebar
Date: Fri Sep 30 14:55:48 2016
New Revision: 282910
URL: http://llvm.org/viewvc/llvm-project?rev=282910&view=rev
Log:
[CUDA] Fix up MaybeParseGNUAttributes call used for out-of-place attributes on
CUDA lambdas.
Summary: There's an overload that we can use to make this a bit cleane
Author: jlebar
Date: Fri Sep 30 14:55:59 2016
New Revision: 282912
URL: http://llvm.org/viewvc/llvm-project?rev=282912&view=rev
Log:
[CUDA] Remove incorrect comment in CUDASetLambdaAttrs.
I'd said that nvcc doesn't allow you to add __host__ or __device__
attributes on lambdas in all circumstances
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282911: [CUDA] Emit a warning if a CUDA host/device/global
attribute is placed after '(. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25115?vs=73105&id=73123#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282910: [CUDA] Fix up MaybeParseGNUAttributes call used for
out-of-place attributes on… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25114?vs=73104&id=73122#toc
Repository:
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, b-sumner, bader.
__builtin_astype is used to cast OpenCL opaque types to other types, as such,
it needs to be able to handle casting from and to pointer types correctly.
Current it cannot han
Author: jlebar
Date: Fri Sep 30 15:17:37 2016
New Revision: 282927
URL: http://llvm.org/viewvc/llvm-project?rev=282927&view=rev
Log:
[CUDA] Fix implicit-device-lambda.cu after r282911.
This commit added a warning that we're (correctly) hitting in this test.
Just ignore it.
Modified:
cfe/trun
phosek created this revision.
phosek added a subscriber: cfe-commits.
Provide toolchain and tool support for Fuchsia operating system. Fuchsia uses
compiler-rt as the runtime library and libc++, libc++abi and libunwind as the
C++ standard library. lld is used as a default linker.
https://revie
phosek added a comment.
The patch with LLVM triple for Fuchsia is here: https://reviews.llvm.org/D25116
https://reviews.llvm.org/D25117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
pcc added a comment.
Perhaps it would be better to enable -ffunction-sections/-fdata-sections
unconditionally at the linker level if the linker supports it? See also PR22999.
https://reviews.llvm.org/D24644
___
cfe-commits mailing list
cfe-commits@
1 - 100 of 153 matches
Mail list logo
