zaks.anna added a comment.
Looks good overall. Very minor nits.
> BugReporterVisitors.cpp:1274
>
> + // In the code below, Term is a CFG terminator, and Cond is a branch
> + // condition expression upon which the decision is made on this terminator.
nit: no comma before "and".
> BugReporterVisitors.cpp:1288
> switch (Term->getStmtClass()) {
> + // FIXME: Come up with something for switch statements?
> default:
It is not clear what the FIXME is for.
> BugReporterVisitors.cpp:1302
> + const auto *BO = cast<BinaryOperator>(Term);
> + if (!BO->isLogicalOp())
> + return nullptr;
Is this expected to ever trigger?
https://reviews.llvm.org/D25092
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
