jlebar added inline comments.
> rnk wrote in ParseExprCXX.cpp:1135 > Does nvcc support __declspec style attributes? Maybe we should check for > those too? nvcc doesn't seem to support __declspec attributes. I have no strong opinion on whether or not we should add them ourselves, though I guess I have a weak aversion to mucking with the parsing rules more than is necessary. (I put off this patch for as long as I could while I tried to get nvcc to put the attributes in the right place.) > rnk wrote in ParseExprCXX.cpp:1280 > Let's not duplicate this amazingly long type info thingy. I think you can > avoid it if you hoist MutableLoc and add a bool like > `NeedFuncDeclaratorChunk`. Also, maybe we shouldn't be hallucinating a > function declarator chunk in CUDA when there are no attributes? Oh, I didn't look closely enough at the API to realize that I could add attributes without creating a new function declarator chunk. New patch is a much smaller change. https://reviews.llvm.org/D25103 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
