mgehre added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:525
@@ +524,3 @@
+ DeclarationType = DeclarationType.getNonReferenceType();
+if (Descriptor.ElemType.isNull() || DeclarationType.isNull() ||
+!Context->hasSameUnqualifiedType(Decla
dim added a comment.
In http://reviews.llvm.org/D21329#475105, @theraven wrote:
> Looks fine to me, though I wonder if we want to move to the new ABI for
> FreeBSD11 and use the old one for <=10.
For 11 it is certainly too late now, since it is ABI/API frozen now, and we
would still need to f
rmaprath added inline comments.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
compnerd wrote:
> Early returns would be nicer imo.
Not sure if I follow, did you mean to check the bounds of `regNum`
dberris updated this revision to Diff 63038.
dberris added a comment.
- Check first whether `D` is actually not nullptr
http://reviews.llvm.org/D20352
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
dberris updated this revision to Diff 63039.
dberris added a comment.
Undo previous change -- updated the wrong patch. :(
http://reviews.llvm.org/D20352
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptio
dberris updated this revision to Diff 63040.
dberris added a comment.
- Check first whether `D` is actually not nullptr
http://reviews.llvm.org/D21983
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
dberris updated this revision to Diff 63041.
dberris added a comment.
- Check D is valid before using it
http://reviews.llvm.org/D20352
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/Code
dberris updated this revision to Diff 63042.
dberris added a comment.
Rebase
http://reviews.llvm.org/D21983
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -3193,1
v.g.vassilev requested changes to this revision.
This revision now requires changes to proceed.
Comment at: include/clang/AST/CloneDetection.h:148
@@ +147,3 @@
+/// This class only searches for clones in exectuable source code
+/// (e.g. function bodies). Other clones (e.g. cloned
hokein updated this revision to Diff 63043.
hokein marked 3 inline comments as done.
hokein added a comment.
- Address Daniel's comments.
- Add tests for nested classes.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/
hokein added inline comments.
Comment at: unittests/include-fixer/IncludeFixerTest.cpp:144
@@ -141,1 +143,3 @@
+runIncludeFixer("a::b::foo bar;\n",
+/*FixNamespaceQualifiers=*/true, IncludePath));
djasper wrote:
> I think
Hahnfeld added inline comments.
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:477-490
@@ +476,16 @@
+
+// Do the incremental linking. We write to the output file directly. So, we
+// close it and use the name to pass down to clang.
+OS.close();
+S
djasper accepted this revision.
djasper added a comment.
Looks good.
http://reviews.llvm.org/D21603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
In http://reviews.llvm.org/D21978#476200, @NoQ wrote:
> I also never noticed that the block count gets reset on every stack frame,
> that's pretty unobvious.
Yes, that was surprising for me too.
> Uhm, and it's already there in SymbolConjured. Anyway, fixing the blo
Hahnfeld added a comment.
Hi Samuel,
this looks pretty good overall!
I've only encountered one issue which I don't really know is caused by which
patch: I can't use the (exact) same triple for offloading and the host when
compiling separately. I found out that the device object file is taken a
Author: asiri
Date: Thu Jul 7 05:55:39 2016
New Revision: 274744
URL: http://llvm.org/viewvc/llvm-project?rev=274744&view=rev
Log:
[libunwind][ARM] Improve unwinder stack usage - Make WMMX support optional
These registers are only available on a limited set of ARM targets (those
based on XScale)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274744: [libunwind][ARM] Improve unwinder stack usage - Make
WMMX support optional (authored by asiri).
Changed prior to commit:
http://reviews.llvm.org/D21991?vs=62890&id=63049#toc
Repository:
rL LL
Author: abataev
Date: Thu Jul 7 06:04:06 2016
New Revision: 274745
URL: http://llvm.org/viewvc/llvm-project?rev=274745&view=rev
Log:
[OPENMP] Do not create helper expressions in dependent contexts, NFC.
OpenMP relies on some helper expressions generated during semantic
analysis. But they are req
Author: rksimon
Date: Thu Jul 7 06:12:02 2016
New Revision: 274746
URL: http://llvm.org/viewvc/llvm-project?rev=274746&view=rev
Log:
Fix "not all control paths return a value" warning on MSVC
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://ll
Author: rksimon
Date: Thu Jul 7 06:24:38 2016
New Revision: 274748
URL: http://llvm.org/viewvc/llvm-project?rev=274748&view=rev
Log:
Fix "not all control paths return a value" warning on MSVC
This time without causing a 'all enums handled' warning on other compilers.
Modified:
cfe/trunk/lib
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#475603, @majnemer wrote:
> Thinking about this some more, it is possible for clang to emit code that
> will make everybody happy:
>
> If a class is being constructed in a constexpr context and all the vftable
> entries it referen
bkramer added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
#include "llvm/Support/Host.h"
-#include
#include
This looks unrelated.
Comment at: clang-rename/tool/clang-rename.py:14
@@ +13,3 @@
+
+All you
bkramer added a comment.
In http://reviews.llvm.org/D21814#475322, @klimek wrote:
> I think we really want 2 tools:
> a) one that is optimized for oldname->newname renames, and supports the
> multi-TU case really well
> b) one that is meant to be integrated with editors and works mainly off of
omtcyf0 updated this revision to Diff 63054.
omtcyf0 marked 5 inline comments as done.
http://reviews.llvm.org/D22087
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
===
--- /dev/null
+++ clang-re
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good. Still no commit access? ;)
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, klimek.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces basic Vim integration for clang-rename tool.
For setup reference see clang-rename/tool/clang-rename.py
http://reviews.llvm.org/D22087
Files:
clang-rename/tool
ioeric added inline comments.
Comment at: clang-rename/tool/clang-rename.py:12
@@ +11,3 @@
+
+map ,cf :pyf /clang-include-fixer.py
+
Maybe a different key binding so that it doesn't conflict with include-fixer's
suggested key binding? `,cr` for clang-rename m
omtcyf0 added a comment.
Yup. FeelsBadMan.
One note about that header removal: how do I do it then? I thought attaching
such changes to a random patch is not a problem. Otherwise there will be some
one-line patches for such things, won't they?
Comment at: clang-rename/tool/Cl
AntonBikineev updated this revision to Diff 63056.
AntonBikineev added a comment.
@rsmith,
I've added some tests for c++1z init statement. Please let me know if there is
anything else I should add or change.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/
bkramer added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
#include "llvm/Support/Host.h"
-#include
#include
omtcyf0 wrote:
> bkramer wrote:
> > This looks unrelated.
> Right, but I'm not sure one-line patches are welcome
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM (once other deps land).
http://reviews.llvm.org/D21983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.py:12
@@ +11,3 @@
+
+map ,cf :pyf /clang-include-fixer.py
+
ioeric wrote:
> Maybe a different key binding so that it doesn't conflict with
> include-fixer's suggested key binding? `,cr`
alexfh added inline comments.
Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
#include "llvm/Support/Host.h"
-#include
#include
bkramer wrote:
> omtcyf0 wrote:
> > bkramer wrote:
> > > This looks unrelated.
> > Right, but I'm not sure one-li
alexfh accepted this revision.
alexfh added a comment.
LG
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.py:17
@@ +16,3 @@
+All you have to do now is to place a cursor on a variable/function/class which
+you would like to rename and press ',cf'. You will be promted a new name if the
+cursor points to a valid sym
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:525
@@ +524,3 @@
+ DeclarationType = DeclarationType.getNonReferenceType();
+if (Descriptor.ElemType.isNull() || DeclarationType
alexfh added a comment.
Thanks for the new awesome check!
Please run the check on LLVM and include your analysis of the results in the
patch description. Another couple of comments below.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:93
@@ +92,3 @@
+ continue;
omtcyf0 marked an inline comment as done.
omtcyf0 added a comment.
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyf0 updated this revision to Diff 63058.
http://reviews.llvm.org/D22087
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
===
--- /dev/null
+++ clang-rename/tool/clang-rename.py
@@ -0,0 +1,61 @@
omtcyf0 updated this revision to Diff 63057.
omtcyf0 marked 2 inline comments as done.
http://reviews.llvm.org/D22087
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
===
--- /dev/null
+++ clang-re
omtcyf0 marked an inline comment as done.
Comment at: clang-rename/tool/clang-rename.py:13
@@ +12,3 @@
+map ,cr :pyf /clang-rename.py
+
+IMPORTANT NOTE: Before running the tool, make sure you saved the file.
Aw, sure; sorry for that. That's an artifact from fi
klimek added a comment.
In http://reviews.llvm.org/D21814#476572, @bkramer wrote:
> In http://reviews.llvm.org/D21814#475322, @klimek wrote:
>
> > I think we really want 2 tools:
> > a) one that is optimized for oldname->newname renames, and supports the
> > multi-TU case really well
> > b) on
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:147
@@ +146,3 @@
+const Type *MpiTypeMismatchCheck::argumentType(const CallExpr *const CE,
+
a.sidorin created this revision.
a.sidorin added reviewers: zaks.anna, dcoughlin.
a.sidorin added a subscriber: cfe-commits.
Some FileIDs that may be used by PlistDiagnostics are not added while building
a list of pieces. This leads to assertion violation in `GetFID()` function.
This patch tries
alexfh added a comment.
Sorry for the delay. Your patch was lost in my inbox. Feel free to ping me
earlier.
Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37
@@ +36,3 @@
+
+It turns out that the common bug is to have function returning only bools but
thakis added a comment.
r274751, thanks!
http://reviews.llvm.org/D22046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Jul 7 08:19:45 2016
New Revision: 274751
URL: http://llvm.org/viewvc/llvm-project?rev=274751&view=rev
Log:
[clang-tidy] Add dependency on clang-headers
Currently, to be able to process a source file including e.g. stddef.h with
clang-tidy, one has to build both clang-tidy
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Sorry for the delay. Feel free to ping me earlier.
Comment at: clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp:38
@@ +37,3 @@
+ Finder->addMatcher(
+ cxxCon
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric.
omtcyf0 added a subscriber: cfe-commits.
This patch does the following:
* enforces proper formatting for few files (i.e. deals with 80 linewidth
violations and few other things)
* ensures '\n' chars are pass
omtcyf0 added a comment.
@bkramer can you please land the patch?
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Jul 7 09:35:32 2016
New Revision: 274759
URL: http://llvm.org/viewvc/llvm-project?rev=274759&view=rev
Log:
[clang-rename] add basic vim integration
This patch introduces basic Vim integration for clang-rename tool.
For setup reference see clang-rename/tool/clang-rename.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274759: [clang-rename] add basic vim integration (authored
by d0k).
Changed prior to commit:
http://reviews.llvm.org/D22087?vs=63058&id=63072#toc
Repository:
rL LLVM
http://reviews.llvm.org/D22087
asavonic updated this revision to Diff 63073.
asavonic added a comment.
Merged invalid-access-qualifier.cl and images-typedef.cl tests, fixed
code style issues.
http://reviews.llvm.org/D20948
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/
asavonic marked 4 inline comments as done.
asavonic added a comment.
http://reviews.llvm.org/D20948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r274751.
http://reviews.llvm.org/D22046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is
reviewed? The two patches conflict with each other, I fear. Thanks. :-)
http://reviews.llvm.org/D22091
___
cfe-
kimgr added a subscriber: kimgr.
kimgr added a comment.
I only caught this typo after it was committed.
Comment at: clang-tools-extra/trunk/clang-rename/tool/clang-rename.py:17-18
@@ +16,4 @@
+All you have to do now is to place a cursor on a variable/function/class which
+you wo
Anastasia added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
> However, we want it to be translated to __sampler_initializer* type.
bkramer added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
In LLVM we usually have only one space be
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Could you please address these last minor comments though before
committing.
Thanks!
Comment at: test/SemaOpenCL/access-qualifier.cl:10
@@ +9,3 @@
+#if __OPENCL_
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2509
@@ -2508,3 +2508,3 @@
"functions, methods, and parameters|classes|enums|variables|methods|"
- "fields and global variables|structs|variables and typedefs|thread-local
variables|"
- "
Author: mcrosier
Date: Thu Jul 7 11:37:19 2016
New Revision: 274766
URL: http://llvm.org/viewvc/llvm-project?rev=274766&view=rev
Log:
Revert "[AArch64] Change the preferred alignment for char and short to word
alignment"
This reverts commit r273280 as the change was not properly approved.
Modi
Author: bogner
Date: Thu Jul 7 11:41:08 2016
New Revision: 274770
URL: http://llvm.org/viewvc/llvm-project?rev=274770&view=rev
Log:
NVPTX: Use the nvvm builtins to read SRegs rather than the legacy ptx ones
The ptx spellings were removed from LLVM in r274769.
Modified:
cfe/trunk/include/cla
Author: mcrosier
Date: Thu Jul 7 11:37:21 2016
New Revision: 274767
URL: http://llvm.org/viewvc/llvm-project?rev=274767&view=rev
Log:
Revert "[aarch64] Update datalayout for aarch64 tests"
This reverts commit r273289, which was a follow to r273280, which was
reverted because the change was not p
tra added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:32
@@ -29,1 +31,3 @@
+ "Use --cuda-path to specify a different CUDA install, or pass "
+ "--nocuda-version-check.">;
def err_drv_invalid_thread_model_for_target : Error<
Is it s
zaks.anna accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2075
@@ +2074,3 @@
+void ExprEngine::VisitAtomicExpr(const AtomicExpr *AE, ExplodedNode *Pred,
+ ExplodedNodeSet &Dst) {
+ Exp
sfantao added a comment.
Thanks. You have to wait for Alexey to take a look at the patch too.
Thanks again,
Samuel
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
davidsh updated this revision to Diff 63090.
davidsh added a comment.
Address comments
http://reviews.llvm.org/D22075
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_messages.cpp
==
dcoughlin closed this revision.
dcoughlin added a comment.
This was committed in r274691. I forgot to add the Differential Revision line
so phabricator didn't pick it up.
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
cfe-commits@lists
Alexander_Droste updated this revision to Diff 63091.
Alexander_Droste added a comment.
- make static functions free functions
- make static containers local to their corresponding functions
- only assign the buffer type name in case of an error
- fix capitalization and punctuation in error diagno
+ Brian
Hi Anastasia,
The advantage for translating sampler variable to a global variable with
__sampler_initializer type is that it is consistent with OpenCL C++ and SPIRV,
so it is easier to translate the IR to SPIRV.
About the type name of sampler_t in LLVM, using a name without `.` allows
Alexander_Droste marked 22 inline comments as done.
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:153
@@ +152,3 @@
+ {BuiltinType::LongDouble, "MPI_C_LONG_DOUBLE_COMPLEX"}};
+
+ const auto *Builtin =
Sure, I can do that. I marked all addressed comment
omtcyf0 added inline comments.
Comment at: clang-rename/USRLocFinder.h:38
@@ -37,2 +37,2 @@
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_RENAME_USR_LOC_FINDER_H
bkramer wrote:
> In LLVM we usually have
omtcyf0 updated this revision to Diff 63093.
omtcyf0 marked an inline comment as done.
http://reviews.llvm.org/D22091
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename/USRLocFinder.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cp
jlebar updated this revision to Diff 63094.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Address review comments.
http://reviews.llvm.org/D21869
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
lib/Driver/ToolChains.cpp
lib/Driver/T
jlebar added inline comments.
Comment at: include/clang/Driver/Options.td:1722-1724
@@ -1721,2 +1721,5 @@
def nocudalib : Flag<["-"], "nocudalib">;
+def nocuda_version_check : Flag<["-"], "nocuda-version-check">,
+ HelpText<"Don't error out if the detected version of the CUDA in
dcoughlin updated this revision to Diff 63096.
dcoughlin added a comment.
Fix typo and bad indentation.
http://reviews.llvm.org/D21667
Files:
include/clang/AST/Expr.h
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/Analysis/atomic
dcoughlin marked an inline comment as done.
Comment at: test/Analysis/atomics.c:5
@@ +4,3 @@
+// because we don't fully model the atomics and instead imprecisely
+// treat their arguments as escaping.
+
Thanks! Fixed.
http://reviews.llvm.org/D21667
__
dcoughlin marked an inline comment as done.
dcoughlin added a comment.
Ping.
Richard: Would you be willing to take a quick look at the change to the AST?
http://reviews.llvm.org/D21667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Driver/ToolChains.cpp:1798
@@ +1797,3 @@
+FS.getBufferForFile(InstallPath + "/version.txt");
+if (!VersionFile) {
+ // CUDA 7.0 doesn't have a
omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.
Hi @vmiklos!
Thank you very much for contributing to clang-rename.
The patch looks nice, but it conflicts with my understanding of the view on
what the tool should do.
Generally, I do not support the idea of adding an option to perf
Author: jlebar
Date: Thu Jul 7 13:15:03 2016
New Revision: 274780
URL: http://llvm.org/viewvc/llvm-project?rev=274780&view=rev
Log:
[CUDA] Rename the __nvvm_bar0 builtin back to __syncthreads.
The builtin was renamed in r274770. But __syncthreads is part of our
user-facing API, so we need to ke
Author: jlebar
Date: Thu Jul 7 13:17:52 2016
New Revision: 274781
URL: http://llvm.org/viewvc/llvm-project?rev=274781&view=rev
Log:
[CUDA] Check that our CUDA install supports the requested architectures.
Summary:
Raise an error if you're using a CUDA installation that's too old for
the requeste
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274781: [CUDA] Check that our CUDA install supports the
requested architectures. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21869?vs=63094&id=63100#toc
Repository:
rL LLV
jlebar added a comment.
Friendly ping
http://reviews.llvm.org/D21912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bittnerbarni updated this revision to Diff 63098.
bittnerbarni added a comment.
Thank you, for your valuable comments Alexander!
http://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performanc
omtcyf0 added a comment.
@kimgr oops, sorry.
I'll send a cleanup patch.
Thanks for noticing.
Repository:
rL LLVM
http://reviews.llvm.org/D22087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
omtcyf0 created this revision.
omtcyf0 added reviewers: kimgr, alexfh, bkramer, hokein, ioeric.
omtcyf0 added a subscriber: cfe-commits.
http://reviews.llvm.org/D22100
Files:
clang-rename/tool/clang-rename.py
Index: clang-rename/tool/clang-rename.py
Author: jlebar
Date: Thu Jul 7 13:24:28 2016
New Revision: 274782
URL: http://llvm.org/viewvc/llvm-project?rev=274782&view=rev
Log:
[CUDA] s/OPT_nocuda_version_chec/OPT_no_cuda_version_check/.
Fix build breakage.
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.c
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good from a driver perspective. Aaron, you're happy with the attribute
spelling stuff, right?
It looks like you can actually land this before landing the two dependent
changes you mention and
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
In http://reviews.llvm.org/D20352#477038, @rnk wrote:
> Looks good from a driver perspective. Aaron, you're happy with the attribute
> spelling stuff, right?
No, I'm
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, klimek, bkramer, ioeric.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces few additional tests including one case the tool does not
handle yet, which should be fixed in the future.
http://reviews.llvm.org/D22102
Files
RKSimon created this revision.
RKSimon added reviewers: eli.friedman, mkuper, craig.topper, spatel, andreadb.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
D20859 and D20860 attempted to replace the SSE (V)CVTTPS2DQ and VCVTTPD2DQ
truncating con
rnk added a comment.
In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
> No, I'm not. I am worried about how this conflicts with another in-flight
> patch for supporting MS hotpatchable functions since it seems these two
> attributes do roughly the same thing. I'd like to understa
echristo added a comment.
In http://reviews.llvm.org/D20352#477203, @rnk wrote:
> In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
>
> > No, I'm not. I am worried about how this conflicts with another in-flight
> > patch for supporting MS hotpatchable functions since it seems thes
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D20352#477203, @rnk wrote:
> In http://reviews.llvm.org/D20352#477084, @aaron.ballman wrote:
>
> > No, I'm not. I am worried about how this conflicts wi
Btw we do have some advice for these situations in the programmer's manual:
http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
-- Sean Silva
On Thu, Jul 7, 2016 at 4:24 AM, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrot
Author: mcrosier
Date: Thu Jul 7 15:02:25 2016
New Revision: 274791
URL: http://llvm.org/viewvc/llvm-project?rev=274791&view=rev
Log:
[AArch64] Change the preferred alignment for char and short.
This reinstates commits r273280 and r273289.
Original Review: http://reviews.llvm.org/D21414.
Modif
vmiklos added a comment.
Kirill: OK, so you're in the camp marked as b) by Manuel. Sure, the vim
integration is nice (I'm also a vim user), now that you mentioned it, I need to
go and try it myself. ;-) Given the above patch, probably it's obvious that I'm
more in camp a). I don't insist on hav
omtcyf0 added a comment.
Miklos, thanks for the feedback!
Hm, I'm not sure about a) and b) camps here. I think we can have both. It may
be that I haven't looked too much into the code or I am missing something, but
so far both integration and cross-TU analysis seem OK together in one tool as
f
1 - 100 of 133 matches
Mail list logo
