alexfh added inline comments. ================ Comment at: clang-rename/tool/ClangRename.cpp:39 @@ -38,3 +38,2 @@ #include "llvm/Support/Host.h" -#include <cstdlib> #include <string> ---------------- bkramer wrote: > omtcyf0 wrote: > > bkramer wrote: > > > This looks unrelated. > > Right, but I'm not sure one-line patches are welcome. > > > > Is it not alright to put such into random patches? Otherwise creating > > one-liner... > I'd do it on the next change to that file, but I can also include it in the > patch this time. I generally dislike having completely unrelated changes in a > patch and the unnecessary include here doesn't really hurt anyone. > I'm not sure one-line patches are welcome.
Cleanup-only patches are fine. http://reviews.llvm.org/D22087 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
