Alexander_Droste marked 22 inline comments as done.
================
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:153
@@ +152,3 @@
+ {BuiltinType::LongDouble, "MPI_C_LONG_DOUBLE_COMPLEX"}};
+
+ const auto *Builtin =
----------------
Sure, I can do that. I marked all addressed comments with done.
================
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:272
@@ +271,3 @@
+ // Skip unknown MPI datatypes and void pointers.
+ StringRef MPIDatatype =
+ tooling::fixit::getText(*CE->getArg(DatatypeIdx), *Result.Context);
----------------
I removed the unnecessary single word comments.
================
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.cpp:272
@@ +271,3 @@
+ // Skip unknown MPI datatypes and void pointers.
+ StringRef MPIDatatype =
+ tooling::fixit::getText(*CE->getArg(DatatypeIdx), *Result.Context);
----------------
Alexander_Droste wrote:
> I removed the unnecessary single word comments.
Further, the variable now only gets assigned in case of an error.
================
Comment at: clang-tidy/misc/MpiTypeMismatchCheck.h:60
@@ +59,2 @@
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_MPI_TYPE_MISMATCH_H
----------------
I see, this removes a lot of verbosity.
http://reviews.llvm.org/D21962
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
