Re semantics, you may want to link to IWYU's docs at
https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md
.
- Kim
Den 3 maj 2016 6:34 em skrev "Manuel Klimek via cfe-commits" <
cfe-commits@lists.llvm.org>:
> klimek added inline comments.
>
> ===
kimgr added a subscriber: kimgr.
kimgr added a comment.
Re semantics, you may want to link to IWYU's docs at
https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md
.
- Kim
Den 3 maj 2016 6:34 em skrev "Manuel Klimek via cfe-commits" <
cfe-commits@lists.llvm.
nicholas marked 2 inline comments as done.
nicholas added a comment.
Richard Smith gave me some review feedback in person, the diagnostic should not
be generated when setting up the Steps for the initializer sequence, but
instead when InitializerSequence::Perform is called. This appears to work
nicholas updated this revision to Diff 56100.
http://reviews.llvm.org/D19851
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaInit.cpp
test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp
test/Parser/cxx-casting.cpp
test/SemaCXX/cstyle-cast.cpp
test/SemaCXX/functional-cast.cp
hokein updated this revision to Diff 56101.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-al
hokein added inline comments.
Comment at: include-fixer/InMemoryXrefsDB.cpp:24-26
@@ +23,5 @@
+for (const auto &Header : Entry.second) {
+ SymbolInfo Info;
+ Info.Name = Names.back();
+ Info.FilePath = Header;
+ for (auto IdentiferContext = Names.rbegin() +
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include-fixer/InMemoryXrefsDB.cpp:24-26
@@ +23,5 @@
+for (const auto &Header : Entry.second) {
+ SymbolInfo Info;
+ Info.Name = Names.back();
+
ioeric updated this revision to Diff 56104.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- Added FIXMEs and fixed a nit.
http://reviews.llvm.org/D19869
Files:
include-fixer/CMakeLists.txt
include-fixer/InMemoryXrefsDB.cpp
include-fixer/InMemoryXrefsDB.h
include-fixer
Author: ioeric
Date: Wed May 4 03:22:35 2016
New Revision: 268480
URL: http://llvm.org/viewvc/llvm-project?rev=268480&view=rev
Log:
Added XrefsDBManager into include-fixer and made XrefsDB return SymbolInfo.
Summary: Added XrefsDBManager into include-fixer and made XrefsDB return
SymbolInfo.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268480: Added XrefsDBManager into include-fixer and made
XrefsDB return SymbolInfo. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D19869?vs=56104&id=56105#toc
Repository:
rL
cdavis5x created this revision.
cdavis5x added reviewers: aaron.ballman, rnk.
cdavis5x added a subscriber: cfe-commits.
cdavis5x added a dependency: D19908: [X86] Support the "ms-hotpatch" attribute..
Based on a patch by Michael Mueller.
This attribute specifies that a function can be hooked or p
Author: mzuckerm
Date: Wed May 4 03:55:11 2016
New Revision: 268481
URL: http://llvm.org/viewvc/llvm-project?rev=268481&view=rev
Log:
[Clang][Builtin][AVX512] Adding intrinsics fot cvt{u}si2s{d|s}
cvt{sd|ss}2{ss|sd} instruction set
Differential Revision: http://reviews.llvm.org/D19765
Modifie
rmaprath created this revision.
rmaprath added reviewers: jroelofs, logan.
rmaprath added subscribers: cfe-commits, logan.
Hi Jon,
Spotted some obviously unused code in `Unwind-EHABI.cpp` while working on
something else. This seem to have been introduced in revision
`9f323e0fca08a0d60c51c4d0927
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
http://reviews.llvm.org/D19905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
klimek added a comment.
(let me know if you need me to submit this)
http://reviews.llvm.org/D19905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Note: if you intend to send more patches in the future, please consider
becoming one. It's very painless :)
On Wed, May 4, 2016 at 11:38 AM Miklos Vajna wrote:
> vmiklos added a comment.
>
> Yes, please submit it; I'm not a committer.
>
>
> http://reviews.llvm.org/D19905
>
>
>
>
klimek added a comment.
Note: if you intend to send more patches in the future, please consider
becoming one. It's very painless :)
http://reviews.llvm.org/D19905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: klimek
Date: Wed May 4 04:45:44 2016
New Revision: 268484
URL: http://llvm.org/viewvc/llvm-project?rev=268484&view=rev
Log:
When renaming a class, ename pointers to that class as well.
Patch by Miklos Vajna.
Added:
clang-tools-extra/trunk/test/clang-rename/ClassTest.cpp
Modified:
CrisCristescu updated this revision to Diff 56115.
CrisCristescu added a comment.
Addresses the previous comments and adds testing for filtering.
All the tests already in CodeCompletion are testing both the backward
compatibility and the new functionality itself.
Repository:
rL LLVM
http://
On Wed, May 4, 2016 at 12:26 AM, Richard Smith
wrote:
> On Tue, May 3, 2016 at 12:51 PM, Dmitry Polukhin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> DmitryPolukhin added a comment.
>>
>> Richard, could you please share your counterexample so I could test it on
>> my patch and GCC?
DmitryPolukhin updated this revision to Diff 56116.
DmitryPolukhin added a comment.
+ rebase
+ added testcase with Richard's example
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/SemaCXX/attr-abi-tag-syn
andreybokhanko marked 3 inline comments as done.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || is
hokein updated this revision to Diff 56120.
hokein added a comment.
Improvements based on offline discussion.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols
hokein updated this revision to Diff 56121.
hokein added a comment.
Fix a nit.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAllSymbols.h
include-fixer/find-all-sym
Author: aturetsk
Date: Wed May 4 06:10:29 2016
New Revision: 268487
URL: http://llvm.org/viewvc/llvm-project?rev=268487&view=rev
Log:
Add a test for driver options from m_x86_Features_Group.
Differential Revision: http://reviews.llvm.org/D19658
Added:
cfe/trunk/test/Driver/x86-target-featur
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268487: Add a test for driver options from
m_x86_Features_Group. (authored by aturetsk).
Changed prior to commit:
http://reviews.llvm.org/D19658?vs=55579&id=56125#toc
Repository:
rL LLVM
http://revi
vmiklos created this revision.
vmiklos added reviewers: cfe-commits, klimek.
The second "CHECK:" failed in the testcase without the code change.
http://reviews.llvm.org/D19905
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassTest.cpp
Index: test/clang-rename/ClassTest.cpp
===
vmiklos added a comment.
Yes, please submit it; I'm not a committer.
http://reviews.llvm.org/D19905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: lerochris
Date: Wed May 4 04:33:30 2016
New Revision: 268483
URL: http://llvm.org/viewvc/llvm-project?rev=268483&view=rev
Log:
[Sparc] Implement __builtin_setjmp, __builtin_longjmp back-end.
This code implements builtin_setjmp and builtin_longjmp exception handling
intrinsics for 32-bit
Author: aturetsk
Date: Wed May 4 06:19:41 2016
New Revision: 268488
URL: http://llvm.org/viewvc/llvm-project?rev=268488&view=rev
Log:
Add missing -mno-cx16 driver option.
Differential Revision: http://reviews.llvm.org/D19658
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/
Author: aturetsk
Date: Wed May 4 06:28:22 2016
New Revision: 268489
URL: http://llvm.org/viewvc/llvm-project?rev=268489&view=rev
Log:
[X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87.
Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87.
-m[no-]80387 options is added
aturetsk added a comment.
Hi,
Thanks for the review.
Committed:
1. Add a test for driver options from m_x86_Features_Group
(http://reviews.llvm.org/rL268487)
2. Add missing -mno-cx16 driver option (http://reviews.llvm.org/rL268488)
3. Add -m[no-]x87 and -m[no-]80387 options to control FeatureX8
alexfh added a comment.
Thank you for finding and fixing this! I think I used to suggest the wrong
pattern, now I won't.
Repository:
rL LLVM
http://reviews.llvm.org/D19877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
klimek closed this revision.
klimek added a comment.
Submitted as r268484
http://reviews.llvm.org/D19905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added reviewers: klimek, hokein.
ioeric added a subscriber: cfe-commits.
Added static creators that create complete instances of SymbolInfo.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:48
@@ +47,3 @@
+ explicit FindAllSymbols(ResultReporter *Reporter,
+ HeaderMapCollector *Collector)
+ : Reporter(Reporter), Collector(Collector) {}
Author: xazax
Date: Wed May 4 06:59:39 2016
New Revision: 268490
URL: http://llvm.org/viewvc/llvm-project?rev=268490&view=rev
Log:
[ASTMatchers] New matcher forFunction
Summary: Matcher proposed in the review of checker misc-assign-operator (name
pending). Its goal is to find the direct enclosi
Author: xazax
Date: Wed May 4 07:02:22 2016
New Revision: 268492
URL: http://llvm.org/viewvc/llvm-project?rev=268492&view=rev
Log:
[clang-tidy] New: checker misc-unconventional-assign-operator replacing
misc-assign-operator-signature
Summary: Finds return statements in assign operator bodies wh
xazax.hun added a comment.
Anna, will you commit this, or do you want me to commit the patches?
http://reviews.llvm.org/D12761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 56130.
hokein marked an inline comment as done.
hokein added a comment.
Update.
http://reviews.llvm.org/D19816
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all-symbols/FindAll
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:418
@@ +417,3 @@
+
+ {
+SymbolInfo Symbol =
klimek wrote:
> Any reason for the extra block here?
Because I want to keep consistence with other test case
Author: xazax
Date: Wed May 4 07:17:55 2016
New Revision: 268494
URL: http://llvm.org/viewvc/llvm-project?rev=268494&view=rev
Log:
[clang-tidy] Remove STL dependency from a test.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-unconventional-assign-operator.cpp
Modified:
clang-tool
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93
@@ +89,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumbe
klimek added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:418
@@ +417,3 @@
+
+ {
+SymbolInfo Symbol =
Why are the other test cases using an extra block?
http://reviews.llvm.org/D19816
_
hokein added a comment.
Not sure whether this is what @klimek expected..
You also need to update the FindAllSymbolsTests code (there is a
CreateSymbolInfo function there).
Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:91
@@ +90,3 @@
+void SymbolInfo::SetCommonInfo(
ioeric added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93
@@ +89,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumbe
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93
@@ +89,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumbe
mamai retitled this revision from "Do not disable completely loop unroll
according to optimization level." to "Do not disable completely loop unroll
when optimizing for size.".
mamai updated the summary for this revision.
mamai updated this revision to Diff 56133.
mamai added a comment.
Modified
Thank you!
On 02.05.2016 06:40, Justin Bogner wrote:
Igor Kudrin writes:
+ /// \brief Check whether a region with bounds \c StartLoc and \c EndLoc
+ /// is already added to \c SourceRegions.
+ bool isRegionAlreadyAdded(SourceLocation StartLoc, SourceLocation EndLoc) {
+return SourceR
Prazek retitled this revision from "Add modernize-bool-to-integer-conversion"
to "Add bugprone-bool-to-integer-conversion".
Prazek updated this revision to Diff 56138.
Prazek added a comment.
It seems that it works right now.
The other funny thing that the check found is cases like
bool b;
if (b
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D19812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ioeric updated this revision to Diff 56139.
ioeric marked 7 inline comments as done.
ioeric added a comment.
Use static creator functions in SymbolInfo in FindAllSymbolTests, and make
SymbolInfo::operator== compare all fields.
http://reviews.llvm.org/D19913
Files:
include-fixer/find-all-symb
ioeric updated this revision to Diff 56143.
ioeric added a comment.
- Use static creator functions in SymbolInfo in FindAllSymbolTests, and make
SymbolInfo::operator== compare all fields.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols
ioeric updated this revision to Diff 56145.
ioeric added a comment.
- Use template to compare llvm::Optional types.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
unittests
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:92
@@ -107,5 +91,3 @@
-SymbolInfo
-CreateSymbolInfo(StringRef Name, SymbolInfo::SymbolKind Type,
- const std::string FilePath, int LineNumber,
-
ioeric updated this revision to Diff 56147.
ioeric added a comment.
- Removed unused function in unit test.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
unittests/include
nhaustov created this revision.
nhaustov added reviewers: tstellarAMD, arsenm.
nhaustov added a subscriber: cfe-commits.
http://reviews.llvm.org/D19918
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/amdgpu-calling-conv.cl
test/CodeGenOpenCL/amdgpu-num-gpr-attr.cl
Index: test/CodeGenO
ioeric updated this revision to Diff 56148.
ioeric added a comment.
- Removed SetCommonInfo declaration from header.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
unittest
rmaprath created this revision.
rmaprath added a reviewer: jroelofs.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Currently, `unw_context_t` and `unw_cursor_t` are sized to allow the virtual
register set of any target supported by libunwind. This does no
hokein added a comment.
It looks good to me now, but need to wait @klimek acceptance.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
I think it would be better to use a generic method so the size is minimal
everywhere rather than making ARM a special case. Possibly move the #define
bits from libunwind.cpp to __libunwind_config.h and use REGISTER_K
jroelofs added a comment.
Wouldn't this break cross unwinding?
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
I agree with Tim, I think this should be more generic.
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421131, @t.p.northover wrote:
> I think it would be better to use a generic method so the size is minimal
> everywhere rather than making ARM a special case. Possibly move the #define
> bits from libunwind.cpp to __libunwind_config.h a
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
> Wouldn't this break cross unwinding?
I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks for
the pointer.
Would it make sense to support a libunwind build that only supports native
rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
To be clear, loop unrolling just lowers its size threshold when -Os is on:
// Apply size attributes
if (L->getHeader()->getParent()->
jroelofs added a comment.
In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
> In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
>
> > Wouldn't this break cross unwinding?
>
>
> I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks
> for the pointer.
>
> Wo
Author: mamai
Date: Wed May 4 10:26:28 2016
New Revision: 268509
URL: http://llvm.org/viewvc/llvm-project?rev=268509&view=rev
Log:
Do not disable completely loop unroll when optimizing for size.
Let the loop unroll pass handle /Os. It already checks that option and adjust
its thresholds accordi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268509: Do not disable completely loop unroll when
optimizing for size. (authored by mamai).
Changed prior to commit:
http://reviews.llvm.org/D19827?vs=56133&id=56158#toc
Repository:
rL LLVM
http://
Author: marshall
Date: Wed May 4 10:35:50 2016
New Revision: 268510
URL: http://llvm.org/viewvc/llvm-project?rev=268510&view=rev
Log:
Fixed some spelling errors in assert messages. No functional change. Thanks to
giffu...@yahoo.com for the report.
Modified:
libcxx/trunk/include/experimental
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421189, @jroelofs wrote:
> In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
>
> > In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
> >
> > > Wouldn't this break cross unwinding?
> >
> >
> > I wasn't aware of cross unw
rjmccall added a comment.
Yes, that looks good, thanks.
http://reviews.llvm.org/D19536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D18815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ikudrin
Date: Wed May 4 10:38:26 2016
New Revision: 268511
URL: http://llvm.org/viewvc/llvm-project?rev=268511&view=rev
Log:
[Coverage] Fix an issue where a coverage region might not be created for a
macro containing a loop statement.
The issue happened when a macro contained a full for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268511: [Coverage] Fix an issue where a coverage region
might not be created for a… (authored by ikudrin).
Changed prior to commit:
http://reviews.llvm.org/D19725?vs=55602&id=56159#toc
Repository:
rL
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumb
bcraig added a subscriber: bcraig.
bcraig added a comment.
> We could, on the other hand, do this tightening for all the supported
> architectures (for the new, native-only libunwind build suggested by
> @jroelofs) with appropriate asserts in place so that we maintain these tight
> bounds as we
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421230, @bcraig wrote:
> > We could, on the other hand, do this tightening for all the supported
> > architectures (for the new, native-only libunwind build suggested by
> > @jroelofs) with appropriate asserts in place so that we maint
rmaprath added a comment.
@mclow.lists, @EricWF: Gentle ping.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab updated this revision to Diff 56164.
filcab added a comment.
Remove unneeded comments.
Simplify code.
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/D
mamai created this revision.
mamai added a reviewer: compnerd.
mamai added a subscriber: cfe-commits.
mamai set the repository for this revision to rL LLVM.
This test have been broken by http://reviews.llvm.org/D19827, which re-enables
loop unrolling at /Os. Since the goal of this test does not s
Author: pete
Date: Wed May 4 12:37:27 2016
New Revision: 268523
URL: http://llvm.org/viewvc/llvm-project?rev=268523&view=rev
Log:
Update test CHECK lines after r268509. NFC.
r268509 causes this test case to be fully unrolled, so checking for an icmp is
no longer valid. Given that this test is
mamai abandoned this revision.
mamai added a comment.
The test have been fixed otherwise in rev 268523.
Repository:
rL LLVM
http://reviews.llvm.org/D19925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
etienneb updated this revision to Diff 56173.
etienneb marked 4 inline comments as done.
etienneb added a comment.
address alexfh comments
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/
etienneb added a comment.
Aaron? could you comment on it?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
aaron.ballman wrote:
> Split these onto two lines?
I
Author: ahatanak
Date: Wed May 4 13:07:20 2016
New Revision: 268527
URL: http://llvm.org/viewvc/llvm-project?rev=268527&view=rev
Log:
[ObjC] Enter a new evaluation context before calling
BuildBlockForLambdaConversion.
Previously, clang would build an incorrect AST for the following code:
id tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268527: [ObjC] Enter a new evaluation context before calling
(authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D18815?vs=56092&id=56178#toc
Repository:
rL LLVM
http://reviews.
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
etienneb wrote:
> aaron.ballman wrote:
> > Split these onto two lines?
> If
Prazek added a comment.
In http://reviews.llvm.org/D18919#419902, @curdeius wrote:
> I'm really interested in the manner this check works when a typedef has
> multiple declarations in it (same example as in the comment):
>
> typedef int m_int, *m_int_p, &m_int_r, m_int_arr[10], (&m_int_fun)(in
On Wed, May 4, 2016 at 2:41 PM, Piotr Padlewski via cfe-commits
wrote:
> Prazek added a comment.
>
> In http://reviews.llvm.org/D18919#419902, @curdeius wrote:
>
>> I'm really interested in the manner this check works when a typedef has
>> multiple declarations in it (same example as in the comme
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268532: [CodeGenObjCXX] Fix handling of blocks in lambda.
(authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D19536?vs=56090&id=56183#toc
Repository:
rL LLVM
http://reviews.llv
Author: ahatanak
Date: Wed May 4 13:40:33 2016
New Revision: 268532
URL: http://llvm.org/viewvc/llvm-project?rev=268532&view=rev
Log:
[CodeGenObjCXX] Fix handling of blocks in lambda.
This fixes a crash that occurs when a block captures a reference that is
captured by its enclosing lambda.
rdar
aaron.ballman added a comment.
Generally, I think this should make use of the patchable function functionality
from http://reviews.llvm.org/D19046 when lowering, but I do have some comments
on the attribute itself as well.
Comment at: include/clang/Basic/Attr.td:2032
@@ -2031,
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This generally LGTM, but you should wait for @rsmith to sign off before
committing.
Comment at: test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp:39
@@ -38,3 +38,
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
I believe we use "modernize" to really mean "migrate from the old way to
aaron.ballman added a comment.
In http://reviews.llvm.org/D19062#41, @twoh wrote:
> Ping. Can someone please commit this patch for me? Thanks!
Can you rebase the diff on ToT and update the review with the new patch? When I
try to apply, I get merge conflicts. Thanks!
http://reviews.llvm.
On Tue, May 3, 2016 at 12:18 PM, Ettore Speziale
wrote:
> Hello,
>
> the attached patch introduces the `convergent` attribute.
>
> It is meant to be lowered into the LLVM `convergent` attribute, to restrict
> optimizations of attributed functions — e.g. you can attach convergent to
> OpenCL’s ba
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Use pushCleanupAfterFullExpr to add lifetime.end markers for
lifetime-extended temporaries, similar to the way destructor calls get
generated.
It does not change the AST representation. It
yaxunl created this revision.
yaxunl added reviewers: Anastasia, pxli168.
yaxunl added subscribers: cfe-commits, tstellarAMD.
OpenCL builtin functions to_{global|local|private} accepts argument of pointer
type to arbitrary pointee type, and return a pointer to the same pointee type
in different
1 - 100 of 146 matches
Mail list logo
