andreybokhanko marked 3 inline comments as done.
================
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+ // Presence of __unaligned qualifier shouldn't affect mangling here.
+ Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa<TagType>(T)) {
----------------
majnemer wrote:
> andreybokhanko wrote:
> > Done. Test added.
> Hmm, can you give a concrete example why we need this line?
Sure. An example is:
__unaligned int unaligned_foo3() { return 0; }
MS mangles it as
?unaligned_foo3@@YAHXZ
However, if __unaligned is taken into account, "if ((!IsPointer && Quals) ||
isa<TagType>(T))" computes to true and clang adds "?A", resulting to
?unaligned_foo3@@YA?AHXZ
Yours,
Andrey
http://reviews.llvm.org/D19654
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
