[libcxx] r268009 - Fix PR21428 for long. Buffer was one byte too small in octal formatting case. Rename previously added test

Author: ericwf Date: Fri Apr 29 02:23:20 2016 New Revision: 268009 URL: http://llvm.org/viewvc/llvm-project?rev=268009&view=rev Log: Fix PR21428 for long. Buffer was one byte too small in octal formatting case. Rename previously added test Added: libcxx/trunk/test/std/input.output/iostream.

r268013 - [Clang][AVX512][Builtin] Adding intrinsics for compress instruction set

Author: mzuckerm Date: Fri Apr 29 03:52:02 2016 New Revision: 268013 URL: http://llvm.org/viewvc/llvm-project?rev=268013&view=rev Log: [Clang][AVX512][Builtin] Adding intrinsics for compress instruction set Differential Revision: http://reviews.llvm.org/D19599 Modified: cfe/trunk/include/cl

[clang-tools-extra] r268017 - [include-fixer] Add Yaml database integration.

Author: hokein Date: Fri Apr 29 04:23:38 2016 New Revision: 268017 URL: http://llvm.org/viewvc/llvm-project?rev=268017&view=rev Log: [include-fixer] Add Yaml database integration. Reviewers: bkramer Subscribers: cfe-commits, klimek, djasper Differential Revision: http://reviews.llvm.org/D19648

Re: [PATCH] D19648: [include-fixer] Add Yaml database integration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268017: [include-fixer] Add Yaml database integration. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19648?vs=55412&id=3#toc Repository: rL LLVM http://reviews.llvm.org

r268018 - Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev.

Author: abataev Date: Fri Apr 29 04:39:50 2016 New Revision: 268018 URL: http://llvm.org/viewvc/llvm-project?rev=268018&view=rev Log: Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev. This enables GNU C++ extension "Variable length array" by default. Differential Revision: http://

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL268018: Implementation of VlA of GNU C++ extension, by Vladimir Yakovlev. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D18823?vs=53658&id=4#toc Repository: rL LLVM htt

[clang-tools-extra] r268019 - [find-all-symbols] Save absolute file path instead of relative file path in SymbolInfo.

Author: hokein Date: Fri Apr 29 04:45:09 2016 New Revision: 268019 URL: http://llvm.org/viewvc/llvm-project?rev=268019&view=rev Log: [find-all-symbols] Save absolute file path instead of relative file path in SymbolInfo. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: http:/

Re: [PATCH] D15654: A Python code model for C++ used to drive code generators

jbcoe abandoned this revision. jbcoe added a comment. I'm abandoning this revision for lack of interest. http://reviews.llvm.org/D15654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

sbaranga updated this revision to Diff 5. sbaranga added a comment. Don't change the AArch64 intrinsics and move the test to Sema. http://reviews.llvm.org/D19665 Files: include/clang/Basic/arm_neon.td test/Sema/arm-no-fp16.c Index: include/clang/Basic/arm_neon.td ==

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

sbaranga added inline comments. Comment at: include/clang/Basic/arm_neon.td:710-711 @@ -709,2 +709,4 @@ + def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "wd", "h">; +} def VCVT_S32 : SInst<"vcvt_s32", "xd", "fQf">; Thanks for catching this! http://reviews.llv

Re: [PATCH] D19647: [find-all-symbols] Save absolute file path instead of relative file path in SymbolInfo.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268019: [find-all-symbols] Save absolute file path instead of relative file path in… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19647?vs=55398&id=6#toc Repository: rL

r268020 - [OPENMP] Fix detection of explicit data-sharing attributes in templates.

Author: abataev Date: Fri Apr 29 04:56:11 2016 New Revision: 268020 URL: http://llvm.org/viewvc/llvm-project?rev=268020&view=rev Log: [OPENMP] Fix detection of explicit data-sharing attributes in templates. Fixes a bug with analysis of data-sharing attributes in templates. Modified: cfe/trun

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 2 inline comments as done. Comment at: clang-tidy/boost/UseToStringCheck.cpp:38 @@ +37,3 @@ + argumentCountIs(1), unless(isInTemplateInstantiation())) + .bind("to_string"), + this); alexfh wrote: > clang-format? nope, everythin

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek abandoned this revision. Prazek added a comment. Merged with boost-use-to-string http://reviews.llvm.org/D18274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18136: boost-use-to-string check

Prazek updated this revision to Diff 8. Prazek marked an inline comment as done. Prazek added a comment. merged with boost module http://reviews.llvm.org/D18136 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/boost/Use

[PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

bkramer created this revision. bkramer added a reviewer: hokein. bkramer added a subscriber: cfe-commits. If multiple find-all-symbols processes access the temporary directory simultaneously with two files with the same name they would collide and create a broken yaml file. Fix this by using the s

Re: [PATCH] D19622: [libc++] Implement the member functions of a local struct.

On 28.04.2016 04:25, Eric Fiselier via cfe-commits wrote: EricWF closed this revision. EricWF added a comment. r267843. This warning seems a bit silly though. And here I thought this warning was gone after VS 2008, given that its dedicated warning page was removed. But it's apparently stil

Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! LGTM with one nit. Comment at: include-fixer/find-all-symbols/SymbolInfo.h:92 @@ +91,3 @@ +/// \brief Write SymbolInfos to a stream (YAML format). +bool WriteSymbolInf

[clang-tools-extra] r268021 - [find-all-symbols] Fix racy yaml file writing.

Author: d0k Date: Fri Apr 29 05:16:28 2016 New Revision: 268021 URL: http://llvm.org/viewvc/llvm-project?rev=268021&view=rev Log: [find-all-symbols] Fix racy yaml file writing. If multiple find-all-symbols processes access the temporary directory simultaneously with two files with the same name t

Re: [PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268021: [find-all-symbols] Fix racy yaml file writing. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19717?vs=9&id=55562#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 7. rmaprath added a comment. In http://reviews.llvm.org/D19412#416183, @EricWF wrote: > OK. I *think* this is my last round of review comments except for one > specific issue. I'm still looking into the changes to the static mutex's and > condition_var

[clang-tools-extra] r268022 - Make run-find-all-symbols executable.

Author: d0k Date: Fri Apr 29 05:33:11 2016 New Revision: 268022 URL: http://llvm.org/viewvc/llvm-project?rev=268022&view=rev Log: Make run-find-all-symbols executable. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/run-find-all-symbols.py (contents, props changed)

r268028 - [clang][BuiltIn][AVX512]Adding intrinsics for cmp{ss|sd} instruction set.

Author: mzuckerm Date: Fri Apr 29 06:01:16 2016 New Revision: 268028 URL: http://llvm.org/viewvc/llvm-project?rev=268028&view=rev Log: [clang][BuiltIn][AVX512]Adding intrinsics for cmp{ss|sd} instruction set. Differential Revision: http://reviews.llvm.org/D19601 Modified: cfe/trunk/include/

Re: [PATCH] D19156: [ms][dll] #27212: Generating of implicit special members should take into account MSVC compatibility version

avt77 updated this revision to Diff 55567. avt77 added a comment. Now it's really a micro-patch: please review. http://reviews.llvm.org/D19156 Files: lib/Sema/SemaDeclCXX.cpp test/CodeGenCXX/dllexport.cpp Index: lib/Sema/SemaDeclCXX.cpp =

r268029 - Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)"

Author: dzobnin Date: Fri Apr 29 06:27:00 2016 New Revision: 268029 URL: http://llvm.org/viewvc/llvm-project?rev=268029&view=rev Log: Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)" Slightly updated version, double-checked build and tests. Improve implementation of MS p

Re: [PATCH] D19361: [MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268029: Recommit "[MS] Improved implementation of stack pragmas (vtordisp, *_seg)" (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D19361?vs=54484&id=55568#toc Repository: rL

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55570. rmaprath added a comment. Re-sync with http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support Index: include/__threading_support === --- in

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55569. rmaprath added a comment. Minor tweak: Got rid of the unnecessary template parameters on `__libcpp_thread_create` and `__libcpp_tl_create`. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__threading_suppor

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55571. rmaprath added a comment. Missed one: s/_LIBCPP_COND_INITIALIZER/_LIBCPP_CONDVAR_INITIALIZER http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__threading_support include/mutex include/thread src/algorit

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55573. rmaprath added a comment. Minor re-spin on http://reviews.llvm.org/D19412. http://reviews.llvm.org/D19415 Files: include/__threading_support Index: include/__threading_support === --

[PATCH] D19720: [find-all-symbols] Parallelize the merge step.

bkramer created this revision. bkramer added reviewers: hokein, djasper. bkramer added a subscriber: cfe-commits. There is still more parallelism to get here because we synchonize on the actual uniquing but just doing YAML parsing in parallel already gives a significant speedup. Merging all symbo

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

bkramer updated this revision to Diff 55577. bkramer added a comment. Drain the pool, fix typo. http://reviews.llvm.org/D19720 Files: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp Index: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp =

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

hokein added inline comments. Comment at: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp:107 @@ -94,3 +106,3 @@ } llvm::raw_fd_ostream OS(OutputFile, EC, llvm::sys::fs::F_None); Don't we need to all 'Pool.wait()' to wait for all working threads

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Just see you updated code. LGTM. http://reviews.llvm.org/D19720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk updated this revision to Diff 55579. aturetsk added a comment. Add a missing option and a test. http://reviews.llvm.org/D19658 Files: include/clang/Driver/Options.td test/Driver/x86-target-features.c Index: test/Driver/x86-target-features.c

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk added a comment. Hi, Thanks for the review. All m_x86_Features_Group options are handled in function handleTargetFeaturesGroup from lib/Driver/Tools.cpp, so there is no additional code needed. There was no test for this, so I added a new one trying to cover all options from m_x86_Featu

Re: [PATCH] D19361: [MS] Improved implementation of MS stack pragmas (vtordisp, *_seg)

d.zobnin.bugzilla added a comment. Reid, thanks for review! I've changed the patch according to your comments and also moved implementation of RAII object to SemaAttr.cpp file (implementation in header broke many buildbots). Nico, I will look at serialization and try to implement the desired be

[PATCH] D19721: Fix crash in BuildCXXDefaultInitExpr.

teemperor created this revision. teemperor added reviewers: cfe-commits, rnk. Fix crash in BuildCXXDefaultInitExpr when member of template class has same name as the class itself. http://reviews.llvm.org/D19721 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/pr27047-default-init-expr-name-c

Re: [PATCH] D18700: [Inline asm][GCC compatibility] Handle %v-prefixed code in inline assembly

d.zobnin.bugzilla updated this revision to Diff 55581. d.zobnin.bugzilla added a comment. Herald added a subscriber: joker.eph. Updated the patch after r266292 commit: [ASTImporter] Implement some expression-related AST node import. http://reviews.llvm.org/D18700 Files: include/clang/AST/Stm

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

andreybokhanko updated this revision to Diff 55588. andreybokhanko added a comment. Fixed a bug uncovered by David Majnemer's review; added tests he asked for. http://reviews.llvm.org/D19654 Files: include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h include/clang/Basic/Attr.td

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

andreybokhanko marked 3 inline comments as done. andreybokhanko added a comment. David, thank you for the review! In http://reviews.llvm.org/D19654#416408, @majnemer wrote: > It would be good to have a test for the variable template case: > > template > T x; > > auto g() { return x; } >

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268037: [find-all-symbols] Parallelize the merge step. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19720?vs=55577&id=55589#toc Repository: rL LLVM http://reviews.llvm.org/D1

[clang-tools-extra] r268037 - [find-all-symbols] Parallelize the merge step.

Author: d0k Date: Fri Apr 29 07:46:27 2016 New Revision: 268037 URL: http://llvm.org/viewvc/llvm-project?rev=268037&view=rev Log: [find-all-symbols] Parallelize the merge step. There is still more parallelism to get here because we synchonize on the actual uniquing but just doing YAML parsing in

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This turns out to be a bit of a mess: Alias and NoDebug use the same diagnostic kind text, neither of which match the actual subject list. Alias doesn't appertain to an obj-c met

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55593. rmaprath added a comment. Added missing `__confg` header include. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__threading_support include/mutex include/thread src/algorithm.cpp src/condition_vari

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:175 @@ -152,2 +174,3 @@ + Expr *RequiresClause; public: faisalv wrote: > Yuk - this entire guy (FizedSizeTemplateParameterListStorage) seems quite > fragile (dependent

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. Looks good. Thanks for updating the patch. Tim. http://reviews.llvm.org/D19665 ___

Re: [PATCH] D19183: [clang-tidy] Add modernize-make-shared check

Prazek added a subscriber: alexfh. Prazek added a comment. ping. @alexfh are you planning to take a look? http://reviews.llvm.org/D19183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r268047 - [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

Author: sbaranga Date: Fri Apr 29 10:03:32 2016 New Revision: 268047 URL: http://llvm.org/viewvc/llvm-project?rev=268047&view=rev Log: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP Summary: Conversions between float and half are only available when

Re: [PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

sbaranga added a comment. Thanks, r268047! Cheers, Silviu http://reviews.llvm.org/D19665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

yaxunl updated this revision to Diff 55600. yaxunl added a comment. Add defining macro cl_khr_ for supported extensions or optional core features. Enable supported extensions or optional core features only if it is available in the OpenCL version the program is compiled with. Add spir triple to

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

manmanren added a comment. Adrian, Thanks for reviewing the patch! Manman Comment at: include/clang/Serialization/ASTReader.h:657 @@ +656,3 @@ + /// Whether a selector is out of date. We mark a selector as out of date + // if we load another module after the method pool entr

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

On Thu, Apr 28, 2016 at 4:46 PM, Robinson, Paul wrote: > Generally tests test something other than "this program doesn't crash" - > should it test that we apply the attribute correctly? (either via ast dump, > or checking the resulting DWARF doesn't have debug info on the relevant > entity) > > O

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

As mentioned in the bug, I /think/ the right thing to do here is to change the preferred location of the CXXMemberCallExpr so that we improve diagnostics as well. Any place where the preferred location of an expression and the debug location of an expression are differing I'd really like a pretty d

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

On Thu, Apr 28, 2016 at 4:42 PM, Adrian Prantl wrote: > > On Apr 28, 2016, at 4:31 PM, David Blaikie wrote: > > > > On Thu, Apr 28, 2016 at 1:11 PM, Adrian Prantl wrote: > >> >> On Apr 28, 2016, at 12:53 PM, David Blaikie wrote: >> >> >> >> On Thu, Apr 28, 2016 at 12:50 PM, Adrian Prantl >> w

Re: [PATCH] D19666: [ubsan] Add -fubsan-strip-path-components=N

filcab updated this revision to Diff 55605. filcab marked 2 inline comments as done. filcab added a comment. Addressed Richard's comments. Waiting on http://reviews.llvm.org/D19724 (operator- on Path's reverse_iterator) before landing this. http://reviews.llvm.org/D19666 Files: docs/Undefine

[PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

ikudrin created this revision. ikudrin added reviewers: bogner, davidxl, vsk. ikudrin added a subscriber: cfe-commits. The situation happened when a macro contained a full loop statement, which body ended at the end of the macro. http://reviews.llvm.org/D19725 Files: lib/CodeGen/CoverageMappin

[PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

d.zobnin.bugzilla created this revision. d.zobnin.bugzilla added a reviewer: rnk. d.zobnin.bugzilla added subscribers: thakis, cfe-commits. An attempt to make implementation of #pragma pack consistent with other "stack" pragmas. Also modifies #pragma options align, since it shares the stack with

Re: [PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

d.zobnin.bugzilla added inline comments. Comment at: lib/Sema/SemaAttr.cpp:277-278 @@ -276,4 @@ - // empty. - Diag(PragmaLoc, diag::warn_pragma_pop_failed) - << "pack" << (Name ? "no record matching name" : "stack empty"); - Here I removed the "

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

aprantl added inline comments. Comment at: test/Modules/method_pool_write.m:3 @@ +2,3 @@ +// RUN: %clang_cc1 -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -I %S/Inputs %s -verify +// expected-no-diagnostics + manmanren wrote: > aprantl wrote: > > Is th

r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Fri Apr 29 11:08:08 2016 New Revision: 268055 URL: http://llvm.org/viewvc/llvm-project?rev=268055&view=rev Log: Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 in r267004. Added: cfe/trunk/test/CodeGenCXX/d

Re: [PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/StringConstructorCheck.cpp:110 @@ -106,2 +109,3 @@ if (Result.Nodes.getNodeAs("swapped-parameter")) { -diag(Loc, "constructor parameters are probably swappe

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

hfinkel updated this revision to Diff 55610. hfinkel added a comment. Use David's suggested approach: Modify the preferred expression location for member calls. If the callee has a valid location (not all do), then use that. Otherwise, fall back to the starting location. This seems to cleanly fi

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

probinson added a comment. I'll proceed from here without doing anything about the inconsistencies, because this particular one should go away and you're already doing something about the rest of it. Comment at: include/clang/Basic/Attr.td:977 @@ -976,1 +976,3 @@ + let Subjec

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

On Fri, Apr 29, 2016 at 12:24 PM, Paul Robinson wrote: > probinson added a comment. > > I'll proceed from here without doing anything about the inconsistencies, > because this particular one should go away and you're already doing something > about the rest of it. I think that's a good idea. :-

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

Seems a much more principled solution yes. On Fri, Apr 29, 2016, 9:19 AM Hal Finkel wrote: > hfinkel updated this revision to Diff 55610. > hfinkel added a comment. > > Use David's suggested approach: Modify the preferred expression location > for member calls. If the callee has a valid location

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

echristo added a subscriber: echristo. echristo added a comment. Seems a much more principled solution yes. http://reviews.llvm.org/D19708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D19721: Fix crash in BuildCXXDefaultInitExpr.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/SemaCXX/pr27047-default-init-expr-name-conflict.cpp:6 @@ +5,3 @@ +template +struct B { + More reduced: template struct A { int A = 0; };

Re: [PATCH] D19590: Check for CERT ERR34-C. Detect errors when converting a string to a number

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a few nits. Comment at: clang-tidy/cert/StrToNumCheck.cpp:182 @@ +181,3 @@ +void StrToNumCheck::check(const MatchFinder::MatchResult &Result) { + const auto *

Re: r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

Hi Amjad Either this change, or r268054, appears to have broken the bots. Can you please take a look? The error at: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/22409/consoleFull#8333002949ba4694-19c4-4d7e-bec5-911270d8a58c

Re: [PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: include/clang/Sema/Sema.h:354-357 @@ -356,6 +353,6 @@ }; void Act(SourceLocation PragmaLocation, PragmaMsStackAction Action, l

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL268065: Add a Subjects line to NoDebugAttr [NFC]. (authored by probinson). Changed prior to commit: http://reviews.llvm.org/D19689?vs=55482&id=55618#toc Repository: rL LLVM http://reviews.llvm.org/D

r268065 - Add a Subjects line to NoDebugAttr [NFC].

Author: probinson Date: Fri Apr 29 12:03:34 2016 New Revision: 268065 URL: http://llvm.org/viewvc/llvm-project?rev=268065&view=rev Log: Add a Subjects line to NoDebugAttr [NFC]. The 'nodebug' attribute had hand-coded constraints; replace those with a Subjects line in Attr.td. Also add a missing t

RE: r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

Sorry for that, I broke a LIT test that I added few days ago. The LIT test need to be fixed and I already fixed it in r268063. Let's wait till r268063 run bots and see that everything will pass. Thanks, Amjad From: peter_coo...@apple.com [mailto:peter_coo...@apple.com] Sent: Friday, April 29, 201

Re: [PATCH] D19586: Misleading Indentation check

etienneb requested changes to this revision. etienneb added a comment. This revision now requires changes to proceed. Could you lift some logics to the matcher instead of the check. Comment at: clang-tidy/readability/MisleadingIndentationCheck.cpp:22 @@ +21,3 @@ +const Match

Re: r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

> On Apr 29, 2016, at 10:27 AM, Aboud, Amjad wrote: > > Sorry for that, I broke a LIT test that I added few days ago. > The LIT test need to be fixed and I already fixed it in r268063. No problem. Thanks for the quick reply. > > Let’s wait till r268063 run bots and see that everything will pa

Re: [PATCH] D19586: Misleading Indentation check

etienneb added a comment. You should not limit the checker to "if". The for-statement and while-statement are also wrong for the same reasons: while (x) statement1(); statement2(); for (...) statement1(); statement2(); You should test your code over large code base. You sh

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

rob.lougher added a comment. No problem. Thanks for the code review. http://reviews.llvm.org/D16298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19586: Misleading Indentation check

xazax.hun added a comment. In http://reviews.llvm.org/D19586#417053, @etienneb wrote: > The rule also apply for statements in a same compound: > > { > statement1(); > statement2(); > statement3(); > > > But this can be a further improvement. I believe this might be an intentiona

r268075 - Improve test coverage of -Wdouble-promotion

Author: rlougher Date: Fri Apr 29 12:44:29 2016 New Revision: 268075 URL: http://llvm.org/viewvc/llvm-project?rev=268075&view=rev Log: Improve test coverage of -Wdouble-promotion This patch adds coverage for additional cases where implicit conversion can occur (assignment and return). It also ad

Re: [PATCH] D16298: Improve test coverage of -Wdouble-promotion

This revision was automatically updated to reflect the committed changes. Closed by commit rL268075: Improve test coverage of -Wdouble-promotion (authored by rlougher). Changed prior to commit: http://reviews.llvm.org/D16298?vs=45195&id=55625#toc Repository: rL LLVM http://reviews.llvm.org/

[clang-tools-extra] r268076 - small reformat to test access

Author: prazek Date: Fri Apr 29 12:45:20 2016 New Revision: 268076 URL: http://llvm.org/viewvc/llvm-project?rev=268076&view=rev Log: small reformat to test access Modified: clang-tools-extra/trunk/clang-tidy/modernize/PassByValueCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/moderniz

Re: [PATCH] D19586: Misleading Indentation check

etienneb added a comment. In http://reviews.llvm.org/D19586#417063, @xazax.hun wrote: > In http://reviews.llvm.org/D19586#417053, @etienneb wrote: > > > The rule also apply for statements in a same compound: > > > > { > > statement1(); > > statement2(); > > statement3(); > > > > >

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

beanz updated this revision to Diff 55626. beanz added a comment. Adding a test case, and properly rebasing on trunk. http://reviews.llvm.org/D19693 Files: lib/Basic/Targets.cpp test/Preprocessor/arm-target-features.c Index: test/Preprocessor/arm-target-features.c =

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks good. Thanks Chris! http://reviews.llvm.org/D19693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r268078 - [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

Author: cbieneman Date: Fri Apr 29 12:53:00 2016 New Revision: 268078 URL: http://llvm.org/viewvc/llvm-project?rev=268078&view=rev Log: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI Summary: The Darwin armv7k ABI uses Dwarf EH, so we need to set the OS define correctly. Without this the g

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL268078: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D19693?vs=55626&id=55627#toc Repository: rL LLVM http://reviews

[clang-tools-extra] r268079 - Add boost-use-to-string

Author: prazek Date: Fri Apr 29 12:58:29 2016 New Revision: 268079 URL: http://llvm.org/viewvc/llvm-project?rev=268079&view=rev Log: Add boost-use-to-string http://reviews.llvm.org/D18136 Added: clang-tools-extra/trunk/clang-tidy/boost/ clang-tools-extra/trunk/clang-tidy/boost/BoostTidyM

RE: [PATCH] D19622: [libc++] Implement the member functions of a local struct.

[Sebastian Redl] > I rail against this warning here: > http://stackoverflow.com/questions/18979503/why-locally-defined-struct-in-function-need-assignment-operator-copy-construct/18979812#18979812 > It's not just that the warning is silly, it's also a level 1 warning, which > is extra-silly. (MSVC'

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

If I add an assert to check (F != Flags) in setFlags, 2700+ out of 5000+ clang regression tests fail. I haven’t figured out which parts of clang are passing the same value to setFlags. > On Apr 28, 2016, at 7:38 PM, Richard Smith via cfe-commits > wrote: > > On Thu, Apr 28, 2016 at 7:34 PM, A

Re: [PATCH] D19220: [Concepts] Pass requires-clause to ActOnTemplateParameterList; NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL268081: [Concepts] Pass requires-clause to ActOnTemplateParameterList; NFC (authored by hubert.reinterpretcast). Changed prior to commit: http://reviews.llvm.org/D19220?vs=54050&id=55629#toc Repository

r268081 - [Concepts] Pass requires-clause to ActOnTemplateParameterList; NFC

Author: hubert.reinterpretcast Date: Fri Apr 29 13:05:37 2016 New Revision: 268081 URL: http://llvm.org/viewvc/llvm-project?rev=268081&view=rev Log: [Concepts] Pass requires-clause to ActOnTemplateParameterList; NFC Summary: Prepare to store requires-clause expression for access via TemplateParam

r268082 - Fix crash in BuildCXXDefaultInitExpr.

Author: rnk Date: Fri Apr 29 13:06:53 2016 New Revision: 268082 URL: http://llvm.org/viewvc/llvm-project?rev=268082&view=rev Log: Fix crash in BuildCXXDefaultInitExpr. Fix crash in BuildCXXDefaultInitExpr when member of template class has same name as the class itself. Based on patch by Raphael

Re: [PATCH] D19721: Fix crash in BuildCXXDefaultInitExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268082: Fix crash in BuildCXXDefaultInitExpr. (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D19721?vs=55580&id=55631#toc Repository: rL LLVM http://reviews.llvm.org/D19721 Fil

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

doug.gregor added a comment. Mostly looks good, but see my comment about MapVector invalidation. Comment at: lib/Serialization/ASTWriter.cpp:4394 @@ +4393,3 @@ + // date, so we need to pull in the new content here. + for (auto &SelectorAndID : SelectorIDs) +SemaRef.updateO

Re: [PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

vsk added a comment. Thanks, lgtm with a nit. Comment at: lib/CodeGen/CoverageMappingGen.cpp:452 @@ +451,3 @@ +[=](const SourceMappingRegion &Region) { + assert(Region.hasStartLoc() && "incomplete region"); +

r268085 - [MS] Make #pragma pack use PragmaStack<> class.

Author: dzobnin Date: Fri Apr 29 13:17:40 2016 New Revision: 268085 URL: http://llvm.org/viewvc/llvm-project?rev=268085&view=rev Log: [MS] Make #pragma pack use PragmaStack<> class. Make implementation of #pragma pack consistent with other "stack" pragmas. Use PragmaStack<> class instead of old r

Re: [PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rL268085: [MS] Make #pragma pack use PragmaStack<> class. (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D19727?vs=55598&id=55634#toc Repository: rL LLVM http://reviews.llvm.o

Re: [PATCH] D19687: Set PIELevel module flag

tmsriram closed this revision. tmsriram added a comment. 267948 http://reviews.llvm.org/D19687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

On Fri, Apr 29, 2016 at 11:07 AM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > If I add an assert to check (F != Flags) in setFlags, 2700+ out of 5000+ > clang regression tests fail. I haven’t figured out which parts of clang are > passing the same value to setFlags. > Wh

  1   2   >