aturetsk added a comment. Hi, Thanks for the review. All m_x86_Features_Group options are handled in function handleTargetFeaturesGroup from lib/Driver/Tools.cpp, so there is no additional code needed. There was no test for this, so I added a new one trying to cover all options from m_x86_Features_Group.
================ Comment at: include/clang/Driver/Options.td:1406 @@ -1403,2 +1405,3 @@ def mno_sha : Flag<["-"], "mno-sha">, Group<m_x86_Features_Group>; +def mno_cx16 : Flag<["-"], "mno-cx16">, Group<m_x86_Features_Group>; def mno_fxsr : Flag<["-"], "mno-fxsr">, Group<m_x86_Features_Group>; ---------------- The test showed me that this flag is missing so I added it. http://reviews.llvm.org/D19658 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
