doug.gregor added a comment. Mostly looks good, but see my comment about MapVector invalidation.
================ Comment at: lib/Serialization/ASTWriter.cpp:4394 @@ +4393,3 @@ + // date, so we need to pull in the new content here. + for (auto &SelectorAndID : SelectorIDs) + SemaRef.updateOutOfDateSelector(SelectorAndID.first); ---------------- Are we certain that SelectorIDs cannot get updated during this iteration under any circumstances? If the underlying vector were to get reallocated, we'd end up with a horrible-to-reproduce use-after-free here. It might be worth copying SelectorIDs or indexing by an integer value rather than using the for-each loop. http://reviews.llvm.org/D19679 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
