2016-04-14 2:44 GMT+06:00 Richard Smith :
> rsmith added a comment.
>
> I would prefer to avoid adding the `%qt` format if we can. But if we do
> provide it, the template parameter names we use should match what was
> written in the declaration of the template itself.
>
> New format was not a good
Author: asbokhan
Date: Fri Apr 15 03:03:51 2016
New Revision: 266415
URL: http://llvm.org/viewvc/llvm-project?rev=266415&view=rev
Log:
[MSVC Compat] Implementation of __unaligned (MS extension) as a type qualifier
This patch implements __unaligned as a type qualifier; before that, it was
modeled
andreybokhanko marked an inline comment as done.
andreybokhanko added a comment.
Reid, thank you!
Yours,
Andrey
Repository:
rL LLVM
http://reviews.llvm.org/D18596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266415: [MSVC Compat] Implementation of __unaligned (MS
extension) as a type qualifier (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D18596?vs=53509&id=53854#toc
Repository:
DmitryPolukhin added a comment.
Richard, this is just weekly friendly ping about abi_tag support.
Please let me know if you think if something in this patch needs improvements
or you are waiting for something specific before committing this patch.
http://reviews.llvm.org/D18035
ioeric updated this revision to Diff 53866.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Do not merge multiple lines when generate fixes. Added test cases with
comments around namespace.
- Refactor: pull Annotator into Formatter/Cleaner from CodeProcessor. Moved
AffectedRan
bader added inline comments.
Comment at: lib/Headers/opencl.h:14892-14898
@@ +14891,9 @@
+
+/**
+* Sampler-less Image Access
+*/
+
+float4 __const_func __attribute__((overloadable)) read_imagef(read_only
image1d_t image, int coord);
+int4 __const_func __attribute__((overloadable)
sepavloff updated this revision to Diff 53853.
sepavloff added a comment.
Herald added a subscriber: klimek.
Updated patch
Get rid of '%qt' format, instead print template parameters always. It requires
about 10 tests to be fixed. However printing parameters still can be suppressed,
it is required
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D18567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
FYI, a fix for the assertion failure you see is sent for review as
http://reviews.llvm.org/D19144. Let's wait for it to land, before going on with
this patch.
http://reviews.llvm.o
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:426
@@ +425,3 @@
+case 110:
+ Builder.defineMacro("__CLANG_OPENCL_C_VERSION__", "110");
+ break;
So why we can't use unified __OPENCL_C_VERSION__?
Commen
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/ClangTidyOptions.h:99
@@ +98,3 @@
+ /// \brief Stores all options that have higher priority than current one.
+ std::vector HigherPriorityOptions;
+
alexfh added a comment.
Ignoring 1-bit wide bitfields seems like a reasonable thing to do for the
check. Most of the changes I see here are making the code less idiomatic, I'd
say.
http://reviews.llvm.org/D19105
___
cfe-commits mailing list
cfe-co
nikola added a comment.
Would anyone be kind enough to review this?
http://reviews.llvm.org/D15509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
avt77 created this revision.
avt77 added a reviewer: rnk.
avt77 added a subscriber: cfe-commits.
Clang creates implicit move constructor/assign operator in all cases if there
is std=c++11. But MSVC supports such generation starting from version 1900
only. As result we have some binary incompatib
avt77 changed the visibility of this Differential Revision from "All Users" to
"Public (No Login Required)".
avt77 updated this revision to Diff 53870.
avt77 added a comment.
I fixed all issues discovered by Richard and Reid. As result the tests were
updated as well. Please, review again.
http
On Thu, Apr 14, 2016 at 11:29 PM, Etienne Bergeron via cfe-commits
wrote:
> etienneb created this revision.
> etienneb added a reviewer: alexfh.
> etienneb added a subscriber: cfe-commits.
>
> Checker to validate string constructor parameters.
>
> A common mistake is to swap parameter for the fill
bader added inline comments.
Comment at: lib/Headers/opencl.h:15372-15373
@@ +15371,4 @@
+ */
+int __const_func __attribute__((overloadable)) get_image_width(image1d_t
image);
+int __const_func __attribute__((overloadable))
get_image_width(image1d_buffer_t image);
+int __const_f
bader added a comment.
To clarify my last comment: I don't think we should define Image Query built-in
functions only for 'read_only' access qualifier in OpenCL 1.x.
It's just bug in OpenCL 1.x specifications. I think the intention was to
provide these built-in functions for both 'read_only' and
Author: bader
Date: Fri Apr 15 08:23:26 2016
New Revision: 266428
URL: http://llvm.org/viewvc/llvm-project?rev=266428&view=rev
Log:
Remove include duplicate. NFC.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
This very likely caused https://llvm.org/bugs/show_bug.cgi?id=27367
On Fri, Apr 15, 2016 at 4:03 AM, Andrey Bokhanko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: asbokhan
> Date: Fri Apr 15 03:03:51 2016
> New Revision: 266415
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266
alexfh added a comment.
I wonder whether `misc-swapped-arguments` can be tuned to handle these cases in
a more generic way? The only missing part so far seems to be the lack of
`cxxConstructExpr` support.
Comment at: clang-tidy/misc/StringConstructorCheck.cpp:104
@@ +103,3 @@
alexfh added a comment.
In http://reviews.llvm.org/D19146#402410, @alexfh wrote:
> I wonder whether `misc-swapped-arguments` can be tuned to handle these cases
> in a more generic way? The only missing part so far seems to be the lack of
> `cxxConstructExpr` support.
And by "these cases" I me
On Fri, Apr 15, 2016 at 12:27 AM, Hal Finkel wrote:
> - Original Message -
> > From: "Hans Wennborg via cfe-commits"
> > To: "Nemanja Ivanovic" , "Nico Weber" <
> tha...@chromium.org>
> > Cc: "cfe-commits"
> > Sent: Thursday, April 14, 2016 8:07:58 PM
> > Subject: Re: r266186 - Enable s
Author: tstellar
Date: Fri Apr 15 09:18:58 2016
New Revision: 266430
URL: http://llvm.org/viewvc/llvm-project?rev=266430&view=rev
Log:
prepare-builtins: Remove call to getGlobalContext()
This function has been removed from LLVM.
Patch By: Laurent Carlier
Modified:
libclc/trunk/utils/prepare
yaxunl marked 6 inline comments as done.
Comment at: lib/Frontend/InitPreprocessor.cpp:426
@@ +425,3 @@
+case 110:
+ Builder.defineMacro("__CLANG_OPENCL_C_VERSION__", "110");
+ break;
Anastasia wrote:
> So why we can't use unified __OPENCL_C_VERSION_
Author: nico
Date: Fri Apr 15 09:35:06 2016
New Revision: 266431
URL: http://llvm.org/viewvc/llvm-project?rev=266431&view=rev
Log:
Revert r266415, it broke parsing SDK headers (PR27367).
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/include/clang/Basic/AddressSpaces.h
cfe/tru
etienneb updated this revision to Diff 53892.
etienneb marked 2 inline comments as done.
etienneb added a comment.
alexfh comments.
http://reviews.llvm.org/D19146
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringConstructorCheck.cpp
clang-ti
Prazek updated the summary for this revision.
Prazek updated this revision to Diff 53891.
Prazek added a comment.
Small tests update. Ping me when your patch will be in trunk
http://reviews.llvm.org/D18136
Files:
clang-tidy/boost/BoostTidyModule.cpp
clang-tidy/boost/CMakeLists.txt
clang-t
etienneb updated this revision to Diff 53894.
etienneb added a comment.
fix unittests
http://reviews.llvm.org/D19146
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringConstructorCheck.cpp
clang-tidy/misc/StringConstructorCheck.h
docs/clang-
etienneb updated this revision to Diff 53895.
etienneb added a comment.
add missing unittest for large length parameter
http://reviews.llvm.org/D19146
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringConstructorCheck.cpp
clang-tidy/misc/Stri
Author: chapuni
Date: Fri Apr 15 10:42:27 2016
New Revision: 266444
URL: http://llvm.org/viewvc/llvm-project?rev=266444&view=rev
Log:
ASTMatchers.h: Fix formatting. [-Wdocumentation]
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMatchers/AST
I have just pinged the patch to see if I can get it approved today. Can I
give it a few hours and if it isn't approved by tonight, I'll revert the
other patch?
BTW. a temporary workaround for this issue if absolutely required in the
next few hours is to comment out the following define in bits/con
bader added a comment.
Sam, could you also add declarations of samplerless read_image and write_image
built-in functions with read_write qualified images, please?
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: adrian
Date: Fri Apr 15 10:55:45 2016
New Revision: 266445
URL: http://llvm.org/viewvc/llvm-project?rev=266445&view=rev
Log:
Update to match LLVM changes for PR27284.
(Reverse the ownership between DICompileUnit and DISubprogram.)
http://reviews.llvm.org/D19034
Modified:
cfe/trunk/l
xazax.hun added a comment.
In http://reviews.llvm.org/D16044#401130, @Alexander_Droste wrote:
> Might the problem be in the va_list checker?
> Obviously the va_list variable is identified as an ElementRegion what seems
> not to be correct.
> Only if the passed region is an ElementRegion indic
Author: adrian
Date: Fri Apr 15 11:05:13 2016
New Revision: 266447
URL: http://llvm.org/viewvc/llvm-project?rev=266447&view=rev
Log:
Update testcase to new debug info metadata format.
Modified:
cfe/trunk/test/CodeGen/backend-unsupported-error.ll
Modified: cfe/trunk/test/CodeGen/backend-unsup
Author: adrian
Date: Fri Apr 15 11:21:23 2016
New Revision: 266449
URL: http://llvm.org/viewvc/llvm-project?rev=266449&view=rev
Log:
Fix testcase for MSVC targets where the output ordering is different.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-limited.cpp
Modified: cfe/trunk/test/CodeG
rnk added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:6417-6425
@@ +6416,11 @@
+if (isa(NewDC) && isa(D)) {
+ if (Diags.isIgnored(diag::warn_ctor_parm_shadows_field, R.getNameLoc()))
{
+D = D->getCanonicalDecl();
+ShadowingDecls.insert({D, FD});
+
etienneb added inline comments.
Comment at: docs/clang-tidy/checks/misc-pointer-and-integral-operation.rst:22
@@ +21,3 @@
+
+ void Prcess(std::string path, bool* error) {
+[...]
Eugene.Zelenko wrote:
> Process?
tpo. oups.. typo :)
http://reviews.llvm.org/D1
etienneb updated this revision to Diff 53903.
etienneb marked 3 inline comments as done.
etienneb added a comment.
comments.
http://reviews.llvm.org/D19118
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/PointerAndIntegralOperationCheck.cpp
clang
Author: etienneb
Date: Fri Apr 15 11:31:15 2016
New Revision: 266450
URL: http://llvm.org/viewvc/llvm-project?rev=266450&view=rev
Log:
[clang-tidy] Add checker for operations between integrals and pointers
Summary:
This check is finding suspicious operations involving pointers and integral
types
Author: etienneb
Date: Fri Apr 15 11:36:00 2016
New Revision: 266451
URL: http://llvm.org/viewvc/llvm-project?rev=266451&view=rev
Log:
[clang-tidy] Add new checker for suspicious sizeof expressions
Summary:
This check is finding suspicious cases of sizeof expression.
Sizeof expression is returni
I've looked into this a bit, and this breaks compiling programs like
`#include ` on linux, without passing any special flags (other than
`-std=gnu++11`). That seems like a very big regression :-) I think this
should be reverted, so that there's no rush for getting your other patch in.
LLVM tries t
etienneb updated this revision to Diff 53905.
etienneb added a comment.
rebased
http://reviews.llvm.org/D19014
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
docs/ReleaseNotes.r
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
This strikes me as something the compiler should diagnose instead of a
clang-tidy check. Incrementing a bool has been deprecated for some time, but it
is outright removed in C++17, so I think giving users a migration
mnbvmar created this revision.
mnbvmar added reviewers: alexfh, Prazek, staronj, krystyna.
mnbvmar added a subscriber: cfe-commits.
http://reviews.llvm.org/D19165
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/IncrementBoolCheck.cpp
clang-tidy/modernize/IncrementBoolCheck.h
Prazek updated the summary for this revision.
Prazek updated this revision to Diff 53909.
Prazek marked an inline comment as done.
Prazek added a comment.
I will think name for new module that would have all the checks like this.
I added ingnoring of bitfields of size 1
http://reviews.llvm.org/D
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:791
@@ +790,3 @@
+// Create PGOFuncName meta data.
+llvm::Function *F = ValueSite->getFunction();
+if (!llvm::getPGOFuncNameMetadata(*F))
This may not be the best place do set the da
OK, I'm reverting now. I've done an svn merge but I'm just re-running all
the tests to make sure something weird didn't happen that would cause
buildbot failures.
Perhaps I should have posted D19125 before committing D15120 rather than
sending an email to cfe-dev and asking which targets need the
Prazek added a comment.
In http://reviews.llvm.org/D18821#398843, @alexfh wrote:
> BTW, why is the check in the 'modernize' module? It doesn't seem to make
> anything more modern. I would guess, the pattern it detects is most likely to
> result from a programming error. Also, the fix, though it
Author: eugenezelenko
Date: Fri Apr 15 12:32:19 2016
New Revision: 266455
URL: http://llvm.org/viewvc/llvm-project?rev=266455&view=rev
Log:
[Release Notes] mention Clang-tidy misc-multiple-statement-macro check.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-ex
I'm confused: why does it break targets if __float128 wasn't supported
before, and still isn't supported?
Surely enabling float128 support on some targets, and leaving it disabled
on linux/x86 shouldn't actually *break* linux/x86?
On Fri, Apr 15, 2016 at 11:53 AM, Nemanja Ivanovic via cfe-commits
It was not supported before but there was a workaround in Clang. As far as
I recall, it basically "secretly" provided a typedef for __float128
(presumably to long double on most targets). This workaround was in place
precisely to allow these headers to compile.
On Fri, Apr 15, 2016 at 7:58 PM, Jam
Alexander_Droste added inline comments.
Comment at: test/Analysis/MPIChecker.cpp:99
@@ +98,3 @@
+ MPI_Wait(&req, MPI_STATUS_IGNORE);
+}
+
Alexander_Droste wrote:
> zaks.anna wrote:
> > This are explaining the path on which the problem occurs; the users will
> >
mlemay-intel updated this revision to Diff 53920.
mlemay-intel added a comment.
Revise patch to fix line alignment.
http://reviews.llvm.org/D17092
Files:
include/clang/Driver/Options.td
lib/CodeGen/TargetInfo.cpp
test/CodeGen/varargs.c
Index: test/CodeGen/varargs.c
==
Author: nemanjai
Date: Fri Apr 15 13:04:13 2016
New Revision: 266460
URL: http://llvm.org/viewvc/llvm-project?rev=266460&view=rev
Log:
Revert 266186 as it breaks anything that includes type_traits on some platforms
Since this patch provided support for the __float128 type but disabled it
on all p
Author: ericwf
Date: Fri Apr 15 13:05:59 2016
New Revision: 266461
URL: http://llvm.org/viewvc/llvm-project?rev=266461&view=rev
Log:
Cleanup and guard tuple's constructor SFINAE. Fixes PR22806 and PR23256.
There are two main fixes in this patch.
First the constructor SFINAE was changed so that
Alexander_Droste added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MPI-Checker/MPIBugReporter.cpp:96
@@ +95,3 @@
+if (const CallExpr *CE = clang::dyn_cast(SP->getStmt())) {
+
+ auto FuncIdentifier = CE->getDirectCallee()->getIdentifier();
zak
Author: etienneb
Date: Fri Apr 15 13:12:06 2016
New Revision: 266463
URL: http://llvm.org/viewvc/llvm-project?rev=266463&view=rev
Log:
[clang-tidy] Add more detection rules for redundant c_str calls.
Summary:
The string class contains methods which support receiving either a string
literal or a
Hello everyone,
Below are some buildbot numbers for the last week of 4/03/2016 - 4/09/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
jfb updated this revision to Diff 53931.
jfb added a comment.
- Use validity checks, reduce casting while still avoiding UB on out-of-range
enum values.
http://reviews.llvm.org/D18876
Files:
include/clang/AST/Expr.h
lib/CodeGen/CGAtomic.cpp
lib/Sema/SemaChecking.cpp
Index: lib/Sema/Sema
sbenza added a comment.
I think the bug is coming from `memoizedMatchesAncestorOfRecursively`.
`memoizedMatchesRecursively` has a special case at the top to skip the cache if
the node is not sortable. The other function should do that too.
Although the check is stale also because it is only check
eugenis added a comment.
Test, please.
Where is this runtime support implemented? Some platform's libc, or an external
library?
http://reviews.llvm.org/D19170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
sbenza added a comment.
To be more specific, the problem comes from the use of `hasAnscestor` (done by
`isInTemplateInstantiation` ) while there is a `TemplateArgument` in the bound
nodes.
This tries to put the node into the cache.
To trigger this easily you only need to have a hit in the cache.
ahatanak created this revision.
ahatanak added a reviewer: rsmith.
ahatanak added a subscriber: cfe-commits.
I'm sending a WIP patch which fixes PR27015 to get an early feedback from the
community.
This patch attempts to fix a crash which happens when a variable template is
initialized with a g
rsmith added inline comments.
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3899-3901
@@ -3898,5 +3898,5 @@
// Instantiate the initializer.
ExprResult Init =
SubstInitializer(OldVar->getInit(), TemplateArgs,
- OldVar->getInitStyle(
jfb added a comment.
In http://reviews.llvm.org/D18876#399934, @jyknight wrote:
> The large amount of casting to/from integers for AtomicOrderingCABI makes me
> think that it probably ought not actually be converted to an enum class after
> all.
Untrusted user input with enums is a problem: y
eugenis added a comment.
In http://reviews.llvm.org/D19170#402939, @mlemay-intel wrote:
> In http://reviews.llvm.org/D19170#402861, @eugenis wrote:
>
> > Test, please.
>
>
> Do you know of any examples of the sort of test that you would like to see
> for a feature like this?
test/Driver/saniti
mlemay-intel added a comment.
In http://reviews.llvm.org/D19170#402861, @eugenis wrote:
> Test, please.
Do you know of any examples of the sort of test that you would like to see for
a feature like this?
> Where is this runtime support implemented? Some platform's libc, or an
> external libr
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Without this change, we silently proceed on without including
__clang_cuda_runtime_wrapper.h. This leads to very strange behavior --
you say you're compiling CUDA code, but e.g. __device__ is not d
mlemay-intel updated this revision to Diff 53956.
mlemay-intel added a comment.
Add test.
http://reviews.llvm.org/D19170
Files:
lib/Driver/Tools.cpp
test/Driver/sanitizer-ld.c
Index: test/Driver/sanitizer-ld.c
===
--- test/Dri
rsmith requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Parse/ParseTemplate.cpp:1233-1240
@@ -1240,1 +1232,10 @@
+
+ SuppressAllDiagnostics S(Diags);
+ GreaterThanIsOperatorScope G(GreaterThanIsOperator, false);
+ TemplateArgLis
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D19170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
rsmith added a comment.
I have a lingering concern with this style of formatting, because it risks
making our diagnostics (more) ambiguous. Consider this:
template struct X {};
struct T {};
X xt;
If we give a diagnostic talking about `X`, it's ambiguous whether we're
referring to the
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM too, but please wait for @joerg's review as e had concerns about the
previous revision.
http://reviews.llvm.org/D19062
___
On Fri, Apr 15, 2016 at 12:56 AM, Serge Pavlov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> 2016-04-14 2:44 GMT+06:00 Richard Smith :
>
>> rsmith added a comment.
>>
>> I would prefer to avoid adding the `%qt` format if we can. But if we do
>> provide it, the template parameter names we
Prazek created this revision.
Prazek added reviewers: alexfh, mnbvmar, staronj, krystyna, angelgarcia.
Prazek added a subscriber: cfe-commits.
Because modernize-make-shared do almos the same job,
I refactored common code to MakeSmartPtrCheck.
http://reviews.llvm.org/D19183
Files:
clang-tidy/
etienneb updated this revision to Diff 53966.
etienneb added a comment.
alexfh comments.
http://reviews.llvm.org/D18703
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.
Prazek added a comment.
In http://reviews.llvm.org/D19165#402657, @aaron.ballman wrote:
> This strikes me as something the compiler should diagnose instead of a
> clang-tidy check. Incrementing a bool has been deprecated for some time, but
> it is outright removed in C++17, so I think giving us
etienneb added a comment.
ok, alexfh.
I addressed your comments.
http://reviews.llvm.org/D18703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Quuxplusone added a subscriber: Quuxplusone.
Quuxplusone added a comment.
I would like to see a new version of http://reviews.llvm.org/D19105 with all
the "1-bit-bitfield" diffs removed.
Right now, it's hard to see that there's *anything* in
http://reviews.llvm.org/D19105 that's not a miscorrect
Prazek added a comment.
Besides comments, looks good to me. But before posting make sure that
clang-diagnostics doesn't already have fixits.
Comment at: clang-tidy/modernize/IncrementBoolCheck.cpp:51
@@ +50,3 @@
+ // Don't fix if expression type is dependent on template initia
Prazek added a comment.
In http://reviews.llvm.org/D18821#403103, @Quuxplusone wrote:
> I would like to see a new version of http://reviews.llvm.org/D19105 with all
> the "1-bit-bitfield" diffs removed.
> Right now, it's hard to see that there's *anything* in
> http://reviews.llvm.org/D19105 t
Prazek added a comment.
In http://reviews.llvm.org/D18821#402686, @Prazek wrote:
> In http://reviews.llvm.org/D18821#398843, @alexfh wrote:
>
> > BTW, why is the check in the 'modernize' module? It doesn't seem to make
> > anything more modern. I would guess, the pattern it detects is most likel
jyknight added a comment.
In http://reviews.llvm.org/D18876#402855, @jfb wrote:
> In http://reviews.llvm.org/D18876#399934, @jyknight wrote:
>
> > The large amount of casting to/from integers for AtomicOrderingCABI makes
> > me think that it probably ought not actually be converted to an enum cl
EricWF updated this revision to Diff 53968.
EricWF added a comment.
I've silenced the tests when they pass as suggested. I added a
'assert_checkpoint.h' support header that stores the last checkpoint a test has
passed and prints that information when std::abort is called.
I also moved the alloc
Author: ericwf
Date: Fri Apr 15 18:27:27 2016
New Revision: 266491
URL: http://llvm.org/viewvc/llvm-project?rev=266491&view=rev
Log:
Extract key to avoid preemptive mallocs in insert/emplace in associative
containers
Summary: This patch applies Duncan's work on __hash_table to __tree.
Reviewers
eraman created this revision.
eraman added a reviewer: vsk.
eraman added subscribers: cfe-commits, davidxl.
Step 2 of MaxFunctionCount removal. It is superseded by ProfileSummary flag.
http://reviews.llvm.org/D19184
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/max-function-count.c
Inde
jfb added a comment.
In http://reviews.llvm.org/D18876#403119, @jyknight wrote:
> In http://reviews.llvm.org/D18876#402855, @jfb wrote:
>
> > In http://reviews.llvm.org/D18876#399934, @jyknight wrote:
> >
> > > The large amount of casting to/from integers for AtomicOrderingCABI makes
> > > me th
Author: rsmith
Date: Fri Apr 15 19:07:09 2016
New Revision: 266495
URL: http://llvm.org/viewvc/llvm-project?rev=266495&view=rev
Log:
Improve diagnostic for the case when a non-defined function-like macro is used
in a preprocessor constant expression.
Modified:
cfe/trunk/include/clang/Basic/Di
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D19180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jlebar
Date: Fri Apr 15 19:11:11 2016
New Revision: 266496
URL: http://llvm.org/viewvc/llvm-project?rev=266496&view=rev
Log:
[CUDA] Raise an error if the CUDA install can't be found.
Summary:
Without this change, we silently proceed on without including
__clang_cuda_runtime_wrapper.h. Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266496: [CUDA] Raise an error if the CUDA install can't be
found. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D19180?vs=53954&id=53973#toc
Repository:
rL LLVM
http://revie
Author: ericwf
Date: Fri Apr 15 19:23:12 2016
New Revision: 266498
URL: http://llvm.org/viewvc/llvm-project?rev=266498&view=rev
Log:
Teach map/unordered_map how to optimize 'emplace(Key, T)'.
In cases where emplace is called with two arguments and the first one
matches the key_type we can Key to
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/libcxx/test/config.py:66
@@ -65,3 +65,3 @@
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
Author: rsmith
Date: Fri Apr 15 19:46:26 2016
New Revision: 266501
URL: http://llvm.org/viewvc/llvm-project?rev=266501&view=rev
Log:
[modules] Don't expose *intrin.h headers that cannot be included standalone as
separate modules. These cause build breakage with
-fmodules-local-submodule-visibilit
alexfh added a comment.
In http://reviews.llvm.org/D19146#402414, @alexfh wrote:
> In http://reviews.llvm.org/D19146#402410, @alexfh wrote:
>
> > I wonder whether `misc-swapped-arguments` can be tuned to handle these
> > cases in a more generic way? The only missing part so far seems to be the
alexfh added inline comments.
Comment at: clang-tidy/misc/StringConstructorCheck.cpp:104
@@ +103,3 @@
+ const auto *E = Result.Nodes.getNodeAs("constructor");
+ assert(E);
+
We usually add some description to asserts (`assert(X && "X should not be
nullptr");`).
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I appreciate the patch, handling 'ccache' is a good thing to have. I'll look
at this again once the inline comment is addressed.
Comment at: CMakeLists.txt:225
@@
1 - 100 of 115 matches
Mail list logo
