Re: [libcxx] r249738 - Split out of .

2016-10-25 Thread Richard Smith via cfe-commits
Committed as r285152. On Tue, Oct 25, 2016 at 3:09 PM, Richard Smith wrote: > Missed one change from the test suite: > > Index: test/Modules/cstd.m > === > --- test/Modules/cstd.m (revision 285117) > +++ test/Modules/cstd.m (working

Re: [libcxx] r249738 - Split out of .

2016-10-25 Thread Richard Smith via cfe-commits
Missed one change from the test suite: Index: test/Modules/cstd.m === --- test/Modules/cstd.m (revision 285117) +++ test/Modules/cstd.m (working copy) @@ -1,5 +1,5 @@ // RUN: rm -rf %t -// RUN: %clang_cc1 -fsyntax-only -isystem %S/In

Re: [libcxx] r249738 - Split out of .

2016-10-25 Thread Richard Smith via cfe-commits
This was a thinko on my part: clang's builtin headers include_next the system headers, not the other way around, so the system headers should be implicitly textual, not clang's headers. This patch fixes the problem for me with glibc. Does this help for Darwin too? On Tue, Oct 25, 2016 at 2:01 PM,

Re: [libcxx] r249738 - Split out of .

2016-10-25 Thread Richard Smith via cfe-commits
On Mon, Oct 24, 2016 at 4:58 PM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith > wrote: > > On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes > > wrote: > >> > >> > Sure, go ahead. > >> > >> I committed in r284797 and

Re: [libcxx] r249738 - Split out of .

2016-10-24 Thread Bruno Cardoso Lopes via cfe-commits
On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith wrote: > On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes > wrote: >> >> > Sure, go ahead. >> >> I committed in r284797 and r284801 (libcxx). There's one minor issue >> I've found: the changes for the builtins affecting non submodule local >> vis

Re: [libcxx] r249738 - Split out of .

2016-10-24 Thread Richard Smith via cfe-commits
On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > > Sure, go ahead. > > I committed in r284797 and r284801 (libcxx). There's one minor issue > I've found: the changes for the builtins affecting non submodule local > visibility broke current users of plain "-f

Re: [libcxx] r249738 - Split out of .

2016-10-24 Thread Bruno Cardoso Lopes via cfe-commits
> Sure, go ahead. I committed in r284797 and r284801 (libcxx). There's one minor issue I've found: the changes for the builtins affecting non submodule local visibility broke current users of plain "-fmodules" against our frameworks in public SDKs, in 10.11 & 10.12. I've attached a patch to work a

Re: [libcxx] r249738 - Split out of .

2016-10-18 Thread Richard Smith via cfe-commits
On Mon, Oct 17, 2016 at 3:31 PM, Manman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Hi, > > > > On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith > wrote: > >> On Fri, Oct 14

Re: [libcxx] r249738 - Split out of .

2016-10-18 Thread Richard Smith via cfe-commits
On Tue, Oct 18, 2016 at 4:30 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Richard, > > Turns out that the redefinition error was caused because libc++ > modulemap lacked a module for its "string.h", and therefore it would > be textually included in more than one module, yielding

Re: [libcxx] r249738 - Split out of .

2016-10-18 Thread Bruno Cardoso Lopes via cfe-commits
Hi Richard, Turns out that the redefinition error was caused because libc++ modulemap lacked a module for its "string.h", and therefore it would be textually included in more than one module, yielding the error. With the attached patch for libc++ modulemap (extracted from parts of a modulemap you

Re: [libcxx] r249738 - Split out of .

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
> @Bruno, > > Can you try "-fdiagnostics-show-note-include-stack” so we know the other path > that leads to string.h? Attached the complete error log (this snippet won't help without full context anyway) -- Bruno Cardoso Lopes http://www.brunocardoso.cc output.log Description: Binary data _

Re: [libcxx] r249738 - Split out of .

2016-10-17 Thread Manman via cfe-commits
> On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits > wrote: > > Hi, > > On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote: >> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes >> wrote: >>> >>> Hi Richard, >>> >>> I have a patch on top of your suggested patch from a

Re: [libcxx] r249738 - Split out of .

2016-10-17 Thread Bruno Cardoso Lopes via cfe-commits
Hi, On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote: > On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes > wrote: >> >> Hi Richard, >> >> I have a patch on top of your suggested patch from a year ago, that >> break the cyclic dependency we're seeing, with this (and a few changes >> to t

Re: [libcxx] r249738 - Split out of .

2016-10-14 Thread Richard Smith via cfe-commits
On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Richard, > > I have a patch on top of your suggested patch from a year ago, that > break the cyclic dependency we're seeing, with this (and a few changes > to the SDK) we can bootstrap clang with submodule

Re: [libcxx] r249738 - Split out of .

2016-10-14 Thread Bruno Cardoso Lopes via cfe-commits
Hi Richard, I have a patch on top of your suggested patch from a year ago, that break the cyclic dependency we're seeing, with this (and a few changes to the SDK) we can bootstrap clang with submodule local visibility on darwin. I've attached the patch with a reduced, standalone testcase that does

Re: [libcxx] r249738 - Split out of .

2016-07-28 Thread Adrian Prantl via cfe-commits
+Bruno > On Jul 27, 2016, at 11:58 PM, Nico Weber wrote: > > I played with modules a bit today, and as far as I can tell this is still > broken. If this proves difficult to fix, should this change be reverted for > now? It breaks using modules on Darwin. > > On Sun, Mar 13, 2016 at 12:53 AM, A

Re: [libcxx] r249738 - Split out of .

2016-07-27 Thread Nico Weber via cfe-commits
I played with modules a bit today, and as far as I can tell this is still broken. If this proves difficult to fix, should this change be reverted for now? It breaks using modules on Darwin. On Sun, Mar 13, 2016 at 12:53 AM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On

Re: [libcxx] r249738 - Split out of .

2016-06-20 Thread Vassil Vassilev via cfe-commits
On 17/10/15 01:27, Richard Smith via cfe-commits wrote: On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: On Oct 14, 2015, at 5:07 PM, Richard Smith mailto:rich...@metafoo.co.uk>> wrote: Ack, there are non-modular headers in the Darwin module. =( I

Re: [libcxx] r249738 - Split out of .

2016-03-12 Thread Adrian Prantl via cfe-commits
> On Mar 11, 2016, at 4:11 PM, Duncan P. N. Exon Smith > wrote: > > Did anyone file a PR for this? > I filed PR 26928 - Prune the include path for modules https://llvm.org/bugs/show_bug.cgi?id=26928 as a starting point. -- adrian ___ cfe-commits m

Re: [libcxx] r249738 - Split out of .

2016-03-11 Thread Duncan P. N. Exon Smith via cfe-commits
Did anyone file a PR for this? > On 2015-Oct-19, at 15:52, Richard Smith via cfe-commits > wrote: > > Ugh, looks like I missed a submodule for stdio.h :( > > On Oct 19, 2015 11:34 AM, "Adrian Prantl" wrote: > While building module 'std' imported from > /Volumes/Data/llvm/_build.ninja.release

Re: [libcxx] r249738 - Split out of .

2015-10-19 Thread Richard Smith via cfe-commits
Ugh, looks like I missed a submodule for stdio.h :( On Oct 19, 2015 11:34 AM, "Adrian Prantl" wrote: > While building module 'std' imported from > /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/cassert:20: > While building module 'Darwin' imported from > /Volumes/Data/llvm/_build.n

Re: [libcxx] r249738 - Split out of .

2015-10-19 Thread Adrian Prantl via cfe-commits
While building module 'std' imported from /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/cassert:20: While building module 'Darwin' imported from /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/ctype.h:39: In file included from :95: In file included from /Xcode.app/C

Re: [libcxx] r249738 - Split out of .

2015-10-19 Thread Richard Smith via cfe-commits
On Mon, Oct 19, 2015 at 1:28 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 16, 2015, at 5:47 PM, Richard Smith wrote: > > Great, looks like progress. Next you need a correct module map for libc++ > that actually covers all of its headers :) Try the attached one

Re: [libcxx] r249738 - Split out of .

2015-10-19 Thread Adrian Prantl via cfe-commits
> On Oct 16, 2015, at 5:47 PM, Richard Smith wrote: > > Great, looks like progress. Next you need a correct module map for libc++ > that actually covers all of its headers :) Try the attached one. > Sorry for the delay. With the updated module map I get /Volumes/Data/llvm/_build.ninja.releas

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Richard Smith via cfe-commits
On Fri, Oct 16, 2015 at 5:30 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 16, 2015, at 5:28 PM, Richard Smith wrote: > > > > > Getting there :-) > > In file included from :86: > In file included from > /Volumes/Data/llvm/_build.ninja.release/bin/../lib/clang/

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Adrian Prantl via cfe-commits
> On Oct 16, 2015, at 5:30 PM, Adrian Prantl via cfe-commits > wrote: > > >> On Oct 16, 2015, at 5:28 PM, Richard Smith > > wrote: >> >> > > Getting there :-) > While building module 'Darwin' imported from /Xcode.app/Contents/Developer/Platforms/MacOSX.platfo

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Adrian Prantl via cfe-commits
> On Oct 16, 2015, at 5:28 PM, Richard Smith wrote: > > Getting there :-) In file included from :86: In file included from /Volumes/Data/llvm/_build.ninja.release/bin/../lib/clang/3.8.0/include/tgmath.h:29: /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/math.h:309:10: fatal e

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Richard Smith via cfe-commits
On Fri, Oct 16, 2015 at 5:17 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 16, 2015, at 5:13 PM, Richard Smith wrote: > > On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 16, 2015, at 3:27 PM, Richa

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Adrian Prantl via cfe-commits
> On Oct 16, 2015, at 5:13 PM, Richard Smith wrote: > > On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 16, 2015, at 3:27 PM, Richard Smith > > wrote: >> >> On Thu, Oct 15, 2015 at 11:14 AM, Adr

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Richard Smith via cfe-commits
On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 16, 2015, at 3:27 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: > >> >> On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: >> >> Ack, there are non-m

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Nico Weber via cfe-commits
On Wed, Oct 14, 2015 at 5:28 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14, 2015, at 3:32 PM, Ric

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Adrian Prantl via cfe-commits
> On Oct 16, 2015, at 3:27 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: > >> On Oct 14, 2015, at 5:07 PM, Richard Smith > > wrote: >> >> Ack, there are non-modular headers in the Darwin module. =(

Re: [libcxx] r249738 - Split out of .

2015-10-16 Thread Richard Smith via cfe-commits
On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: > > On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > Ack, there are non-modular headers in the Darwin module. =( I seem to > recall that they're not version-locked to your compiler, so we've got to > support them as-is? > > If we can't

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Richard Smith via cfe-commits
On Thu, Oct 15, 2015 at 2:57 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Oct 15, 2015, at 2:09 PM, Adrian

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Richard Smith via cfe-commits
On Thu, Oct 15, 2015 at 2:57 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Oct 15, 2015, at 2:09 PM, Adrian

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Adrian Prantl via cfe-commits
> On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >>> >>> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits >>> mailto:cfe-commits@lists.llvm.org>> wrote: >>>

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Alex Rosenberg via cfe-commits
On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits wrote: >> >> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits >> wrote: >> >>> >>> On Oct 15, 2015, at 1:42 PM, Richard Smith wrote: >>> >>> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: >>> On Oct 14, 20

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Adrian Prantl via cfe-commits
> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 1:42 PM, Richard Smith > > wrote: >> >> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > > wrote: >> >>> On Oct 14, 2015, at 5:07 PM, Ric

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Adrian Prantl via cfe-commits
> On Oct 15, 2015, at 1:42 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: > >> On Oct 14, 2015, at 5:07 PM, Richard Smith > > wrote: >> >> Ack, there are non-modular headers in the Darwin module. =(

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Richard Smith via cfe-commits
On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: > > On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > Ack, there are non-modular headers in the Darwin module. =( I seem to > recall that they're not version-locked to your compiler, so we've got to > support them as-is? > > If we can't

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Adrian Prantl via cfe-commits
On Oct 14, 2015, at 5:07 PM, Richard Smith wrote:Ack, there are non-modular headers in the Darwin module. =( I seem to recall that they're not version-locked to your compiler, so we've got to support them as-is?If we can't turn on local submodule visibility, then we need a m

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Richard Smith via cfe-commits
On Wed, Oct 14, 2015 at 5:22 PM, Sean Silva wrote: > On Tue, Oct 13, 2015 at 7:43 PM, Richard Smith > wrote: > >> On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva >> wrote: >> >>> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith >>> wrote: >>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wr

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Adrian Prantl via cfe-commits
> On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 14, 2015, at 3:32 PM, Richard Smith > > wrote: >> >> On Wed, Oct 14, 2015 at 2:03 PM, Adri

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Sean Silva via cfe-commits
On Tue, Oct 13, 2015 at 7:43 PM, Richard Smith wrote: > On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > >> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith >> wrote: >> >>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva >>> wrote: >>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Richard Smith via cfe-commits
On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 14, 2015, at 3:32 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14, 2015, at 11:37 AM, Adri

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Sean Silva via cfe-commits
On Wed, Oct 14, 2015 at 3:32 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits < >> cfe-commits@lists.llvm.o

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Ted Kremenek via cfe-commits
> On Oct 14, 2015, at 3:49 PM, Duncan P. N. Exon Smith > wrote: > > My understanding is that we don't expect clang to be used with *newer* libc++ > headers, just older or equal. This kind of break is a little unfortunate, > but probably fine. Ted, can you confirm? On Apple platforms, we wi

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Adrian Prantl via cfe-commits
> On Oct 14, 2015, at 3:32 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >>> On Oct 13, 2015,

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Duncan P. N. Exon Smith via cfe-commits
+Ted > On 2015-Oct-14, at 15:32, Richard Smith via cfe-commits > wrote: > >> While building module 'LLVM_Utils' imported from >> ../lib/Support/APFloat.cpp:15: >> In file included from :1: >> In file included from ../include/llvm/ADT/APFloat.h:20: >> In file included from ../include/llvm/ADT/A

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Richard Smith via cfe-commits
On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On Oct 13, 2015, at 7:43 PM, Richard Smith wrote: > > On Tue, Oct 13, 2015 at 6:54 PM, Sean

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Adrian Prantl via cfe-commits
> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 13, 2015, at 7:43 PM, Richard Smith > > wrote: >> >> On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva > > wrote: >> On Tue, Oct 13, 2015 at 6:14 PM, Ric

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Adrian Prantl via cfe-commits
> On Oct 13, 2015, at 7:43 PM, Richard Smith wrote: > > On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva > wrote: > On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith > wrote: > On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva

Re: [libcxx] r249738 - Split out of .

2015-10-14 Thread Adrian Prantl via cfe-commits
To make it easier to find and investigate issues like this, I set up an experimental bot on the Green Dragon Jenkins installation on lab.llvm.org that builds a stage2 on Darwin with LLVM_ENABLE_MODULES: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/ I’ve configured it to du

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Richard Smith via cfe-commits
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith > wrote: > >> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva >> wrote: >> >>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On Tue,

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Sean Silva via cfe-commits
(and assert.h probably isn't the best example, since it is textual) On Tue, Oct 13, 2015 at 7:00 PM, Sean Silva wrote: > > > On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > >> >> >> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith >> wrote: >> >>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Sean Silva via cfe-commits
On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > > > On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith > wrote: > >> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva >> wrote: >> >>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Sean Silva via cfe-commits
On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith wrote: > On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote: > >> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < >>> cfe-c

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Richard Smith via cfe-commits
On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote: > On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Hi Richard, >>> >>> this co

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Sean Silva via cfe-commits
On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi Richard, >> >> this commit appears to break the module self-host on Darwin. >> >> When

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Richard Smith via cfe-commits
On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > this commit appears to break the module self-host on Darwin. > > When compiling the following program generated by clang’s own cmake script: > > > #undef NDEBUG > > #include > > #

Re: [libcxx] r249738 - Split out of .

2015-10-13 Thread Adrian Prantl via cfe-commits
Hi Richard, this commit appears to break the module self-host on Darwin. When compiling the following program generated by clang’s own cmake script: > #undef NDEBUG > #include > #define NDEBUG > #include > int main() { assert(this code is not compiled); } with clang++ -std=c++11 -fmodules -fc

[libcxx] r249738 - Split out of .

2015-10-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 8 15:36:30 2015 New Revision: 249738 URL: http://llvm.org/viewvc/llvm-project?rev=249738&view=rev Log: Split out of . Added: libcxx/trunk/include/ctype.h - copied, changed from r249736, libcxx/trunk/include/cctype Modified: libcxx/trunk/include/cctype