On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote:
> > Sure, go ahead. > > I committed in r284797 and r284801 (libcxx). There's one minor issue > I've found: the changes for the builtins affecting non submodule local > visibility broke current users of plain "-fmodules" against our > frameworks in public SDKs, in 10.11 & 10.12. I've attached a patch to > work around that for the time being: make the new behavior dependent > on local vis. Can you take a look? What's the nature of the breakage? Generally I'd be fine with your patch, but I wonder if there's something better we could do here. > Hmm. Ideally, we should try to pick something that captures the spirit of > > "only non-modular headers and headers from used modules". Something like > > "ignore_modules_not_declared_used", but less wordy? > > Right. It's gonna be hard to shrink this to a meaningful short name. > What about a more generic "no_escape"? "no_undeclared_headers"? > Hmm. Maybe we could allow the existing [exhaustive] attribute to be specified on a use-declaration: use [exhaustive] a, b, c
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
