This revision was automatically updated to reflect the committed changes.
Closed by commit rL251475: Add modernize-redundant-void-arg check to clang-tidy
(authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D7639?vs=37717&id=38617#toc
Repository:
rL LLVM
http://reviews.llv
alexfh added a comment.
FYI, I had to update tests' RUN lines for some recent changes. I'm also going
to move the check to the modernize module, where it belongs.
http://reviews.llvm.org/D7639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh accepted this revision.
alexfh added a comment.
In http://reviews.llvm.org/D7639#276641, @LegalizeAdulthood wrote:
> I mean, look at this review. I created it on Feb 13th 2015. It's been
> getting ground through the review process for 8 months. Why can't we move
> forward?
Yes, I kn
sbenza accepted this revision.
sbenza added a comment.
This revision is now accepted and ready to land.
Just wanted to know it was considered, and it was.
It looks good to me then.
http://reviews.llvm.org/D7639
___
cfe-commits mailing list
cfe-commi
LegalizeAdulthood added a comment.
I mean, look at this review. I created it on Feb 13th 2015. It's been getting
ground through the review process for 8 months. Why can't we move forward?
http://reviews.llvm.org/D7639
___
cfe-commits mailing lis
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D7639#275504, @sbenza wrote:
> Just fyi, I am looking at this diff. It is very large with a lot of rounds of
> comments and I didn't have the context.
> I don't know if I should giving comments at this point of the change, but
> her
sbenza added a comment.
Just fyi, I am looking at this diff. It is very large with a lot of rounds of
comments and I didn't have the context.
I don't know if I should giving comments at this point of the change, but here
it is.
Have you considered matching on typeLoc() instead of having a large
sbenza added a comment.
I'm sorry. This change fell through the cracks. I'll take a look today.
http://reviews.llvm.org/D7639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood marked 17 inline comments as done.
LegalizeAdulthood added a comment.
Can we get this committed? I've addressed all comments.
http://reviews.llvm.org/D7639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D7639#266332, @Eugene.Zelenko wrote:
> What is preventing to add this check to Clang-tidy? Just found another piece
> of fresh C++ code in LLDB with (void) as argument list...
To be honest, I don't know. This review had taken S
LegalizeAdulthood updated this revision to Diff 37717.
http://reviews.llvm.org/D7639
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/RedundantVoidArgCheck.cpp
clang-tidy/readability/RedundantVoidArgCheck.h
test/clang-t
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
What is preventing to add this check to Clang-tidy? Just found another piece of
fresh C++ code in LLDB with (void) as argument list...
http://reviews.llvm.org/D7639
12 matches
Mail list logo
