sbenza added a comment.

Just fyi, I am looking at this diff. It is very large with a lot of rounds of 
comments and I didn't have the context.
I don't know if I should giving comments at this point of the change, but here 
it is.
Have you considered matching on typeLoc() instead of having a large list of 
different cases?
For example, if you match `typeLoc(loc(functionType()))` it will match all the 
places where a function type is mentioned, including things like 
`static_cast<XXX>`, variable declarations, lambda return type declarations, 
etc. Might help remove redundancy in the check.


http://reviews.llvm.org/D7639



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to