phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM but can you update the change title and description since the original one
no longer matches the content of the patch.
Comment at: clang/CMakeLists.txt:599-600
+ if (W
haowei marked 2 inline comments as done.
haowei added inline comments.
Comment at: clang/cmake/caches/Fuchsia.cmake:170-171
runtimes
+ llvm-rc
+ llvm-mt
CACHE STRING "")
phosek wrote:
> Could we do this in
> https://github.com/llvm/llvm-project/blob/98f0
haowei updated this revision to Diff 494755.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143025/new/
https://reviews.llvm.org/D143025
Files:
clang/CMakeLists.txt
Index: clang/CMakeLists.txt
=
phosek added inline comments.
Comment at: clang/cmake/caches/Fuchsia.cmake:20-46
+# Passthrough stage1 flags to stage1.
+set(_FUCHSIA_BOOTSTRAP_PASSTHROUGH
+ LLVM_ENABLE_ZLIB
+ ZLIB_INCLUDE_DIR
+ ZLIB_LIBRARY
+ LLVM_ENABLE_ZSTD
+ zstd_DIR
Could we move this
haowei updated this revision to Diff 494364.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143025/new/
https://reviews.llvm.org/D143025
Files:
clang/cmake/caches/Fuchsia.cmake
Index: clang/cmake/caches/Fuchsia.cmake
===
phosek added inline comments.
Comment at: clang/cmake/caches/Fuchsia.cmake:42-52
+foreach(variableName ${_FUCHSIA_BOOTSTRAP_PASSTHROUGH_STRINGS})
+ if(DEFINED ${variableName})
+set(BOOTSTRAP_${variableName} "${${variableName}}" CACHE STRING "")
+ endif()
+endforeach()
+
+fo
haowei created this revision.
haowei added a reviewer: phosek.
Herald added a subscriber: abrachet.
Herald added a project: All.
haowei requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
llvm-mt and llvm-rc tools are capable of building clang
