[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014256 , @MaskRay wrote: > In D140224#4014243 , @rsundahl > wrote: > >>> I'll reject [-\Xparser for a while as well. This is a valid amendment to >>> D139717

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014246 , @davide wrote: > In D140224#4014245 , @MaskRay wrote: > >> In D140224#4014234 , @davide wrote: >> >>> In D140224#4014230

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014243 , @rsundahl wrote: >> I'll reject [-\Xparser for a while as well. This is a valid amendment to >> D139717 , so I don't think it needs more >> approval. > > We have projects t

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014245 , @MaskRay wrote: > In D140224#4014234 , @davide wrote: > >> In D140224#4014230 , @MaskRay >> wrote: >> >>> In D140224#4014203

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014234 , @davide wrote: > In D140224#4014230 , @MaskRay wrote: > >> In D140224#4014203 , @davide wrote: >> >>> @MaskRay Roy hasn't rep

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

rsundahl added a comment. > I'll reject [-\Xparser for a while as well. This is a valid amendment to > D139717 , so I don't think it needs more > approval. We have projects that are failing because of -Xlinker and I'm not too excited about walking through eve

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014230 , @MaskRay wrote: > In D140224#4014203 , @davide wrote: > >> @MaskRay Roy hasn't replied. We found other spellings that break (e.g. >> `-Xcctests` or something). Revert

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014203 , @davide wrote: > @MaskRay Roy hasn't replied. We found other spellings that break (e.g. > `-Xcctests` or something). Revert this patch until we find an agreement. D139717 (

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide reopened this revision. davide added a comment. This revision is now accepted and ready to land. @MaskRay Roy hasn't replied. We found other spellings that break (e.g. `-Xcctests` or something). Revert this patch until we find an agreement. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

This revision was automatically updated to reflect the committed changes. Closed by commit rG46cd3127fe54: [Driver] Revert D139717 and add -Xparser/-Xcompiler instead (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D140224?vs=483565&id=484938#toc Repository: rG LLVM

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I'll reject [-\Xparser for a while as well. This is a valid amendment to D139717 , so I don't think it needs more approval. Repository: rG LLVM Github

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

manojgupta added a subscriber: rpbeltran. manojgupta added a comment. > If ChromeOS needs time for migration, I think -Xcompiler can be temporarily > ignored. If you can wait for a few weeks, that'd be great. We are already fighting with a large number of ToT issues. And this change makes our b

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4001881 , @manojgupta wrote: > Here are a few instances of Xcompiler usage for a non-exhaustive search (I > can't look inside package tarballs if they are using it ): > > https://chromium.googlesource.com/chromiumos/o

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

manojgupta added a comment. Here are a few instances of Xcompiler usage for a non-exhaustive search (I can't look inside package tarballs if they are using it ): https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/main/net-vpn/openvpn/openvpn-2.4.4.ebuild#74 https://chromi

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4001748 , @manojgupta wrote: > Without -Xcompiler, ChromeOS code will break. It may not be supported by GCC > but it is supported in some other compilers like Cuda and a few others if you > search. Also being support

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

manojgupta added a comment. Without -Xcompiler, ChromeOS code will break. It may not be supported by GCC but it is supported in some other compilers like Cuda and a few others if you search. Also being supported by libtool makes it more important to keep it working. Repository: rG LLVM Gith

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. Fine if Roy is happy. If we find another thing that break, we'll let you know. Please wait for him to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140224/new/ https://reviews.llvm.org/D140224

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay updated this revision to Diff 483565. MaskRay added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140224/new/ https://reviews.llvm.org/D140224 Files: clang/include/clang/Driver/Options.td clang/test/Driver/warn-Xparser.c

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay created this revision. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some macOS projects use -Xparser even if it leads to a -Wunused-command-line-argument