MaskRay added a comment. In D140224#4001881 <https://reviews.llvm.org/D140224#4001881>, @manojgupta wrote:
> Here are a few instances of Xcompiler usage for a non-exhaustive search (I > can't look inside package tarballs if they are using it ): > > https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/main/net-vpn/openvpn/openvpn-2.4.4.ebuild#74 > https://chromium.googlesource.com/external/googleappengine/python/+/bedccc3dd4178880371cdf44064b222d82a5f30d/lib/distutils/distutils/extension.py#219 > > We already ignore Xcompiler for GCC in our compiler wrapper > (https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/main/compiler_wrapper/gcc_flags.go), > and we can do the same for clang as well. > So in theory, we'll be ok with the removal but it is annoying for sure to > deal with. This seems ChromeOS specific, not from Gentoo (according to `grep -rsin "Xcompiler" --include="*.ebuild"` done by sam AT gentoo). > `use static && append-ldflags -Xcompiler -static` This should just use `-static`, instead of `-Xcompiler -static`. `lib/distutils/distutils/extension.py#219` `-Xcompiler` seems unnecessary and I am unsure why it has it. If ChromeOS needs time for migration, I think `-Xcompiler` can be temporarily ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140224/new/ https://reviews.llvm.org/D140224 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
