MaskRay added a comment.

In D140224#4001748 <https://reviews.llvm.org/D140224#4001748>, @manojgupta 
wrote:

> Without -Xcompiler, ChromeOS code will break. It may not be supported by GCC 
> but it is supported in some other compilers like Cuda and a few others if you 
> search. Also being supported by libtool makes it more important to keep it 
> working.

Can you give more information how ChromeOS will break? My understanding is that 
libtool confumses `-Xcompiler foo` and passes `foo` to Clang. Clang Driver is 
not supposed to get `-Xcompiler` from libtool.
But I don't know how CUDA comes into play. It's possible the `-Xcompiler` 
interaction is not intended. If there is indeed problematic but widespread 
misuse of `-Xcompiler`, I can certainly add an ignored `-Xcompiler`, but I want 
to understand the problem first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140224/new/

https://reviews.llvm.org/D140224

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to