[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:647 +std::unique_ptr C( +TheDriver.BuildCompilation({"--gcc-toolchain="})); +ASSERT_TRUE(C); ebevhan wrote: > There's a b

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

ebevhan added a comment. Hi! This test is failing in some of our downstream builds. Comment at: clang/unittests/Driver/ToolChainTest.cpp:647 +std::unique_ptr C( +TheDriver.BuildCompilation({"--gcc-toolchain="})); +ASSERT_TRUE(C); There's a binar

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

nemanjai added subscribers: quinnp, nemanjai. nemanjai added a comment. The original toolchain detection added `root/usr` to the paths which was certainly necessary on PowerPC. Since that suffix is removed in this patch, our Redhat buildbot is now broken (https://lab.llvm.org/buildbot/#/builder

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 433673. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driver/ToolChainTest.cpp ==

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:623 + IntrusiveRefCntPtr DiagID(new DiagnosticIDs()); + struct TestDiagnosticConsumer : public DiagnosticConsumer {}; + MaskRay wrote:

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. In D125862#3552465 , @tbaeder wrote: > Ping. @MaskRay Can you take a quick look and check if this is what you had in > mind? LG Comment at: clang/unittests/Driver/ToolChainTest.cpp:615 +TEST(ToolChainTest, To

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder added a comment. Ping. @MaskRay Can you take a quick look and check if this is what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 ___ cfe-commits mailing list cfe-commits@

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 431928. tbaeder added a comment. @MaskRay Ignored the new test on Windows hosts now like you suggested. Does this look good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolC

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder added a comment. In D125862#3532630 , @MaskRay wrote: >> Harbormaster completed remote builds in `B165047: Diff 430277.` > > You can get Windows bot results in the link. Hm, the windows pre-merge checks don't fail. Just the buildbots. I wonder if

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 431609. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driver/ToolChainTest.cpp ==

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. Because of `TargetTriple.getOS() == llvm::Triple::Linux`, you need to guard the unittest under a similar check. > Harbormaster completed remote builds in `B165047: Diff 430277.` You can get Windows bot results in the link. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8717b492dfcd: [clang][driver] Dynamically select gcc-toolset/devtoolset version (authored by tbaeder). Changed prior to commit: https://reviews.ll

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Thanks! Comment at: clang/unittests/Driver/ToolChainTest.cpp:618 + + // Check (newer) GCC toolset installation + {

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 430597. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittes

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2164 + StringRef ToolsetDir = llvm::sys::path::filename(LI->path()); + + if (!ToolsetDir.startswith("gcc-toolset-") && delete blank line Comment at: clang/

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 430572. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driv

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. In addition, if every new GCC release requires addition to /opt/rh/gcc-toolset-$major (if I understand correctly), we probably want to switch to `llvm::vfs::directory_iterator` iteration and using the largest version. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

MaskRay added a comment. It may be time to add unittests to `clang/unittests/Driver/ToolChainTest.cpp` for /opt/rh detection. You may use `TEST(ToolChainTest, VFSGCCInstallation)` as an example creating a pseudo file hierarchy in memory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder created this revision. tbaeder added reviewers: tstellar, phosek. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This makes it possible to use the newest gcc-toolset/devtoolset on RHEL.