MaskRay added a comment.
In D125862#3552465 <https://reviews.llvm.org/D125862#3552465>, @tbaeder wrote:
> Ping. @MaskRay Can you take a quick look and check if this is what you had in
> mind?
LG
================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:615
+TEST(ToolChainTest, Toolsets) {
+
+ // Ignore this test on Windows hosts.
----------------
delete blank line
================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:623
+ IntrusiveRefCntPtr<DiagnosticIDs> DiagID(new DiagnosticIDs());
+ struct TestDiagnosticConsumer : public DiagnosticConsumer {};
+
----------------
delete `public`.
Can you avoid using a derived DiagnosticConsumer?
================
Comment at: clang/unittests/Driver/ToolChainTest.cpp:698
+ }
+ if (is_style_windows(llvm::sys::path::Style::native))
+ std::replace(S.begin(), S.end(), '\\', '/');
----------------
This should be removed if we exclude Windows.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125862/new/
https://reviews.llvm.org/D125862
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
