[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. In D117809#3306785 , @MaskRay wrote: > Thanks for working on such tools but the patch order is not right. > You should implement the functionality first, and in the last, add the driver > option. > The driver option is user-facing

[PATCH] D117809: [clang] Add an extract-api driver option

MaskRay added a comment. Thanks for working on such tools but the patch order is not right. You should implement the functionality first, and in the last, add the driver option. The driver option is user-facing and the availability makes users think the functionality is ready when it actually is

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. @morehouse should be fixed in 98fa46f870e4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809 ___

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. On it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D117809: [clang] Add an extract-api driver option

morehouse added inline comments. Comment at: clang/lib/Frontend/ExtractAPIConsumer.cpp:20 +private: + ASTContext *Context; +}; `ASTContext *Context` is unused, and causing buildbot failures: https://lab.llvm.org/buildbot/#/builders/77/builds/13645 ``` /var/li

[PATCH] D117809: [clang] Add an extract-api driver option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1d946cbf780: [clang] Add an extract-api driver option (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. Ping for any additional reviews/comments. I must admit that I got really confused and lost in the layers of the driver and setting up the phases. I wasn't sure if I made enough (or too many?) changes to make this work. So any comments or advice are welcomed. Repository:

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. Pre-merge check failure with clang-format complaints :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809 ___ cfe-commits mailing list cfe-

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added inline comments. Comment at: clang/include/clang/Driver/Types.def:103 TYPE("hip-fatbin", HIP_FATBIN, INVALID, "hipfb", phases::Compile, phases::Backend, phases::Assemble, phases::Link) +TYPE("api-information", API_INFO, INVALID,

[PATCH] D117809: [clang] Add an extract-api driver option

QuietMisdreavus added inline comments. Comment at: clang/include/clang/Driver/Types.def:103 TYPE("hip-fatbin", HIP_FATBIN, INVALID, "hipfb", phases::Compile, phases::Backend, phases::Assemble, phases::Link) +TYPE("api-information", API_INFO,

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw updated this revision to Diff 402074. zixuw added a comment. - Remove unrelated whitespace change - Remove unnecessary code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809 Files: clang/include/cla

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2431 {frontend::PrintDependencyDirectivesSourceMinimizerOutput, - OPT_print_dependency_directives_minimized_source}, }; ributzka wrote: > This looks like an unre

[PATCH] D117809: [clang] Add an extract-api driver option

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM. Just a few minor nits. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7082 CmdArgs.push_back(Args.MakeArgString(OutputFilename)); +} else if (Output.g

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw created this revision. Herald added subscribers: dang, mgorny. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the initial commit for the clang-extract-api RFC https://lists.llvm.org/pipermail/cfe-dev/2021-September/0687