zixuw added a comment. In D117809#3306785 <https://reviews.llvm.org/D117809#3306785>, @MaskRay wrote:
> Thanks for working on such tools but the patch order is not right. > You should implement the functionality first, and in the last, add the driver > option. > The driver option is user-facing and the availability makes users think the > functionality is ready when it actually isn't. I see. I was working on the functionality at the same time with this driver option, but it took longer and more complicated than I expected so I decided to post this as an initial patch to keep things small and incremental. I do have another patch ready to post very shortly. > I am also a bit unsure whether the option name should use the single-dash > `-e*` since `-e` is a short option taking a value, so a typo in > `-extract-api` cannot be detected. > By convention a two-dash option should be used. > (Yes, I know `-emit-llvm` is a violation.) That's an interesting find, I'll look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
