zixuw added inline comments.
================
Comment at: clang/include/clang/Driver/Types.def:103
TYPE("hip-fatbin", HIP_FATBIN, INVALID, "hipfb",
phases::Compile, phases::Backend, phases::Assemble, phases::Link)
+TYPE("api-information", API_INFO, INVALID, "json",
phases::Compile)
TYPE("none", Nothing, INVALID, nullptr,
phases::Compile, phases::Backend, phases::Assemble, phases::Link)
----------------
QuietMisdreavus wrote:
> Symbol graph files generally have the extension `.symbols.json` - is that
> something that should be reflected here?
Actually I don't know. Looking at other types in this file, I don't see any
existing ones with "two level" suffixes and I don't know if it makes sense (or
be any useful) to put that here. The output file name (including the suffix) is
still whatever the user put after the `-o` option. From the comment at the
beginning of this file, this suffix here is only used for temporary files
created, if any would be during the extract-api pipeline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117809/new/
https://reviews.llvm.org/D117809
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
